LineIntersector segment stack changes?? #1101
-
|
Hi Robert, I just updated all the VSG libraries today for the first time in a couple of months and found that my line intersectors are not working any more. I use MatrixTransforms to offset groups of vertices (OctTree), so the vertex and intersector data must be consistently either in local or in world coordinates. It used to all work in local coordinates, but now none of my intersections work and it looks like the vsg::LineSegmentIntersector::_lineSegmentStack is storing world coordinates. Is this the case? If so, is this a bug or an intended change? Apologies if I've missed a post about it. Regards, |
Beta Was this translation helpful? Give feedback.
Replies: 5 comments
-
|
Sorry about this. Another user reported an issue like this yesterday. Looks like a regression around the time I merged the Animation work. It's the first thing I'll tackle today. |
Beta Was this translation helpful? Give feedback.
-
|
I have used git bisect this morning to figure out when the regression happened and have pin pointed it to: |
Beta Was this translation helpful? Give feedback.
-
|
I have created Issue #1102 for this regression. I will examine the problem commit so see why it causes the bug, I should be able to figure out a fix this morning. |
Beta Was this translation helpful? Give feedback.
-
|
I have tracked down the regression to the previous use of default copy constructor, that's not possible when using CopyOp so I have implemented the copy constructor manually: |
Beta Was this translation helpful? Give feedback.
-
|
Fixed by Robert in the issue mentioned above. I'll close this now. |
Beta Was this translation helpful? Give feedback.
I have tracked down the regression to the previous use of default copy constructor, that's not possible when using CopyOp so I have implemented the copy constructor manually:
1380b6a