Fix naming

Author: Gabriel Saratura

pkg/comp-functions/functions/common/maintenance/maintenance.go

@@ -515,15 +515,10 @@ func (m *Maintenance) createInitialMaintenanceJob(_ context.Context) error {
 // SetReleaseVersion sets the version from the claim if it's a new instance otherwise it is managed by maintenance function.
 // It will return the concrete observed version as well.
 // If the desired values contain a higher version than either the observed or the comp version, it will take precedence.
-//
-// If pinImageTag is set (non-empty):
-//   - The exact pinned tag is used unconditionally
-//   - Downgrades ARE allowed: the customer takes full responsibility
-//   - No version comparison is performed
 func SetReleaseVersion(ctx context.Context, version string, desiredValues map[string]interface{}, observedValues map[string]interface{}, fields []string, pinImageTag string) (string, error) {
 	l := controllerruntime.LoggerFrom(ctx)
 
-	// If an image tag is pinned, use it unconditionally (allow downgrades)
+	// If an image tag is pinned, use it unconditionally, downgrades ARE allowed on user's own risk
 	if pinImageTag != "" {
 		l.Info("Using pinned image tag", "pinnedTag", pinImageTag)
 		return pinImageTag, unstructured.SetNestedField(desiredValues, pinImageTag, fields...)

pkg/comp-functions/functions/vshnmariadb/backup.go

@@ -27,7 +27,8 @@ func AddBackupMariadb(ctx context.Context, comp *vshnv1.VSHNMariaDB, svc *runtim
 		return runtime.NewFatalResult(fmt.Errorf("failed to parse composite: %w", err))
 	}
 
-	// CurrentReleaseTag is being overriden in other functions 
+	// Setting the version may be lost in other functions, reinforce it here
+	// TODO Fix status field being overwritten every time SetDesiredCompositeStatus() function is called 
 	if comp.Spec.Parameters.Maintenance.PinImageTag != "" {
 		comp.Status.MariaDBVersion = comp.Spec.Parameters.Maintenance.PinImageTag
 	}

pkg/comp-functions/functions/vshnmariadb/proxysql.go

@@ -98,7 +98,8 @@ func AddProxySQL(_ context.Context, comp *vshnv1.VSHNMariaDB, svc *runtime.Servi
 		return runtime.NewWarningResult(fmt.Sprintf("cannot create PDB for ProxySQL: %s", err))
 	}
 
-	// CurrentReleaseTag is being overriden in other functions 
+	// Setting the version may be lost in other functions, reinforce it here
+	// TODO Fix status field being overwritten every time SetDesiredCompositeStatus() function is called 
 	if comp.Spec.Parameters.Maintenance.PinImageTag != "" {
 		comp.Status.MariaDBVersion = comp.Spec.Parameters.Maintenance.PinImageTag
 	}

pkg/comp-functions/functions/vshnredis/maintenance.go

@@ -17,7 +17,8 @@ func AddMaintenanceJob(ctx context.Context, comp *vshnv1.VSHNRedis, svc *runtime
 		return runtime.NewFatalResult(fmt.Errorf("can't get composite: %w", err))
 	}
 
-	// CurrentReleaseTag is being overriden in other functions 
+	// Setting the version may be lost in other functions, reinforce it here
+	// TODO Fix status field being overwritten every time SetDesiredCompositeStatus() function is called 
 	if comp.Spec.Parameters.Maintenance.PinImageTag != "" {
 		comp.Status.CurrentReleaseTag = comp.Spec.Parameters.Maintenance.PinImageTag
 	}