Merge pull request #318 from vshn/fix/deletion_protection_unmanaged_non_converged

Fix a bug where unmanaged objects aren't protected

Author: Kidswiss

.devcontainer/postCreateCommand.sh

@@ -13,6 +13,22 @@ source <(kubectl completion zsh)
 complete -F __start_kubectl k
 " >> $HOME/.zshrc
 
+(
+  set -x; cd "$(mktemp -d)" &&
+  OS="$(uname | tr '[:upper:]' '[:lower:]')" &&
+  ARCH="$(uname -m | sed -e 's/x86_64/amd64/' -e 's/\(arm\)\(64\)\?.*/\1\2/' -e 's/aarch64$/arm64/')" &&
+  KREW="krew-${OS}_${ARCH}" &&
+  curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/latest/download/${KREW}.tar.gz" &&
+  tar zxvf "${KREW}.tar.gz" &&
+  ./"${KREW}" install krew
+)
+
+sudo ln -s "$HOME/.krew/bin/kubectl-krew" /usr/local/bin/kubectl-krew
+
+kubectl krew install view-serviceaccount-kubeconfig
+
+sudo ln -s "$HOME/.krew/bin/kubectl-view_serviceaccount_kubeconfig" /usr/local/bin/kubectl-view_serviceaccount_kubeconfig
+
 make setup-kindev
 
 cp .kind/.kind/kind-config ~/.kube/config

Makefile

@@ -230,8 +230,7 @@ render-diff: ## Render diff between the cluster in KUBECONF and the local branch
 
 setup-kindev: ## Setup kindev in the .kind folder, will always create a new instance
 	rm -rf .kind && \
-	git clone --depth=1 https://github.com/vshn/kindev .kind && \
+	git clone https://github.com/vshn/kindev .kind && \
 	cd .kind && \
-	rm -rf .git && \
 	make clean && \
 	make vshnall

pkg/controller/webhooks/deletionprotection.go

@@ -120,11 +120,8 @@ func checkManagedObject(ctx context.Context, obj client.Object, c client.Client,
 func checkUnmanagedObject(ctx context.Context, obj client.Object, c client.Client, cpClient client.Client, l logr.Logger) (compositeInfo, error) {
 	namespace := &corev1.Namespace{}
 
-	if cpClient == nil {
-		cpClient = c
-	}
-
-	err := cpClient.Get(ctx, client.ObjectKey{Name: obj.GetNamespace()}, namespace)
+	// we need to check namespaces against the local service cluster, otherwise they are never actually found
+	err := c.Get(ctx, client.ObjectKey{Name: obj.GetNamespace()}, namespace)
 	if err != nil {
 		if apierrors.IsNotFound(err) {
 			return compositeInfo{Exists: false}, nil