Check arguments in DelayPolicy implementations

Author: vsilaev

src/main/java/net/tascalate/concurrent/delays/BoundedMaxDelayPolicy.java

@@ -43,6 +43,9 @@ public BoundedMaxDelayPolicy(DelayPolicy target, long maxDelayMillis) {
 
     public BoundedMaxDelayPolicy(DelayPolicy target, Duration maxDelay) {
         super(target);
+        if (!DelayPolicy.isValid(maxDelay)) {
+            throw new IllegalArgumentException("MaxDelay must be positive but was: " + maxDelay);
+        }
         this.maxDelay = maxDelay;
     }
 

src/main/java/net/tascalate/concurrent/delays/BoundedMinDelayPolicy.java

@@ -42,6 +42,9 @@ public BoundedMinDelayPolicy(DelayPolicy target, long minDelayMillis) {
 
     public BoundedMinDelayPolicy(DelayPolicy target, Duration minDelay) {
         super(target);
+        if (!DelayPolicy.isValid(minDelay)) {
+            throw new IllegalArgumentException("MinDelay must be positive but was: " + minDelay);
+        }
         this.minDelay = minDelay;
     }
 

src/main/java/net/tascalate/concurrent/delays/DurationCalcs.java

@@ -32,7 +32,7 @@ static Duration safeTransform(Duration duration, LongBinaryOperator isConversion
             }
         }
         // return max possible value if doesn't fit
-        return Duration.of(Long.MAX_VALUE, TIME_DIMENSIONS[count - 1]);
+        return MAX_DURATION;
 
     }
 
@@ -75,4 +75,5 @@ private static boolean toBoolean(long v) {
 
     private static final Duration MAX_BY_NANOS  = Duration.ofNanos(Long.MAX_VALUE);
     private static final Duration MAX_BY_MILLIS = Duration.ofMillis(Long.MAX_VALUE);
+    private static final Duration MAX_DURATION  = Duration.ofSeconds(Long.MAX_VALUE).withNanos(999_999_999);
 }

src/main/java/net/tascalate/concurrent/delays/ExponentialDelayPolicy.java

@@ -43,6 +43,9 @@ public ExponentialDelayPolicy(Duration initialDelay, double multiplier) {
         if (!DelayPolicy.isValid(initialDelay)) {
             throw new IllegalArgumentException("Initial delay must be positive but was: " + initialDelay);
         }
+        if (multiplier <= 0) {
+            throw new IllegalArgumentException("Multiplier must be a positive number but was: " + multiplier);
+        }
         this.initialDelay = initialDelay;
         this.multiplier = multiplier;
     }

src/main/java/net/tascalate/concurrent/delays/ProportionalRandomDelayPolicy.java

@@ -44,29 +44,29 @@ public ProportionalRandomDelayPolicy(DelayPolicy target, Random random) {
 
     public ProportionalRandomDelayPolicy(DelayPolicy target, double multiplier) {
         super(target);
-        if (multiplier <= 0 || multiplier >= 1) {
-            throw new IllegalArgumentException("Multiplier should be within (0..1) exclusively");
+        if (multiplier <= 0) {
+            throw new IllegalArgumentException("Multiplier must be a positive number but was: " + multiplier);
         }
         this.multiplier = multiplier;
     }
 
     public ProportionalRandomDelayPolicy(DelayPolicy target, double multiplier, Random random) {
         super(target, random);
-        if (multiplier <= 0 || multiplier >= 1) {
-            throw new IllegalArgumentException("Multiplier should be within (0..1) exclusively");
+        if (multiplier <= 0) {
+            throw new IllegalArgumentException("Multiplier must be a positive number but was: " + multiplier);
         }
         this.multiplier = multiplier;
     }
 
     @Override
     long addRandomJitter(long initialDelay, double randomizer, int dimIdx) {
         double randomMultiplier = (1 - 2 * randomizer) * multiplier;
-        return (long) (initialDelay * (1 + randomMultiplier));
+        return Math.max(0, (long) (initialDelay * (1 + randomMultiplier)));
     }
 
     @Override
     boolean checkBounds(long initialDelay, double randomizer, int dimIdx) {
         double randomMultiplier = (1 - 2 * randomizer) * multiplier;
-        return Long.MAX_VALUE / initialDelay > randomMultiplier + 1;
+        return Long.MAX_VALUE / initialDelay > 1 + randomMultiplier;
     }
 }

src/main/java/net/tascalate/concurrent/delays/UniformRandomDelayPolicy.java

@@ -49,6 +49,9 @@ public UniformRandomDelayPolicy(DelayPolicy target, long range) {
 
     public UniformRandomDelayPolicy(DelayPolicy target, Duration range) {
         super(target);
+        if (!DelayPolicy.isValid(range)) {
+            throw new IllegalArgumentException("Range must be positive but was: " + range);
+        }
         this.range = range;
     }
 
@@ -58,6 +61,9 @@ public UniformRandomDelayPolicy(DelayPolicy target, long range, Random random) {
 
     public UniformRandomDelayPolicy(DelayPolicy target, Duration range, Random random) {
         super(target, random);
+        if (!DelayPolicy.isValid(range)) {
+            throw new IllegalArgumentException("Range must be positive but was: " + range);
+        }
         this.range = range;
     }