Fix invalid rounding in DurationCalcs.safeExtractAmount

vsilaev · vsilaev · commit 7f417d11559a · 2018-03-15T21:23:30.000+03:00
diff --git a/src/main/java/net/tascalate/concurrent/delays/DurationCalcs.java b/src/main/java/net/tascalate/concurrent/delays/DurationCalcs.java
@@ -54,7 +54,7 @@ static long safeExtractAmount(Duration duration, int targetDimIdx) {
             return amount;
         }
         double factor = Math.pow(1000, sourceDimIdx - targetDimIdx);
-        if (Long.MAX_VALUE / amount > factor) {
+        if ((double)Long.MAX_VALUE / amount > factor) {
             return  (long)(amount * factor);
         } else {
             return Long.MAX_VALUE;

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ static long safeExtractAmount(Duration duration, int targetDimIdx) {`
`54`	`54`	`return amount;`
`55`	`55`	`}`
`56`	`56`	`double factor = Math.pow(1000, sourceDimIdx - targetDimIdx);`
`57`		`- if (Long.MAX_VALUE / amount > factor) {`
	`57`	`+ if ((double)Long.MAX_VALUE / amount > factor) {`
`58`	`58`	`return (long)(amount * factor);`
`59`	`59`	`} else {`
`60`	`60`	`return Long.MAX_VALUE;`