Rework CDI Java agent to use ResourceTransformer; extract shared Java Agent code; Move ContinuableClassInfo / ContinuableClassInfoResolver to provider-specific artefacts (remove from SPI); fix RewritingUtils to keep hard-reference on URLClassloader.

Author: vsilaev

net.tascalate.javaflow.providers.asm3/src/main/java/org/apache/commons/javaflow/providers/asm3/Asm3ResourceTransformationFactory.java

@@ -20,7 +20,6 @@
 import org.apache.commons.javaflow.spi.Cache;
 import org.apache.commons.javaflow.spi.ClassMatcher;
 import org.apache.commons.javaflow.spi.ClassMatchers;
-import org.apache.commons.javaflow.spi.ContinuableClassInfoResolver;
 import org.apache.commons.javaflow.spi.ResourceLoader;
 import org.apache.commons.javaflow.spi.ResourceTransformationFactory;
 import org.apache.commons.javaflow.spi.ResourceTransformer;

net.tascalate.javaflow.spi/src/main/java/org/apache/commons/javaflow/spi/ContinuableClassInfo.java renamed to net.tascalate.javaflow.providers.asm3/src/main/java/org/apache/commons/javaflow/providers/asm3/ContinuableClassInfo.java

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.commons.javaflow.spi;
+package org.apache.commons.javaflow.providers.asm3;
 
 public interface ContinuableClassInfo {
     boolean isContinuableMethod(int access, String name, String desc, String signature);

net.tascalate.javaflow.spi/src/main/java/org/apache/commons/javaflow/spi/ContinuableClassInfoResolver.java renamed to net.tascalate.javaflow.providers.asm3/src/main/java/org/apache/commons/javaflow/providers/asm3/ContinuableClassInfoResolver.java

@@ -13,9 +13,10 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.commons.javaflow.spi;
+package org.apache.commons.javaflow.providers.asm3;
 
 import java.io.IOException;
+import java.util.Collection;
 
 public interface ContinuableClassInfoResolver {
     ContinuableClassInfo resolve(String className) throws IOException;
@@ -24,5 +25,7 @@ public interface ContinuableClassInfoResolver {
 
     boolean isContinuableAnnotation(String annotationClassDescriptor);
 
+    void reset(Collection<String> classNames);
+    
     void release();
 }

net.tascalate.javaflow.providers.asm3/src/main/java/org/apache/commons/javaflow/providers/asm3/ContinuableMethodNode.java

@@ -49,9 +49,6 @@
 import org.objectweb.asm.tree.analysis.SourceInterpreter;
 import org.objectweb.asm.tree.analysis.SourceValue;
 
-import org.apache.commons.javaflow.spi.ContinuableClassInfo;
-import org.apache.commons.javaflow.spi.ContinuableClassInfoResolver;
-
 class ContinuableMethodNode extends MethodNode implements Opcodes {
     private final ClassHierarchy classHierarchy;
     private final ContinuableClassInfoResolver cciResolver;

net.tascalate.javaflow.providers.asm3/src/main/java/org/apache/commons/javaflow/providers/asm3/IContinuableClassInfo.java

@@ -17,8 +17,6 @@
 
 import java.util.Set;
 
-import org.apache.commons.javaflow.spi.ContinuableClassInfo;
-
 class IContinuableClassInfo implements ContinuableClassInfo {
     private boolean processed;
     private final Set<String> methods;

net.tascalate.javaflow.providers.asm3/src/main/java/org/apache/commons/javaflow/providers/asm3/IContinuableClassInfoResolver.java

@@ -28,7 +28,6 @@
 import org.objectweb.asm.Type;
 
 import org.apache.commons.javaflow.spi.ClassMatcher;
-import org.apache.commons.javaflow.spi.ContinuableClassInfoResolver;
 import org.apache.commons.javaflow.spi.ResourceLoader;
 
 class IContinuableClassInfoResolver implements ContinuableClassInfoResolver {
@@ -100,7 +99,7 @@ public void release() {
         cciShared.mergeWith(visitedClasses, processedAnnotations, continuableAnnotations);
     }
 
-    void reset(Collection<String> classNames) {
+    public void reset(Collection<String> classNames) {
         visitedClasses.keySet().removeAll(classNames);
         refreshClasses.addAll(classNames);
     }

net.tascalate.javaflow.providers.asm3/src/main/java/org/apache/commons/javaflow/providers/asm3/MaybeContinuableAnnotationVisitor.java

@@ -15,8 +15,6 @@
  */
 package org.apache.commons.javaflow.providers.asm3;
 
-import org.apache.commons.javaflow.spi.ContinuableClassInfoResolver;
-
 import org.objectweb.asm.AnnotationVisitor;
 import org.objectweb.asm.ClassAdapter;
 import org.objectweb.asm.Opcodes;

net.tascalate.javaflow.providers.asm3/src/main/java/org/apache/commons/javaflow/providers/asm3/MaybeContinuableClassVisitor.java

@@ -21,8 +21,6 @@
 import java.util.Map;
 import java.util.Set;
 
-import org.apache.commons.javaflow.spi.ContinuableClassInfoResolver;
-
 import org.objectweb.asm.AnnotationVisitor;
 import org.objectweb.asm.ClassAdapter;
 import org.objectweb.asm.MethodAdapter;

net.tascalate.javaflow.providers.asm4/src/main/java/org/apache/commons/javaflow/providers/asm4/Asm4ResourceTransformationFactory.java

@@ -20,7 +20,6 @@
 import org.apache.commons.javaflow.spi.Cache;
 import org.apache.commons.javaflow.spi.ClassMatcher;
 import org.apache.commons.javaflow.spi.ClassMatchers;
-import org.apache.commons.javaflow.spi.ContinuableClassInfoResolver;
 import org.apache.commons.javaflow.spi.ResourceLoader;
 import org.apache.commons.javaflow.spi.ResourceTransformationFactory;
 import org.apache.commons.javaflow.spi.ResourceTransformer;

net.tascalate.javaflow.providers.asm4/src/main/java/org/apache/commons/javaflow/providers/asm4/ContinuableClassInfo.java

@@ -0,0 +1,20 @@
+/**
+ * Copyright 2013-2019 Valery Silaev (http://vsilaev.com)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.javaflow.providers.asm4;
+
+public interface ContinuableClassInfo {
+    boolean isContinuableMethod(int access, String name, String desc, String signature);
+}