Skip to content

Commit a9741cb

Browse files
committed
Move responsibility to resolve class name out from resourceTransformationFactory
1 parent 41bc9d5 commit a9741cb

File tree

10 files changed

+665
-38
lines changed

10 files changed

+665
-38
lines changed

net.tascalate.javaflow.providers.asm3/src/main/java/org/apache/commons/javaflow/providers/asm3/Asm3ResourceTransformationFactory.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
import org.apache.commons.javaflow.spi.ResourceTransformer;
2626
import org.apache.commons.javaflow.spi.VetoableResourceLoader;
2727

28-
import org.objectweb.asm.ClassReader;
29-
3028
public class Asm3ResourceTransformationFactory implements ResourceTransformationFactory {
3129

3230
public ResourceTransformer createTransformer(ResourceLoader resourceLoader) {
@@ -44,10 +42,6 @@ public ContinuableClassInfoResolver createResolver(ResourceLoader resourceLoader
4442
CACHED_SHARED_CCI.get(resourceLoader)
4543
);
4644
}
47-
48-
public String readClassName(byte[] classBytes) {
49-
return new ClassReader(classBytes).getClassName();
50-
}
5145

5246
static ClassMatcher createVeto(ResourceLoader resourceLoader) {
5347
if (resourceLoader instanceof VetoableResourceLoader) {

net.tascalate.javaflow.providers.asm4/src/main/java/org/apache/commons/javaflow/providers/asm4/AbstractResourceTransformationFactory.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
import org.apache.commons.javaflow.spi.ResourceTransformer;
1111
import org.apache.commons.javaflow.spi.VetoableResourceLoader;
1212

13-
import org.objectweb.asm.ClassReader;
14-
1513
public abstract class AbstractResourceTransformationFactory implements ResourceTransformationFactory {
1614

1715
public ResourceTransformer createTransformer(ResourceLoader resourceLoader) {
@@ -34,10 +32,6 @@ public ContinuableClassInfoResolver createResolver(ResourceLoader resourceLoader
3432
CACHED_SHARED_CCI.get(resourceLoader)
3533
);
3634
}
37-
38-
public String readClassName(byte[] classBytes) {
39-
return new ClassReader(classBytes).getClassName();
40-
}
4135

4236
static ClassMatcher createVeto(ResourceLoader resourceLoader) {
4337
if (resourceLoader instanceof VetoableResourceLoader) {

net.tascalate.javaflow.providers.asm5/src/main/java/org/apache/commons/javaflow/providers/asm5/AbstractResourceTransformationFactory.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
import org.apache.commons.javaflow.spi.ResourceTransformer;
1111
import org.apache.commons.javaflow.spi.VetoableResourceLoader;
1212

13-
import org.objectweb.asm.ClassReader;
14-
1513
public abstract class AbstractResourceTransformationFactory implements ResourceTransformationFactory {
1614

1715
public ResourceTransformer createTransformer(ResourceLoader resourceLoader) {
@@ -34,10 +32,6 @@ public ContinuableClassInfoResolver createResolver(ResourceLoader resourceLoader
3432
CACHED_SHARED_CCI.get(resourceLoader)
3533
);
3634
}
37-
38-
public String readClassName(byte[] classBytes) {
39-
return new ClassReader(classBytes).getClassName();
40-
}
4135

4236
static ClassMatcher createVeto(ResourceLoader resourceLoader) {
4337
if (resourceLoader instanceof VetoableResourceLoader) {

net.tascalate.javaflow.providers.asmx/src/main/java/org/apache/commons/javaflow/providers/asmx/AbstractResourceTransformationFactory.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,7 @@
1818
import org.apache.commons.javaflow.spi.ResourceLoader;
1919
import org.apache.commons.javaflow.spi.ResourceTransformationFactory;
2020

21-
import net.tascalate.asmx.ClassReader;
22-
2321
public abstract class AbstractResourceTransformationFactory implements ResourceTransformationFactory {
2422

2523
public abstract ContinuableClassInfoResolver createResolver(ResourceLoader resourceLoader);
26-
27-
public String readClassName(byte[] classBytes) {
28-
return new ClassReader(classBytes).getClassName();
29-
}
3024
}

0 commit comments

Comments
 (0)