Fixed setting Order.AveragePrice to null when Quantity is zero (DigitalRuby#646)

- also fixed Binance statii: PendingCancel and Error
- also fixed fetching only Open orders on Coinbase OnGetOpenOrderDetailsAsync()

Author: vslee

src/ExchangeSharp/API/Exchanges/BL3P/ExchangeBL3PAPI.cs

@@ -335,7 +335,7 @@ protected override async Task<ExchangeOrderResult> OnGetOrderDetailsAsync(string
 				Price = result.Price.Value,
 				Result = result.Status.ToResult(result.TotalAmount),
 				AmountFilled = result.TotalAmount.Value,
-				AveragePrice = result.AverageCost?.Value ?? 0M,
+				AveragePrice = result.AverageCost?.Value,
 				FeesCurrency = result.TotalFee.Currency,
 				FillDate = result.DateClosed ?? DateTime.MinValue,
 				IsBuy = result.Type == BL3POrderType.Bid,

src/ExchangeSharp/API/Exchanges/BinanceGroup/BinanceGroupCommon.cs

@@ -318,7 +318,6 @@ protected override async Task<IWebSocket> OnGetDeltaOrderBookWebSocketAsync(Acti
 			});
 		}
 
-
 		protected override async Task<ExchangeOrderBook> OnGetOrderBookAsync(string marketSymbol, int maxCount = 100)
 		{
 			JToken obj = await MakeJsonRequestAsync<JToken>("/depth?symbol=" + marketSymbol + "&limit=" + maxCount);
@@ -952,7 +951,9 @@ private ExchangeAPIOrderResult ParseExchangeAPIOrderResult(string status, decima
 				case "CANCELED":
 					return amountFilled > 0 ? ExchangeAPIOrderResult.FilledPartiallyAndCancelled : ExchangeAPIOrderResult.Canceled;
 				case "PENDING_CANCEL":
+					return ExchangeAPIOrderResult.PendingCancel;
 				case "EXPIRED":
+					return ExchangeAPIOrderResult.Error;
 				case "REJECTED":
 					return ExchangeAPIOrderResult.Canceled;
 				default:
@@ -1022,7 +1023,7 @@ private void ParseAveragePriceAndFeesFromFills(ExchangeOrderResult result, JToke
 				}
 			}
 
-			result.AveragePrice = (totalQuantity == 0 ? 0 : totalCost / totalQuantity);
+			result.AveragePrice = (totalQuantity == 0 ? null : (decimal?)(totalCost / totalQuantity));
 		}
 
 		protected override Task ProcessRequestAsync(IHttpWebRequest request, Dictionary<string, object>? payload)

src/ExchangeSharp/API/Exchanges/BinanceGroup/Models/UserDataStream.cs

@@ -7,7 +7,7 @@
 
 namespace ExchangeSharp.BinanceGroup
 {
-	internal class ExecutionReport
+	public class ExecutionReport
 	{
 		[JsonProperty("e")]
 		public string EventType { get; set; }
@@ -75,7 +75,7 @@ public override string ToString()
 
 	}
 
-	internal class Order
+	public class Order
 	{
 		[JsonProperty("s")]
 		public string Symbol { get; set; }
@@ -90,7 +90,7 @@ public override string ToString()
 		}
 	}
 
-	internal class ListStatus
+	public class ListStatus
 	{
 		[JsonProperty("e")]
 		public string EventType { get; set; }
@@ -121,7 +121,7 @@ public override string ToString()
 		}
 	}
 
-	internal class Balance
+	public class Balance
 	{
 		[JsonProperty("a")]
 		public string Asset { get; set; }
@@ -136,7 +136,7 @@ public override string ToString()
 		}
 	}
 
-	internal class OutboundAccount
+	public class OutboundAccount
 	{
 		[JsonProperty("e")]
 		public string EventType { get; set; }

src/ExchangeSharp/API/Exchanges/Coinbase/ExchangeCoinbaseAPI.cs

@@ -80,7 +80,7 @@ private ExchangeOrderResult ParseOrder(JToken result)
 			decimal amount = result["size"].ConvertInvariant<decimal>(amountFilled);
 			decimal price = result["price"].ConvertInvariant<decimal>();
 			decimal stop_price = result["stop_price"].ConvertInvariant<decimal>();
-			decimal averagePrice = (amountFilled <= 0m ? 0m : executedValue / amountFilled);
+			decimal? averagePrice = (amountFilled <= 0m ? null : (decimal?)(executedValue / amountFilled));
 			decimal fees = result["fill_fees"].ConvertInvariant<decimal>();
 			string marketSymbol = result["product_id"].ToStringInvariant(result["id"].ToStringInvariant());
 
@@ -603,7 +603,7 @@ protected override async Task<ExchangeOrderResult> OnGetOrderDetailsAsync(string
 		protected override async Task<IEnumerable<ExchangeOrderResult>> OnGetOpenOrderDetailsAsync(string marketSymbol = null)
 		{
 			List<ExchangeOrderResult> orders = new List<ExchangeOrderResult>();
-			JArray array = await MakeJsonRequestAsync<JArray>("orders?status=all" + (string.IsNullOrWhiteSpace(marketSymbol) ? string.Empty : "&product_id=" + marketSymbol), null, await GetNoncePayloadAsync(), "GET");
+			JArray array = await MakeJsonRequestAsync<JArray>("orders?status=open,pending,active" + (string.IsNullOrWhiteSpace(marketSymbol) ? string.Empty : "&product_id=" + marketSymbol), null, await GetNoncePayloadAsync(), "GET");
 			foreach (JToken token in array)
 			{
 				orders.Add(ParseOrder(token));

src/ExchangeSharp/API/Exchanges/GateIo/ExchangeGateIoAPI.cs

@@ -341,7 +341,7 @@ private ExchangeOrderResult ParseOrder(JToken order)
 		{
 			decimal amount = order["amount"].ConvertInvariant<decimal>();
 			decimal amountFilled = amount - order["left"].ConvertInvariant<decimal>();
-			decimal fillPrice = amountFilled == 0 ? 0 : order["filled_total"].ConvertInvariant<decimal>() / amountFilled;
+			decimal? fillPrice = amountFilled == 0 ? null : (decimal?)(order["filled_total"].ConvertInvariant<decimal>() / amountFilled);
 			decimal price = order["price"].ConvertInvariant<decimal>();
 			var result = new ExchangeOrderResult
 			{

src/ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs

@@ -375,7 +375,7 @@ private void ParseAveragePriceAndFeesFromFills(ExchangeOrderResult result, JToke
                 }
             }
 
-            result.AveragePrice = (totalQuantity == 0 ? 0 : totalCost / totalQuantity);
+            result.AveragePrice = (totalQuantity == 0 ? null : (decimal?)(totalCost / totalQuantity));
         }
 
         protected override async Task<ExchangeDepositDetails> OnGetDepositAddressAsync(string currency, bool forceRegenerate = false)