Skip to content

Commit 6b62b86

Browse files
authored
Merge pull request #41 from samwatkinson1/remove-document-event-handlers
Bind "mouseup.spinner" to the spinner element itself
2 parents 7cdd8bd + ecd782f commit 6b62b86

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/input-spinner.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
this.$el.on({
3232
'focus.spinner': (function(e) {
3333
e.preventDefault();
34-
$(document).trigger('mouseup.spinner');
34+
$(this.$el).trigger('mouseup.spinner');
3535
this.oldValue = this.value();
3636
}).bind(this),
3737
'change.spinner': (function(e) {
@@ -144,12 +144,8 @@
144144

145145
this.$el
146146
.on('click.spinner', '[data-spin="up"], [data-spin="down"]', this.spin.bind(this))
147-
.on('mousedown.spinner', '[data-spin="up"], [data-spin="down"]', this.spin.bind(this));
148-
149-
$(document).on('mouseup.spinner', (function() {
150-
clearTimeout(this.spinTimeout);
151-
clearInterval(this.spinInterval);
152-
}).bind(this));
147+
.on('mousedown.spinner', '[data-spin="up"], [data-spin="down"]', this.spin.bind(this))
148+
.on('mouseup.spinner', '[data-spin="up"], [data-spin="down"]', this.spin.bind(this));
153149

154150
if (options.delay) {
155151
this.delay(options.delay);
@@ -182,6 +178,10 @@
182178
this.spinTimeout = setTimeout(this.beginSpin.bind(this, dir), 300);
183179
}
184180
break;
181+
case 'mouseup':
182+
clearTimeout(this.spinTimeout);
183+
clearInterval(this.spinInterval);
184+
break;
185185
}
186186
},
187187

0 commit comments

Comments
 (0)