lint fix

Author: rebeca

package.json

@@ -39,5 +39,8 @@
     "lint-staged": "^10.0.2",
     "prettier": "2.3.2",
     "typescript": "^3.7.5"
+  },
+  "dependencies": {
+    "lint": "^0.7.0"
   }
 }

react/__tests__/components/SKUSelector.test.tsx

@@ -1408,10 +1408,8 @@ describe('<SKUSelector />', () => {
 
     expect(queryByText('Yellow')).toBeFalsy()
   })
-  
+
   it('must order sku specification to be sorted in alphabetical order', async () => {
-    const defaultSeller =  {sellerDefault: true, commertialOffer: { Price: 1, ListPrice: 1, AvailableQuantity: 2 }}
-   
     const skuItems = [
       {
         itemId: '1',
@@ -1420,7 +1418,6 @@ describe('<SKUSelector />', () => {
           { name: 'Size', values: ['43'] },
           { name: 'Color', values: ['Gray'] },
         ],
-        sellers: [defaultSeller],
         images: [],
       },
       {
@@ -1433,7 +1430,6 @@ describe('<SKUSelector />', () => {
           },
           { name: 'Color', values: ['Gray'] },
         ],
-        sellers: [defaultSeller],
         images: [],
       },
       {
@@ -1446,17 +1442,20 @@ describe('<SKUSelector />', () => {
           },
           { name: 'Color', values: ['Gray'] },
         ],
-        sellers: [defaultSeller],
         images: [],
       },
     ]
 
-    const {container} =  renderComponent({ sortVariationsByLabel:true,skuSelected:skuItems[0], skuItems:skuItems})
-    
+    const { container } = renderComponent({
+      sortVariationsByLabel: true,
+      skuSelected: skuItems[0],
+      skuItems,
+    })
+
     const options = container.querySelectorAll('.skuSelectorItemTextValue')
+
     expect(options[0]).toHaveTextContent('41')
     expect(options[1]).toHaveTextContent('42')
     expect(options[2]).toHaveTextContent('43')
-    })
+  })
 })
-

react/components/SKUSelector/components/SKUSelector.tsx

@@ -141,69 +141,69 @@ const parseOptionNameToDisplayOption =
     hideImpossibleCombinations: boolean
     disableUnavailableSelectOptions: boolean
   }) =>
-    (variationValue: {
-      name: string
-      originalName: string
-    }): DisplayOption | null => {
-      const isSelected = selectedVariations[variationName] === variationValue.name
-      const image = imagesMap?.[variationName]?.[variationValue.name]
-
-      const newSelectedVariation = clone(selectedVariations)
-
-      newSelectedVariation[variationName] = isSelected
-        ? null
-        : variationValue.name
-
-      const possibleItems = findListItemsWithSelectedVariations(
-        skuItems,
-        newSelectedVariation
-      )
+  (variationValue: {
+    name: string
+    originalName: string
+  }): DisplayOption | null => {
+    const isSelected = selectedVariations[variationName] === variationValue.name
+    const image = imagesMap?.[variationName]?.[variationValue.name]
 
-      if (possibleItems.length > 0) {
-        // This is a valid combination option
-        const [item] = possibleItems
-        const callbackFn = onSelectItemMemo({
-          name: variationName,
-          value: variationValue.name,
-          skuId: item.itemId,
-          isMainAndImpossible: false,
-          possibleItems,
-        })
+    const newSelectedVariation = clone(selectedVariations)
 
-        return {
-          label: variationValue.name,
-          originalName: variationValue.originalName,
-          onSelectItem: callbackFn,
-          image,
-          available: showItemAsAvailable({
-            possibleItems,
-            selectedVariations,
-            variationCount,
-            isSelected,
-          }),
-          impossible: false,
-          disabled: disableUnavailableSelectOptions,
-        }
-      }
+    newSelectedVariation[variationName] = isSelected
+      ? null
+      : variationValue.name
 
-      if (!hideImpossibleCombinations) {
-        // This is a impossible combination and will only appear if the prop allows.
-        return {
-          label: variationValue.name,
-          originalName: variationValue.originalName,
-          // eslint-disable-next-line @typescript-eslint/no-empty-function
-          onSelectItem: () => {},
-          image,
-          available: true,
-          impossible: true,
-          disabled: disableUnavailableSelectOptions,
-        }
+    const possibleItems = findListItemsWithSelectedVariations(
+      skuItems,
+      newSelectedVariation
+    )
+
+    if (possibleItems.length > 0) {
+      // This is a valid combination option
+      const [item] = possibleItems
+      const callbackFn = onSelectItemMemo({
+        name: variationName,
+        value: variationValue.name,
+        skuId: item.itemId,
+        isMainAndImpossible: false,
+        possibleItems,
+      })
+
+      return {
+        label: variationValue.name,
+        originalName: variationValue.originalName,
+        onSelectItem: callbackFn,
+        image,
+        available: showItemAsAvailable({
+          possibleItems,
+          selectedVariations,
+          variationCount,
+          isSelected,
+        }),
+        impossible: false,
+        disabled: disableUnavailableSelectOptions,
       }
+    }
 
-      // This is a impossible combination and will be hidden.
-      return null
+    if (!hideImpossibleCombinations) {
+      // This is a impossible combination and will only appear if the prop allows.
+      return {
+        label: variationValue.name,
+        originalName: variationValue.originalName,
+        // eslint-disable-next-line @typescript-eslint/no-empty-function
+        onSelectItem: () => {},
+        image,
+        available: true,
+        impossible: true,
+        disabled: disableUnavailableSelectOptions,
+      }
     }
 
+    // This is a impossible combination and will be hidden.
+    return null
+  }
+
 const variationNameToDisplayVariation =
   ({
     variations,
@@ -226,32 +226,33 @@ const variationNameToDisplayVariation =
     disableUnavailableSelectOptions: boolean
     sortVariationsByLabel: boolean
   }) =>
-    (variationName: string): DisplayVariation => {
-      const name = variationName
-      const { values, originalName } = variations[variationName]
-      const options = values
-        .map(
-          parseOptionNameToDisplayOption({
-            selectedVariations,
-            variationName,
-            skuItems,
-            onSelectItemMemo,
-            imagesMap,
-            variationCount,
-            hideImpossibleCombinations,
-            disableUnavailableSelectOptions,
-          })
-        )
-        .filter(Boolean) as DisplayOption[]
-
-      if (sortVariationsByLabel) {
-        options.sort((a,b) => {
-          return a.label < b.label ? -1 : a.label > b.label ? 1 : 0;
+  (variationName: string): DisplayVariation => {
+    const name = variationName
+    const { values, originalName } = variations[variationName]
+    const options = values
+      .map(
+        parseOptionNameToDisplayOption({
+          selectedVariations,
+          variationName,
+          skuItems,
+          onSelectItemMemo,
+          imagesMap,
+          variationCount,
+          hideImpossibleCombinations,
+          disableUnavailableSelectOptions,
         })
-      }
-      return { name, originalName, options }
+      )
+      .filter(Boolean) as DisplayOption[]
+
+    if (sortVariationsByLabel) {
+      options.sort((a, b) => {
+        return a.label < b.label ? -1 : a.label > b.label ? 1 : 0
+      })
     }
 
+    return { name, originalName, options }
+  }
+
 // Parameters are explained on PropTypes
 const getAvailableVariations = ({
   variations,
@@ -261,7 +262,7 @@ const getAvailableVariations = ({
   skuItems,
   hideImpossibleCombinations,
   disableUnavailableSelectOptions,
-  sortVariationsByLabel
+  sortVariationsByLabel,
 }: AvailableVariationParams): DisplayVariation[] => {
   const variationCount = Object.keys(variations).length
 
@@ -275,7 +276,7 @@ const getAvailableVariations = ({
       variationCount,
       hideImpossibleCombinations,
       disableUnavailableSelectOptions,
-      sortVariationsByLabel
+      sortVariationsByLabel,
     })
   )
 }
@@ -314,18 +315,18 @@ function SKUSelector({
   sliderDisplayThreshold,
   sliderArrowSize,
   sliderItemsPerPage,
-  sortVariationsByLabel = false
+  sortVariationsByLabel = false,
 }: Props) {
   const { handles } = useSKUSelectorCssHandles()
   const variationsSpacing = getValidMarginBottom(marginBottomProp)
   const onSelectItemMemo = useCallback(
     ({
-      name,
-      value,
-      skuId,
-      isMainAndImpossible,
-      possibleItems,
-    }: CallbackItem) =>
+        name,
+        value,
+        skuId,
+        isMainAndImpossible,
+        possibleItems,
+      }: CallbackItem) =>
       () =>
         onSelectItem({
           name,
@@ -346,7 +347,7 @@ function SKUSelector({
       skuItems,
       hideImpossibleCombinations,
       disableUnavailableSelectOptions,
-      sortVariationsByLabel
+      sortVariationsByLabel,
     }),
     [
       variations,
@@ -356,7 +357,7 @@ function SKUSelector({
       skuItems,
       hideImpossibleCombinations,
       disableUnavailableSelectOptions,
-      sortVariationsByLabel
+      sortVariationsByLabel,
     ]
   )