Skip to content

Commit cc9d8c2

Browse files
authored
Merge pull request #54 from vtex-apps/fix/remove-global-css
Fix/remove global css
2 parents baee542 + cbbe73e commit cc9d8c2

File tree

7 files changed

+13
-22
lines changed

7 files changed

+13
-22
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
66
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
77

88
## [Unreleased]
9+
### Changed
10+
- Inline loading icon animation, prevent from loading global CSS files for icons.
911

1012
## [0.17.0] - 2020-03-03
1113
### Added

docs/sti-loading.svg

Lines changed: 3 additions & 1 deletion
Loading

react/components/Icon.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ import { useCssHandles } from 'vtex.css-handles'
44
import Svg from './Svg'
55
import Use from './Use'
66

7-
import './icon.global.css'
8-
97
const CSS_HANDLES = [
108
'arrowBackIcon',
119
'assistantSalesIcon',

react/components/icon.global.css

Lines changed: 0 additions & 13 deletions
This file was deleted.

react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"tslint": "^5.11.0",
3131
"tslint-config-vtex": "^2.0.0",
3232
"tslint-eslint-rules": "^5.4.0",
33-
"typescript": "3.7.3"
33+
"typescript": "3.8.3"
3434
},
3535
"resolutions": {
3636
"babel-core": "^7.0.0-bridge.0"

react/yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4919,10 +4919,10 @@ type-check@~0.3.2:
49194919
dependencies:
49204920
prelude-ls "~1.1.2"
49214921

4922-
typescript@3.7.3:
4923-
version "3.7.3"
4924-
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.7.3.tgz#b36840668a16458a7025b9eabfad11b66ab85c69"
4925-
integrity sha512-Mcr/Qk7hXqFBXMN7p7Lusj1ktCBydylfQM/FZCk5glCNQJrCUKPkMHdo9R0MTFWsC/4kPFvDS0fDPvukfCkFsw==
4922+
typescript@3.8.3:
4923+
version "3.8.3"
4924+
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.8.3.tgz#409eb8544ea0335711205869ec458ab109ee1061"
4925+
integrity sha512-MYlEfn5VrLNsgudQTVJeNaQFUAI7DkhnOjdpAp4T+ku1TfQClewlbSuTVHiA+8skNBgaf02TL/kLOvig4y3G8w==
49264926

49274927
typescript@^3.3.3333:
49284928
version "3.5.3"

styles/iconpacks/iconpack.svg

Lines changed: 3 additions & 1 deletion
Loading

0 commit comments

Comments
 (0)