-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
bugSomething isn't workingSomething isn't workingdevIndicates that the issue or pull request involves engineering considerationsIndicates that the issue or pull request involves engineering considerations
Description
Problem
Trying to run pnpm dev:storybook with (at least) Node 23.7 or 23.8 results in an error because module is not defined. This seems to be related to the file using both CommonJS(module.exports , require) and ESM(import) features.
Expected behavior
No response
Reproducible Example
Download Node 23.8 and try to run pnpm dev:storybook
Suggested solution
Remove the ESM import at the top of the file and replace it the equivalent CommonJS syntax:
import { dirname, join } from 'node:path'
// turns into
const { dirname, join } = require('node:path')I have tested this locally and it does resolve the problem. Changing the file to only use ESM might be better, but i couldn't quite do it.
Additional context
No response
Package
@vtex/shoreline
Packages version
No response
Browser
Chrome
Package Manager
pnpm
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdevIndicates that the issue or pull request involves engineering considerationsIndicates that the issue or pull request involves engineering considerations
Type
Projects
Status
Active