Bump lint (#42)

Author: vtopc

.github/workflows/workflow.yaml

@@ -50,5 +50,5 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.52
+          version: v1.64.8
           skip-cache: true # cache/restore is done by actions/setup-go step

.golangci.yml

@@ -3,42 +3,41 @@ linters:
   # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
   disable-all: true
   enable:
+    - errcheck
+    - nilerr
+    - ineffassign
+    - staticcheck
+    - gosec
     - bodyclose
-    - depguard
+
     - dogsled
     - dupl
-    - errcheck
     - exhaustive
-    - exportloopref
     - funlen
     - gochecknoinits
     - gocognit
     - goconst
     - gocritic
     - gocyclo
-    - goerr113
-    - gofmt
     - goimports
     - goprintffuncname
-    - gosec
     - gosimple
     - govet
-    - ineffassign
     - lll
     - misspell
     - nakedret
-    #- noctx # TODO: enable
+    # - noctx # TODO: enable
     - nolintlint
     - nlreturn
     - prealloc
     - revive
     - rowserrcheck
-    - staticcheck
     - stylecheck
-    - typecheck
     - unconvert
     - unparam
     - unused
+    # - depguard # TODO: enable
+    # - err113 # TODO: enable
 
   # disabled:
   # - asciicheck
@@ -64,8 +63,6 @@ linters-settings:
   funlen:
     lines: 100
     statements: 50
-  gci:
-    local-prefixes: github.com/vtopc/go-monobank
   goconst:
     min-len: 2
     min-occurrences: 2
@@ -94,7 +91,7 @@ linters-settings:
         # don't include the "operation" and "assign"
         checks: argument,case,condition,return
   govet:
-    check-shadowing: true
+    shadow: true
     #settings:
     #  printf:
     #    funcs:
@@ -130,10 +127,3 @@ issues:
 #run:
 #  skip-dirs:
 #    - test/testdata_etc
-
-# golangci.com configuration
-# https://github.com/golangci/golangci/wiki/Configuration
-service:
-  golangci-lint-version: 1.35.x # use the fixed version to not introduce new linters unexpectedly
-  prepare:
-    - echo "here I can run custom commands, but no preparation needed for this repo"

Makefile

@@ -12,7 +12,7 @@ deps:
 # linter:
 GOLINT = $(GOPATH)/bin/golangci-lint
 $(GOLINT):
-	curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOPATH)/bin v1.52.0
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b $(GOPATH)/bin v1.64.8
 
 NILAWAY = $(GOPATH)/bin/nilaway
 $(NILAWAY):

auth_corp.go

@@ -104,16 +104,19 @@ func (a CorpAuth) SetAuth(r *http.Request) error {
 
 	var actor string
 	switch {
-	case len(a.requestID) > 0:
+	case a.requestID != "":
 		actor = a.requestID
 		r.Header.Set("X-Request-Id", actor)
-	case len(a.permissions) > 0:
+	case a.permissions != "":
 		actor = a.permissions
 		r.Header.Set("X-Permissions", actor)
 	}
 
 	timestamp := strconv.FormatInt(time.Now().Unix(), 10)
 
+	if r.URL == nil {
+		return errors.New("missing URL in request")
+	}
 	sign, err := a.sign(timestamp, actor, r.URL.Path)
 	if err != nil {
 		return fmt.Errorf("calculate Sign: %w", err)