stopped working going from dnd5e 4.3.6 to 4.3.7

[modzy2]

On update from dnd5e system 4.3.6 to 4.3.7, group initiative stopped working. No console errors, just now rolls for each individual monster.

[davidR1974]

looked up upon this issue (while trying to look if it can be made v13 compatible).

looks like that dnd5 system Combat class overrides now the rollAll and rollNPC functions in implementing
this

and it seems that override takes precedence over what GroupInitiative is registering for rollAll and RollNPC

Commenting the lines of codes in the dnd5e.mjs somewhat bypasses the problem but does not does not sound like a long term solution.

[vtt-lair]

Thanks, @davidR1974. I haven't had a chance to look at it myself yet, I'll see if I can get it working but not 100% sure (since I'm already using libWrapper to handle the override of the functions)

[davidR1974]

i guess their overrides overrides yours.

i managed to have a workaround without commenting code in dnd5e by adding :

Hooks.on('createCombat', async (combat) => {
	
	if (_gi_CONFIG_GROUPINITIATIVE) 
	{
		combat.rollAll = GroupInitiative.rollAll;
		combat.rollNPC = GroupInitiative.rollNPC;
	}
})

that seems to work (at least for dnd5), but that's basically bypasses libwrapper and forces another override of that function...

[davidR1974]

had some hints by the community that you could register the functions directly at Combat5e.prototype level that is in dnd5 namespace rather than doing it at Combat.prototype level ..

in that case, the replacement needed is to register the functions with libwrapper with those

            libWrapper.register(_gi_MODULE_NAME, "dnd5e.documents.Combat5e.prototype.rollAll", GroupInitiative.rollAll.bind(combat), "MIXED");
            libWrapper.register(_gi_MODULE_NAME, "dnd5e.documents.Combat5e.prototype.rollNPC", GroupInitiative.rollNPC.bind(combat), "MIXED");

and unregister with :

    libWrapper.unregister(_gi_MODULE_NAME, "dnd5e.documents.Combat5e.prototype.rollAll");
    libWrapper.unregister(_gi_MODULE_NAME, "dnd5e.documents.Combat5e.prototype.rollNPC");

i'm testing out locally and it seems to work for dnd5.

[vtt-lair]

Seems like I'll have to check if the system is DnD5e 4.x and handle it using the Combat5e and if not, handle it the other way.

Otherwise, the module will lose its system agnosticism.

Thanks for all your investigation @davidR1974!