Merge pull request hpcugent#339 from wdpypere/remove_popen

fix unclosed resource

Author: stdweird

lib/vsc/utils/generaloption.py

@@ -38,6 +38,7 @@
 import sys
 import textwrap
 import configparser
+import subprocess
 from functools import reduce
 from optparse import OptionParser, OptionGroup, Option, Values
 from optparse import BadOptionError, SUPPRESS_USAGE, OptionValueError
@@ -66,9 +67,8 @@ def set_columns(cols=None):
     if cols is None:
         if os.path.exists(STTY):
             try:
-                proc = os.popen('%s size 2>/dev/null' % STTY)
-                cols = int(proc.read().strip().split(' ')[1])
-                proc.close()
+                proc = subprocess.run(['/usr/bin/stty', 'size'], stdout=subprocess.PIPE)
+                cols = str(proc.stdout.splitlines()[0].decode('utf-8').split(' ')[1])
             except (AttributeError, IndexError, OSError, ValueError):
                 # do nothing
                 pass

setup.py

@@ -37,7 +37,7 @@
 from vsc.install.shared_setup import ag, kh, jt, sdw
 
 PACKAGE = {
-    'version': '3.5.1',
+    'version': '3.5.2',
     'author': [sdw, jt, ag, kh],
     'maintainer': [sdw, jt, ag, kh],
     'install_requires': [