Skip to content

Commit 1b3e8aa

Browse files
committed
Merge branch 'dev' into next
2 parents c4f12c3 + 265635b commit 1b3e8aa

File tree

8 files changed

+855
-836
lines changed

8 files changed

+855
-836
lines changed

dist/VueFinalModal.esm.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/VueFinalModal.esm.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/VueFinalModal.umd.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/VueFinalModal.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
},
1111
"dependencies": {
1212
"@nuxt/content-theme-docs": "^0.6.1",
13-
"nuxt": "^2.14.1",
13+
"nuxt": "^2.14.8",
1414
"vue-final-modal": "^0.20.1"
1515
},
1616
"devDependencies": {

docs/yarn.lock

Lines changed: 833 additions & 809 deletions
Large diffs are not rendered by default.

example/src/components/basic/BasicOptions.vue

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,20 @@
22
<div class="pb-8">
33
<v-modal
44
v-model="showModal"
5-
v-bind="props"
5+
:ssr="ssr"
6+
:lockScroll="lockScroll"
7+
:hideOverlay="hideOverlay"
8+
:clickToClose="clickToClose"
9+
:escToClose="escToClose"
10+
:preventClick="preventClick"
11+
:transition="transition ? 'vfm' : ''"
12+
:overlay-transition="overlayTransition ? 'vfm' : ''"
13+
:z-index-auto="zIndexAuto"
14+
:z-index-base="zIndexBase"
15+
:z-index="allowZIndex ? zIndexBase : false"
16+
:attach="attach ? '#attach' : false"
17+
:focus-retain="focusRetain"
18+
:focus-trap="focusTrap"
619
@confirm="showModal = false"
720
@cancel="showModal = false"
821
>
@@ -136,26 +149,6 @@ const initData = () => ({
136149
137150
export default {
138151
data: initData,
139-
computed: {
140-
props() {
141-
return {
142-
ssr: this.ssr,
143-
lockScroll: this.lockScroll,
144-
hideOverlay: this.hideOverlay,
145-
clickToClose: this.clickToClose,
146-
escToClose: this.escToClose,
147-
preventClick: this.preventClick,
148-
transition: this.transition ? 'vfm' : '',
149-
overlayTransition: this.overlayTransition ? 'vfm' : '',
150-
zIndexAuto: this.zIndexAuto,
151-
zIndexBase: this.zIndexBase,
152-
...(this.allowZIndex && { zIndex: this.zIndex }),
153-
attach: this.attach ? '#attach' : false,
154-
focusRetain: this.focusRetain,
155-
focusTrap: this.focusTrap
156-
}
157-
}
158-
},
159152
methods: {
160153
openAttach() {
161154
this.attach = '#attach'

lib/Plugin.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@ const Plugin = () => ({
1515
const isDuplicateComponent = app._context.components[_options.componentName]
1616

1717
if (isDuplicateComponent) {
18-
console.warn(isDuplicateKey ? DUPLICATE_PLUGIN_COMPONENT : DUPLICATE_COMPONENT)
18+
if (typeof window !== 'undefined') {
19+
console.warn(isDuplicateKey ? DUPLICATE_PLUGIN_COMPONENT : DUPLICATE_COMPONENT)
20+
}
1921
} else {
2022
if (!isDuplicateKey) {
2123
bindPrototype(app, _options)

0 commit comments

Comments
 (0)