Skip to content

Commit 27a3e33

Browse files
committed
refactor: refine defaultModal format
1 parent 31af11d commit 27a3e33

File tree

6 files changed

+11
-20
lines changed

6 files changed

+11
-20
lines changed

dist/VueFinalModal.esm.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/VueFinalModal.esm.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/VueFinalModal.umd.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/VueFinalModal.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/src/App.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,9 @@
2626
<h2 class="text-3xl py-2">Stop before open:</h2>
2727
<v-stop-before-open></v-stop-before-open>
2828
<h2 class="text-3xl py-2">Dynamic modal</h2>
29-
<v-dynamic-modal></v-dynamic-modal>
29+
<v-dynamic></v-dynamic>
3030

31+
<modals-container></modals-container>
3132
<div v-for="i in 100" :key="i">{{ i }}</div>
3233
</div>
3334
</template>

lib/PluginCore.js

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ function assignOptions(component, options) {
1111

1212
function createVfm(Vue, options) {
1313
let vfm
14-
const PREFIX = '_dynamic_modal_'
15-
const generateId = ((index = 0) => () => (index++).toString())()
1614

1715
return function() {
1816
vfm = {
@@ -24,23 +22,15 @@ function createVfm(Vue, options) {
2422
case 'object':
2523
{
2624
const defaultModal = {
25+
value: true,
26+
id: Symbol('dynamicModal'),
2727
component: options.componentName,
2828
bind: {},
2929
slots: {},
30-
on: {}
31-
}
32-
modal = Object.assign(defaultModal, modal)
33-
const id = generateId()
34-
this.dynamicModals.push({
35-
value: true,
36-
id,
37-
...modal,
38-
bind: {
39-
name: PREFIX + id,
40-
...modal.bind
41-
},
30+
on: {},
4231
params: args[0]
43-
})
32+
}
33+
this.dynamicModals.push(Object.assign(defaultModal, modal))
4434
}
4535
break
4636
}

0 commit comments

Comments
 (0)