Merge branch 'next' into feature/next-dynamic-modal

Author: hunterliu1003

.github/ISSUE_TEMPLATE/-question.md

@@ -8,5 +8,30 @@ assignees: hunterliu1003
 ---
 
 <!-- **IMPORTANT!**
-Please make sure to look for an answer to your question in our documentation and the documentation before asking a question here.
+Before reporting a bug, please make sure that you have read through our documentation and you think your problem is indeed an issue related to our module. -->
+
+### Version
+
+vue-final-modal: <!-- ex: v0.19.0 -->
+vue: <!-- ex: v2.6.12 -->
+nuxt: <!-- ex: v2.12.0 -->
+
+### OS
+
+Mac or Windows
+
+### Reproduction Link
+<!--
+A minimal test case based on one of:
+- a fork of https://codesandbox.io/s/nuxtcontent-demo-l164h
+- a GitHub repository that can reproduce the bug
 -->
+
+### Steps to reproduce
+
+
+### What is Expected?
+
+
+### What is actually happening?
+

dist/VueFinalModal.esm.js

@@ -41,12 +41,7 @@
         tabindex="-1"
         @click.self="onClickContainer"
       >
-        <div
-          ref="vfmContent"
-          class="vfm__content"
-          :class="[contentClass, { 'vfm--prevent-auto': preventClick }]"
-          :style="contentStyle"
-        >
+        <div class="vfm__content" :class="[contentClass, { 'vfm--prevent-auto': preventClick }]" :style="contentStyle">
           <slot :params="params" />
         </div>
       </div>
@@ -105,7 +100,6 @@ export default {
   setup(props, { emit }) {
     const uid = Symbol('vfm')
     const root = ref(null)
-    const vfmContent = ref(null)
     const vfmContainer = ref(null)
 
     const $vfm = inject(props.options.key)
@@ -195,7 +189,7 @@ export default {
     })
     onBeforeUnmount(() => {
       close()
-      props.lockScroll && enableBodyScroll(vfmContent)
+      props.lockScroll && enableBodyScroll(vfmContainer.value)
       root?.value?.remove()
 
       let index = $vfm.modals.findIndex(vm => vm.uid === uid)
@@ -207,7 +201,6 @@ export default {
         props,
         emit,
         vfmContainer,
-        vfmContent,
         getAttachElement,
         modalStackIndex,
         visibility,
@@ -278,11 +271,11 @@ export default {
     function handleLockScroll() {
       if (props.modelValue) {
         if (props.lockScroll) {
-          disableBodyScroll(vfmContent, {
+          disableBodyScroll(vfmContainer.value, {
             reserveScrollBarGap: true
           })
         } else {
-          enableBodyScroll(vfmContent)
+          enableBodyScroll(vfmContainer.value)
         }
       }
     }
@@ -347,7 +340,7 @@ export default {
     function afterModalLeave() {
       modalTransitionState.value = TransitionState.Leave
       modalStackIndex.value = null
-      props.lockScroll && enableBodyScroll(vfmContent)
+      props.lockScroll && enableBodyScroll(vfmContainer.value)
 
       let stopEvent = false
       const event = createModalEvent({
@@ -402,7 +395,6 @@ export default {
     }
     return {
       root,
-      vfmContent,
       vfmContainer,
       visible,
       visibility,

dist/VueFinalModal.esm.js.map

@@ -22,19 +22,47 @@ const isIosDevice =
 
 let locks = []
 let documentListenerAdded = false
+let clientY = 0
 let initialClientY = -1
 let previousBodyOverflowSetting
 let previousBodyPaddingRight
 
-// returns true if `el` should be allowed to receive touchmove events.
-const allowTouchMove = el =>
-  locks.some(lock => {
-    if (lock.options.allowTouchMove && lock.options.allowTouchMove(el)) {
-      return true
-    }
+const hasScrollbar = el => {
+  if (!el || el.nodeType !== Node.ELEMENT_NODE) return false
 
-    return false
+  const style = window.getComputedStyle(el)
+  return ['auto', 'scroll'].includes(style.overflowY) && el.scrollHeight > el.clientHeight
+}
+
+const shouldScroll = (el, delta) => {
+  if (el.scrollTop === 0 && delta < 0) return false
+  if (el.scrollTop + el.clientHeight + delta >= el.scrollHeight && delta > 0) return false
+  return true
+}
+
+const composedPath = el => {
+  const path = []
+  while (el) {
+    path.push(el)
+    if (el.classList.contains('vfm')) return path
+    el = el.parentElement
+  }
+  return path
+}
+
+const hasAnyScrollableEl = (el, delta) => {
+  let hasAnyScrollableEl = false
+  const path = composedPath(el)
+  path.forEach(el => {
+    if (hasScrollbar(el) && shouldScroll(el, delta)) {
+      hasAnyScrollableEl = true
+    }
   })
+  return hasAnyScrollableEl
+}
+
+// returns true if `el` should be allowed to receive touchmove events.
+const allowTouchMove = el => locks.some(() => hasAnyScrollableEl(el, -clientY))
 
 const preventDefault = rawEvent => {
   const e = rawEvent || window.event
@@ -95,7 +123,7 @@ const isTargetElementTotallyScrolled = targetElement =>
   targetElement ? targetElement.scrollHeight - targetElement.scrollTop <= targetElement.clientHeight : false
 
 const handleScroll = (event, targetElement) => {
-  const clientY = event.targetTouches[0].clientY - initialClientY
+  clientY = event.targetTouches[0].clientY - initialClientY
 
   if (allowTouchMove(event.target)) {
     return false
@@ -160,27 +188,6 @@ export const disableBodyScroll = (targetElement, options) => {
   }
 }
 
-export const clearAllBodyScrollLocks = () => {
-  if (isIosDevice) {
-    // Clear all locks ontouchstart/ontouchmove handlers, and the references.
-    locks.forEach(lock => {
-      lock.targetElement.ontouchstart = null
-      lock.targetElement.ontouchmove = null
-    })
-
-    if (documentListenerAdded) {
-      document.removeEventListener('touchmove', preventDefault, hasPassiveEvents ? { passive: false } : undefined)
-      documentListenerAdded = false
-    }
-    // Reset initial clientY.
-    initialClientY = -1
-  } else {
-    restoreOverflowSetting()
-  }
-
-  locks = []
-}
-
 export const enableBodyScroll = targetElement => {
   if (!targetElement) {
     // eslint-disable-next-line no-console

dist/VueFinalModal.umd.js

@@ -1,6 +1,6 @@
 {
   "name": "vue-final-modal",
-  "version": "1.8.5",
+  "version": "1.8.6",
   "description": "Vue Final Modal is a renderless, stackable, detachable and lightweight modal component.",
   "private": false,
   "main": "dist/VueFinalModal.umd.js",

dist/VueFinalModal.umd.js.map

@@ -20,7 +20,6 @@ interface VueFinalModalInfo {
   uid: symbol
   name: string
   emit: SetupContext<EmitsOptions>
-  vfmContent: Ref<HTMLDivElement>
   getAttachElement(): false | HTMLElement
   modalStackIndex: Ref<number | null>
   visibility: {
@@ -77,8 +76,7 @@ interface DynamicModalData extends DynamicModalOptions {
 }
 
 export interface VueFinalModalComponent extends ComponentPublicInstance {
-  vfmContainer: HTMLDivElement,
-  vfmContent: HTMLDivElement
+  vfmContainer: HTMLDivElement
 }