Skip to content

Commit 4549dcb

Browse files
Merge pull request #137 from vue-final/feat/dependencies
Update dependencies, add test case for globally register vue-final-modal plugin
2 parents 1484289 + 4f8e390 commit 4549dcb

File tree

11 files changed

+260
-313
lines changed

11 files changed

+260
-313
lines changed

dist/VueFinalModal.esm.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/VueFinalModal.esm.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/VueFinalModal.umd.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/VueFinalModal.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "vue-final-modal",
2+
"name": "vue-final-modal-docs",
33
"version": "0.0.0",
44
"private": true,
55
"scripts": {

example/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "vue-final-modal",
2+
"name": "vue-final-modal-example",
33
"version": "0.0.0",
44
"private": true,
55
"scripts": {

example/yarn.lock

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1794,9 +1794,8 @@ vite@^2.1.5:
17941794
fsevents "~2.3.1"
17951795

17961796
"vue-final-modal@link:..":
1797-
version "2.3.2"
1798-
dependencies:
1799-
vue "^2.6.12"
1797+
version "0.0.0"
1798+
uid ""
18001799

18011800
vue-template-compiler@^2.6.11:
18021801
version "2.6.12"
@@ -1811,7 +1810,7 @@ vue-template-es2015-compiler@^1.9.0, vue-template-es2015-compiler@^1.9.1:
18111810
resolved "https://registry.yarnpkg.com/vue-template-es2015-compiler/-/vue-template-es2015-compiler-1.9.1.tgz#1ee3bc9a16ecbf5118be334bb15f9c46f82f5825"
18121811
integrity sha512-4gDntzrifFnCEvyoO8PqyJDmguXgVPxKiIxrBKjIowvL9l+N66196+72XVYR8BBf1Uv1Fgt3bGevJ+sEmxfZzw==
18131812

1814-
vue@^2.6.11, vue@^2.6.12:
1813+
vue@^2.6.11:
18151814
version "2.6.12"
18161815
resolved "https://registry.yarnpkg.com/vue/-/vue-2.6.12.tgz#f5ebd4fa6bd2869403e29a896aed4904456c9123"
18171816
integrity sha512-uhmLFETqPPNyuLLbsKz6ioJ4q7AZHzD8ZVFNATNyICSZouqP2Sz0rotWQC8UNBF6VGSCs5abnKJoStA6JbCbfg==

package.json

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"@atomico/rollup-plugin-sizes": "^1.1.4",
2929
"@babel/core": "^7.11.6",
3030
"@babel/preset-env": "^7.11.5",
31-
"@rollup/plugin-babel": "^5.2.2",
31+
"@rollup/plugin-babel": "^5.3.0",
3232
"@rollup/plugin-commonjs": "^19.0.0",
3333
"@rollup/plugin-node-resolve": "^13.0.0",
3434
"@vue/eslint-config-prettier": "^6.0.0",
@@ -43,12 +43,13 @@
4343
"eslint-plugin-vue": "^7.8.0",
4444
"jest": "^24.9.0",
4545
"lint-staged": "^10.5.4",
46-
"rollup": "^2.51.0",
46+
"rollup": "^2.52.3",
4747
"rollup-plugin-cleanup": "^3.2.1",
4848
"rollup-plugin-terser": "^7.0.2",
4949
"rollup-plugin-vue": "^5.1.9",
50+
"vue": "^2.6.14",
5051
"vue-jest": "^3.0.5",
51-
"vue-template-compiler": "^2.6.11",
52+
"vue-template-compiler": "^2.6.14",
5253
"yorkie": "^2.0.0"
5354
},
5455
"gitHooks": {
@@ -84,7 +85,7 @@
8485
"tags": "vetur/tags.json",
8586
"attributes": "vetur/attributes.json"
8687
},
87-
"dependencies": {
88-
"vue": "^2.6.12"
88+
"peerDependencies": {
89+
"vue": "^2.6.14"
8990
}
9091
}

rollup.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export default {
3636
format: 'umd',
3737
name: 'VueFinalModal',
3838
sourcemap: true,
39+
exports: 'named',
3940
globals: {
4041
vue: 'Vue'
4142
}

tests/unit/Plugin.spec.js

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,29 @@
11
import { createLocalVue, enableAutoDestroy } from '@vue/test-utils'
2-
import { vfmPlugin } from '../../lib'
2+
import VueFinalModal, { vfmPlugin } from '../../lib'
33

44
enableAutoDestroy(afterEach)
55

66
describe('Plugin', () => {
7+
it('globally register vue-final-modal', () => {
8+
const localVue = createLocalVue()
9+
localVue.use(VueFinalModal())
10+
expect(localVue.options.components).toHaveProperty('VueFinalModal')
11+
expect(localVue.options.components).toHaveProperty('ModalsContainer')
12+
expect(localVue.prototype).toHaveProperty('$vfm')
13+
})
14+
it('globally register vue-final-modal by customized options', () => {
15+
const localVue = createLocalVue()
16+
localVue.use(
17+
VueFinalModal({
18+
key: '_$vfm',
19+
componentName: 'MyModal',
20+
dynamicContainerName: 'MyModalsContainer'
21+
})
22+
)
23+
expect(localVue.options.components).toHaveProperty('MyModal')
24+
expect(localVue.options.components).toHaveProperty('MyModalsContainer')
25+
expect(localVue.prototype).toHaveProperty('_$vfm')
26+
})
727
it('window is undefined in node server', () => {
828
Object.defineProperty(global, 'window', { value: undefined })
929
global.console.error = jest.fn()

0 commit comments

Comments
 (0)