Skip to content

Commit 9562ebe

Browse files
committed
refactor: delete CoreModal, this will also fixed #362
1 parent 543f5d2 commit 9562ebe

File tree

16 files changed

+588
-616
lines changed

16 files changed

+588
-616
lines changed

docs/content/2.get-started/1.guide/2.setup.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export default defineNuxtPlugin((nuxtApp) => {
6060

6161
## Import required CSS
6262

63-
vue-final-modal 4 has tiny size of required CSS (gzipped 0.49kb). All classes have a `.vfm-` prefix, so you don't have to worry about any CSS pollution. _[See style of `<VueFinalModal>`.](https://github.com/vue-final/vue-final-modal/blob/v4/packages/vue-final-modal/src/components/CoreModal/CoreModal.vue#L184-L217)_
63+
vue-final-modal 4 has tiny size of required CSS (gzipped 0.49kb). All classes have a `.vfm-` prefix, so you don't have to worry about any CSS pollution.
6464

6565
### Vue 3
6666

packages/vue-final-modal/cypress/components/useZIndex.spec.ts

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,24 +25,22 @@ describe('Test useZIndex()', () => {
2525
stubs: { transition: false },
2626
},
2727
}).as('app')
28-
cy.get('@app').then(() => {
29-
firstModal.open()
30-
})
28+
29+
cy.get('@app').then(() => firstModal.open())
3130
cy.get('.first-modal').should(($el) => {
3231
expect($el).to.have.css('zIndex', '1000')
3332
})
34-
cy.get('@app').then(() => {
35-
secondModal.open()
36-
})
33+
34+
cy.get('@app').then(() => secondModal.open())
3735
cy.get('.second-modal').should(($el) => {
3836
expect($el).to.have.css('zIndex', '1002')
3937
})
40-
cy.get('@app').then(() => {
41-
thirdModal.open()
42-
})
38+
39+
cy.get('@app').then(() => thirdModal.open())
4340
cy.get('.third-modal').should(($el) => {
4441
expect($el).to.have.css('zIndex', '1004')
4542
})
43+
4644
cy.get('@app').then(() => {
4745
thirdModal.patchOptions({
4846
attrs: {
@@ -53,9 +51,8 @@ describe('Test useZIndex()', () => {
5351
cy.get('.third-modal').should(($el) => {
5452
expect($el).to.have.css('zIndex', '1238')
5553
})
56-
cy.get('@app').then(() => {
57-
firstModal.close()
58-
})
54+
55+
cy.get('@app').then(() => firstModal.close())
5956
cy.get('.second-modal').should(($el) => {
6057
expect($el).to.have.css('zIndex', '1000')
6158
})

packages/vue-final-modal/src/components/CoreModal/CoreModal.vue

Lines changed: 0 additions & 335 deletions
This file was deleted.

0 commit comments

Comments
 (0)