Skip to content

Commit c95e715

Browse files
Merge pull request #63 from fatihsolhan/refactorKeydown
refactor: keydown event is refactored for more generic use
2 parents 94a8c81 + 520d213 commit c95e715

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

dist/VueFinalModal.esm.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/VueFinalModal.esm.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/VueFinalModal.umd.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/VueFinalModal.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/VueFinalModal.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
:style="bindStyle"
66
class="vfm vfm--inset"
77
:class="[attach === false ? 'vfm--fixed' : 'vfm--absolute', { 'vfm--prevent-none': preventClick }]"
8-
@keydown="onEsc"
8+
@keydown.esc="onEsc"
99
>
1010
<transition
1111
ref="vfmOverlayTransition"
@@ -333,8 +333,8 @@ export default {
333333
this.$emit('click-outside', this.createModalEvent({ type: 'click-outside' }))
334334
this.clickToClose && this.$emit('input', false)
335335
},
336-
onEsc(evt) {
337-
if (evt.keyCode === 27 && this.visible && this.escToClose) {
336+
onEsc() {
337+
if (this.visible && this.escToClose) {
338338
this.$emit('input', false)
339339
}
340340
},

tests/unit/VueFinalModal.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ describe('VueFinalModal.vue', () => {
119119
done()
120120
})
121121
})
122-
it('escToClose: false', async done => {
122+
it('escToClose: true', async done => {
123123
const { wrapper } = await createOpenedModal({
124124
escToClose: true
125125
})

0 commit comments

Comments
 (0)