Skip to content

Commit 2dbc0e9

Browse files
Seungwoo321claude
andcommitted
fix: resolve ESLint configuration and code issues
- ESLint 9.27.0 플랫 설정 수정 - 중복 import 제거 - RendererDefinition 중복 선언 수정 - 사용하지 않는 변수 제거 - pivotModel prop 기본값 추가 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 5759978 commit 2dbc0e9

File tree

7 files changed

+24
-29
lines changed

7 files changed

+24
-29
lines changed

eslint.config.js

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import { defineConfig } from 'eslint/config'
21
import standardjs from '@seungwoo321/eslint-plugin-standard-js'
32
import tseslint from 'typescript-eslint'
43
import pluginVue from 'eslint-plugin-vue'
4+
import vueParser from 'vue-eslint-parser'
55

6-
export default defineConfig([
6+
export default [
77
{
88
ignores: [
99
'packages/plotly-renderer/**',
@@ -14,29 +14,22 @@ export default defineConfig([
1414
'**/dist/**'
1515
]
1616
},
17+
...standardjs.configs.base,
18+
...tseslint.configs.recommended,
19+
...pluginVue.configs['flat/strongly-recommended'],
1720
{
1821
files: ['**/*.vue'],
1922
languageOptions: {
20-
parser: 'vue-eslint-parser',
23+
parser: vueParser,
2124
parserOptions: {
2225
parser: '@typescript-eslint/parser',
2326
ecmaVersion: 2020,
2427
sourceType: 'module',
2528
extraFileExtensions: ['.vue']
2629
}
27-
},
28-
plugins: {
29-
'vue': pluginVue,
30-
'@typescript-eslint': tseslint
3130
}
3231
},
3332
{
34-
files: ['**/*.{js,mjs,cjs,vue,ts}', 'eslint.config.js'],
35-
extends: [
36-
...standardjs.configs.base,
37-
...tseslint.configs.recommended,
38-
...pluginVue.configs['flat/strongly-recommended']
39-
],
4033
rules: {
4134
'vue/html-self-closing': [
4235
'error',
@@ -59,7 +52,8 @@ export default defineConfig([
5952
externalIgnores: []
6053
}
6154
],
62-
'@typescript-eslint/no-explicit-any': 'off'
55+
'@typescript-eslint/no-explicit-any': 'off',
56+
'@typescript-eslint/no-require-imports': 'off'
6357
}
6458
}
65-
])
59+
]

scripts/release-packages.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
const { execSync } = require('child_process');
44
const fs = require('fs');
5-
const path = require('path');
65

76
// Color codes for output
87
const colors = {

src/components/pivottable-ui/VDraggableAttribute.vue

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
<slot
88
name="pvtAttr"
99
:attr-name="attributeName"
10-
>{{ attributeName }}</slot
11-
>
10+
>{{ attributeName }}</slot>
1211
<span
1312
v-if="!hideDropDown"
1413
@mousedown.stop

src/components/pivottable-ui/VPivottableUi.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@
132132
</template>
133133

134134
<script setup lang="ts">
135-
import { aggregators, PivotData, sortAs } from '@/helper'
135+
import { aggregators, PivotData, sortAs , locales } from '@/helper'
136136
import VRendererCell from './VRendererCell.vue'
137137
import VAggregatorCell from './VAggregatorCell.vue'
138138
import VDragAndDropCell from './VDragAndDropCell.vue'
@@ -145,7 +145,6 @@ import {
145145
provideFilterBox
146146
} from '@/composables'
147147
import { DefaultPropsType } from '@/types'
148-
import { locales } from '@/helper'
149148
150149
const props = withDefaults(
151150
defineProps<
@@ -163,6 +162,7 @@ const props = withDefaults(
163162
aggregators: () => aggregators,
164163
hiddenAttributes: () => [],
165164
hiddenFromAggregators: () => [],
165+
pivotModel: () => ({}),
166166
hiddenFromDragDrop: () => [],
167167
restrictedFromDragDrop: () => [],
168168
menuLimit: 500,

src/composables/usePropsState.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export function usePropsState<T extends UsePropsStateProps> (
2626
}) as UnwrapRef<T>
2727

2828
const localeStrings = computed(
29-
() => initialProps?.languagePack?.[initialProps?.locale || 'en'].localeStrings ?? locales['en'].localeStrings
29+
() => initialProps?.languagePack?.[initialProps?.locale || 'en'].localeStrings ?? locales.en.localeStrings
3030
)
3131

3232
const updateState = (key: keyof T, value: any) => {

src/composables/useProvideFilterbox.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { computed, ComputedRef, inject, provide, InjectionKey } from 'vue'
2-
import { getSort } from '@/helper'
2+
import { getSort , Locale } from '@/helper'
33
import { DefaultPropsType } from '@/types'
4-
import { Locale } from '@/helper'
54

65
type ProvideFilterBoxProps = Pick<DefaultPropsType, 'sorters'> & {
76
menuLimit: number

src/types/index.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,16 @@ import type { AggregatorTemplate } from '@/helper'
22
import { VNode } from 'vue'
33
import { Locale } from '@/helper'
44

5+
export type RecordFunctionType = () => object
6+
7+
export interface RendererDefinition {
8+
name: string
9+
renderer?: any
10+
value?: string | RecordFunctionType
11+
props?: Record<string, any>
12+
setup?: (props: any) => () => VNode
13+
}
14+
515
export interface DefaultPropsType {
616
data: any
717
aggregators?: Record<string, AggregatorTemplate>
@@ -28,9 +38,3 @@ export interface DefaultPropsType {
2838
}
2939

3040
export type RendererProps = DefaultPropsType & Record<string, unknown>
31-
32-
export interface RendererDefinition {
33-
name: string
34-
props?: Record<string, any>
35-
setup: (props: any) => () => VNode
36-
}

0 commit comments

Comments
 (0)