Skip to content

Commit da788ef

Browse files
authored
Merge pull request #202 from vue-pivottable/fix/github-release-version-tag
fix: GitHub Release 태그 버전 형식 수정
2 parents 5fe0385 + a0305d4 commit da788ef

File tree

3 files changed

+40
-11
lines changed

3 files changed

+40
-11
lines changed

.changeset/test-workflow-fix.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@vue-pivottable/lazy-table-renderer": patch
3+
---
4+
5+
test: 워크플로우 수정 테스트

.github/workflows/release-develop.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,9 @@ jobs:
100100
Changed packages: $CHANGED_PACKAGES"
101101
git push origin develop
102102
103-
# Use main package version for output (if changed) or first changed package
104-
if [ "$ORIGINAL_MAIN" != "$NEW_MAIN" ]; then
105-
echo "version=${NEW_MAIN}-beta.${TIMESTAMP}" >> $GITHUB_OUTPUT
106-
else
107-
echo "version=beta.${TIMESTAMP}" >> $GITHUB_OUTPUT
108-
fi
103+
# Always use current main package version for GitHub release tag
104+
CURRENT_VERSION=$(node -p "require('./package.json').version")
105+
echo "version=${CURRENT_VERSION}" >> $GITHUB_OUTPUT
109106
110107
- name: Run quality checks
111108
if: steps.changesets-check.outputs.has_changesets == 'true'

.github/workflows/release.yml

Lines changed: 32 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,43 @@ jobs:
5454
- name: Check beta versions
5555
id: check-versions
5656
run: |
57-
# Check if packages have beta versions
57+
# Check if any package has beta version
58+
HAS_BETA=false
59+
BETA_PACKAGES=""
60+
61+
# Check main package
5862
MAIN_VERSION=$(node -p "require('./package.json').version")
5963
if [[ $MAIN_VERSION == *"-beta"* ]]; then
60-
echo "has_beta=true" >> $GITHUB_OUTPUT
61-
# Extract base version without beta suffix
64+
HAS_BETA=true
65+
BETA_PACKAGES="vue-pivottable"
66+
# Extract base version without beta suffix for release branch
67+
BASE_VERSION=$(echo $MAIN_VERSION | sed 's/-beta.*//')
68+
echo "base_version=$BASE_VERSION" >> $GITHUB_OUTPUT
69+
fi
70+
71+
# Check sub-packages
72+
for pkg in packages/*/; do
73+
if [ -d "$pkg" ] && [ -f "$pkg/package.json" ]; then
74+
PKG_NAME=$(basename "$pkg")
75+
PKG_VERSION=$(cd "$pkg" && node -p "require('./package.json').version")
76+
if [[ $PKG_VERSION == *"-beta"* ]]; then
77+
HAS_BETA=true
78+
BETA_PACKAGES="$BETA_PACKAGES $PKG_NAME"
79+
fi
80+
fi
81+
done
82+
83+
echo "has_beta=$HAS_BETA" >> $GITHUB_OUTPUT
84+
echo "beta_packages=$BETA_PACKAGES" >> $GITHUB_OUTPUT
85+
86+
# Use main package version for release branch, or highest version
87+
if [ -z "${BASE_VERSION}" ]; then
88+
# If main package is not beta, use its version for release branch
6289
BASE_VERSION=$(echo $MAIN_VERSION | sed 's/-beta.*//')
6390
echo "base_version=$BASE_VERSION" >> $GITHUB_OUTPUT
64-
else
65-
echo "has_beta=false" >> $GITHUB_OUTPUT
6691
fi
92+
93+
echo "Found beta packages: $BETA_PACKAGES"
6794
6895
- name: Update versions to stable
6996
if: steps.check-versions.outputs.has_beta == 'true'

0 commit comments

Comments
 (0)