Skip to content

Commit 49852f5

Browse files
authored
Merge pull request #322 from vuejs-jp/reduce-use-of-arbitary-value
arbitrary values が多用されていたので使用箇所を減らした
2 parents 3b9616d + b9fda05 commit 49852f5

20 files changed

+49
-26
lines changed

app/components/EventsPageSection.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
class="py-10 px-5 bg-events md:px-10 lg:p-20"
1616
>
1717
<div class="py-20 bg-white lg:py-40">
18-
<div class="px-5 mx-auto max-w-[940px]">
18+
<div class="px-5 mx-auto max-w-940">
1919
<SectionTitle
2020
class="mb-10 lg:mb-20"
2121
title="Events"

app/components/FooterPageSection.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
class="py-10 text-white bg-vue-blue lg:py-20"
55
>
66
<img
7-
class="mx-auto mb-10 w-[9.375rem] lg:mb-20 lg:w-[15rem]"
7+
class="mx-auto mb-10 w-37.5 lg:mb-20 lg:w-60"
88
:src="`/icon/vuefes_logo-invert.svg`"
99
alt="Vue fes 2022"
1010
>

app/components/FormPageSection.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export default {
2727
id="form"
2828
class="py-20 lg:py-40"
2929
>
30-
<div class="px-5 mx-auto max-w-[43.75rem]">
30+
<div class="px-5 mx-auto max-w-700">
3131
<SectionTitle
3232
class="mb-10 lg:mb-20"
3333
title="Contact"

app/components/MessagePageSection.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ import SectionTitle from '~/components/SectionTitle.vue'
1717
class="py-20 bg-white lg:py-40"
1818
>
1919
<div
20-
class="px-5 mx-auto max-w-[43.75rem] lg:flex lg:justify-between lg:items-center lg:max-w-[74.375rem]"
20+
class="px-5 mx-auto max-w-700 lg:flex lg:justify-between lg:items-center lg:max-w-1190"
2121
>
2222
<SectionTitle
2323
class="mb-10 lg:mr-6 lg:mb-20"
2424
title="Message"
2525
title-yamato="想い"
2626
/>
27-
<div class="text-sm leading-7 text-vue-blue lg:max-w-[45rem] lg:text-lg lg:leading-8">
27+
<div class="text-sm leading-7 text-vue-blue lg:max-w-720 lg:text-lg lg:leading-8">
2828
<p class="mb-6">{{ message1 }}</p>
2929
<p class="mb-6">{{ message2 }}</p>
3030
<p class="mb-6">{{ message3 }}</p>

app/components/NavPageSection.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<div class="flex">
55
<nuxt-link to="/">
66
<img
7-
class="mr-[2.6vw] w-[19.48vw] h-[3.51vw] lg:mr-5 lg:w-[200px] lg:h-9"
7+
class="mr-[2.6vw] w-[19.48vw] h-[3.51vw] lg:mr-5 lg:w-50 lg:h-9"
88
:src="`/icon/vuefes_logo.svg`"
99
:alt="conferenceTitle"
1010
>

app/components/SectionTitle.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ const props = defineProps({
1313

1414
<template>
1515
<div class="shrink-0 text-center text-vue-blue">
16-
<div class="font-kokuryu-heading text-[2.5rem] opacity-10 lg:text-[5rem]">
16+
<div class="font-kokuryu-heading text-40 opacity-10 lg:text-80">
1717
{{ titleYamato }}
1818
</div>
19-
<h2 class="mt-[-1.5rem] text-[1.25rem] font-extrabold lg:-mt-14 lg:text-[2.5rem]">
19+
<h2 class="-mt-6 text-xl font-extrabold lg:-mt-14 lg:text-40">
2020
{{ title }}
2121
</h2>
2222
</div>

app/components/StorePageSection.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ import {
4444
<p class="mb-10 text-2xl font-bold text-center text-vue-blue">
4545
{{ goods.price }}
4646
</p>
47-
<p class="mb-5 text-sm text-vue-blue md:min-h-[80px]">
47+
<p class="mb-5 text-sm text-vue-blue md:min-h-20">
4848
{{ goods.description }}
4949
</p>
5050
<p

app/components/TeamPageSection.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const showStaffs = computed(() => staffList.filter((staff) => staff.image !== ''
1515
class="py-10 px-5 bg-staffs md:px-10 lg:p-20"
1616
>
1717
<div class="py-20 px-5 bg-white lg:py-40">
18-
<div class="mx-auto max-w-[43.75rem] lg:max-w-[73.75rem]">
18+
<div class="mx-auto max-w-700 lg:max-w-1180">
1919
<SectionTitle
2020
class="mb-10 lg:mb-20"
2121
title="Team"

app/components/TopPageSection.vue

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
11
<template>
22
<section class="pb-7">
3-
<div class="relative mx-auto max-w-[1920px]">
3+
<div class="relative mx-auto max-w-1920">
44
<div class="px-5">
55
<div
6-
class="aspect-[648/384] mx-auto mb-[6.23vw] max-w-[1176px] md:aspect-[780/384] lg:aspect-[1176/384] lg:mb-9"
6+
class="aspect-[648/384] mx-auto mb-[6.23vw] max-w-1176 md:aspect-[780/384] lg:aspect-[1176/384] lg:mb-9"
77
>
88
<top-animation />
99
</div>
1010
<div class="flex flex-wrap gap-x-8 gap-y-2.5 justify-center items-baseline mb-8 md:mb-16">
1111
<h1
12-
class="text-[7.01vw] font-extrabold leading-none text-center text-vue-blue lg:text-[4.0625rem]"
12+
class="text-[7.01vw] font-extrabold leading-none text-center text-vue-blue lg:text-65"
1313
>
1414
{{ conferenceTitle }}
1515
</h1>
1616
<p
17-
class="text-[3.9vw] text-center text-vue-blue lg:text-[2.5rem]"
17+
class="text-[3.9vw] text-center text-vue-blue lg:text-40"
1818
>
1919
{{ eventDate }}
2020
</p>
2121
</div>
2222
<p
2323
v-if="LIVE_YOUTUBE"
24-
class="text-[5.7vw] font-bold text-center text-vue-blue md:text-[2.5rem]"
24+
class="text-[5.7vw] font-bold text-center text-vue-blue md:text-40"
2525
>
2626
{{ streamingNow }}
2727
</p>
@@ -35,7 +35,7 @@
3535
class="hover:opacity-80 transition-opacity"
3636
>
3737
<div
38-
class="flex flex-col justify-center w-[67vw] max-w-[30rem] h-16 font-bold rounded-full shadow-card md:w-[30rem] md:h-[6.75rem] lg:w-[30rem] lg:h-[6.75rem]"
38+
class="flex flex-col justify-center w-[67vw] max-w-480 h-16 font-bold rounded-full shadow-card md:w-120 md:h-27 lg:w-120 lg:h-27"
3939
:class="track.bgClass"
4040
>
4141
<p class="text-base font-bold text-center text-white md:text-2xl lg:text-2xl">{{ track.name }}</p>

app/components/events/ChildcareDetail.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111

1212
<template>
1313
<div>
14-
<div class="relative z-10 mx-auto w-[12.5rem] bg-white lg:w-[21.25rem]">
14+
<div class="relative z-10 mx-auto w-50 bg-white lg:w-85">
1515
<h3 class="text-xl font-bold text-center text-vue-blue lg:text-4xl">
1616
託児サポート
1717
</h3>

0 commit comments

Comments
 (0)