Skip to content

Commit 5c2e8d6

Browse files
committed
- remove aria-label from dialog element.
- update transition property.
1 parent 9324547 commit 5c2e8d6

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

apps/web/app/components/GlobalHeader.vue

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,7 @@ const getAnchorPath = computed(
6464
<!-- <VFIcon name="menu" color="vue-blue" can-hover @click="toggleMenu" /> -->
6565
</div>
6666
<!-- hamburger-menu -->
67-
<dialog
68-
id="navigation-mobile-menu-trigger"
69-
ref="dialogRef"
70-
aria-label="ハンバーガーメニュー"
71-
class="navigation-mobile-menu"
72-
>
67+
<dialog id="navigation-mobile-menu-trigger" ref="dialogRef" class="navigation-mobile-menu">
7368
<ul>
7469
<li v-for="(link, index) in navLinks" :key="link.anchor">
7570
<!-- eslint-disable vuejs-accessibility/no-autofocus -->
@@ -126,7 +121,6 @@ const getAnchorPath = computed(
126121
transition:
127122
translate 0.6s cubic-bezier(0.4, 0, 0.2, 1),
128123
display 0.6s cubic-bezier(0.4, 0, 0.2, 1) allow-discrete;
129-
translate: 0 -100dvh;
130124
z-index: 1;
131125
132126
&[open] {
@@ -137,6 +131,10 @@ const getAnchorPath = computed(
137131
}
138132
}
139133
134+
&:not([open]) {
135+
translate: 0 -100dvh;
136+
}
137+
140138
ul {
141139
padding: 0;
142140
display: flex;

0 commit comments

Comments
 (0)