chore: add tslint (#37)

* chore: tslint

* chore: workflow lint

Co-authored-by: Amour1688 <[email protected]>

Author: xrkffgg

.eslintrc.js

@@ -12,14 +12,31 @@ module.exports = {
     jest: true,
     es6: true,
   },
-  extends: 'eslint-config-airbnb-base',
+  parser: '@typescript-eslint/parser',
+  plugins: ['@typescript-eslint', 'import'],
+  extends: [
+    'eslint-config-airbnb-base',
+    'plugin:@typescript-eslint/recommended'
+  ],
   rules: {
     'no-nested-ternary': [0],
     'no-param-reassign': [0],
     'no-use-before-define': [0],
     'no-plusplus': [0],
     'import/no-extraneous-dependencies': [0],
     'consistent-return': [0],
-    'no-bitwise': [0]
+    'no-bitwise': [0],
+    'prefer-destructuring': [2, { 'array': false }],
+    'import/extensions': [2, 'ignorePackages', { ts: 'never' }],
+    '@typescript-eslint/ban-ts-comment': [0],
+    '@typescript-eslint/explicit-module-boundary-types': [0],
+    '@typescript-eslint/no-explicit-any': [0]
   },
+  settings: {
+    'import/resolver': {
+      node: {
+        extensions: ['.js', '.jsx', '.ts', '.tsx']
+      }
+    }
+  }
 };

.github/workflows/test.yml

@@ -10,7 +10,10 @@ jobs:
         uses: actions/checkout@v2
 
       - name: install
-        run: yarn install --pure-lockfile
-      
+        run: yarn install
+
+      - name: lint
+        run: yarn lint
+
       - name: test
         run: yarn test

package.json

@@ -6,6 +6,7 @@
   "scripts": {
     "publish": "lerna publish",
     "test": "lerna run test",
+    "lint": "lerna run lint",
     "dev": "node scripts/dev.js",
     "site": "node scripts/site.js"
   },

packages/babel-plugin-jsx/package.json

@@ -13,7 +13,7 @@
   "scripts": {
     "dev": "npm run build && webpack-dev-server",
     "build": "tsc",
-    "lint": "eslint --ext .js src",
+    "lint": "eslint 'src/*.ts'",
     "test": "npm run build && jest --coverage"
   },
   "bugs": {
@@ -27,6 +27,7 @@
     "@ant-design-vue/babel-helper-vue-transform-on": "^1.0.0",
     "@babel/helper-module-imports": "^7.0.0",
     "@babel/plugin-syntax-jsx": "^7.0.0",
+    "@babel/traverse": "^7.0.0",
     "@babel/types": "^7.0.0",
     "camelcase": "^6.0.0",
     "html-tags": "^3.1.0",
@@ -37,6 +38,8 @@
     "@babel/preset-env": "^7.0.0",
     "@rollup/plugin-babel": "^5.0.3",
     "@types/svg-tags": "^1.0.0",
+    "@typescript-eslint/eslint-plugin": "^3.6.1",
+    "@typescript-eslint/parser": "^3.6.1",
     "@vue/compiler-dom": "3.0.0-rc.1",
     "@vue/test-utils": "2.0.0-beta.0",
     "babel-jest": "^26.0.1",

packages/babel-plugin-jsx/src/parseDirectives.ts

@@ -1,7 +1,9 @@
 import * as t from '@babel/types';
 import { NodePath } from '@babel/traverse';
 import { createIdentifier } from './utils';
-import { State, ExcludesBoolean } from './';
+import { State, ExcludesBoolean } from '.';
+
+type Tag = t.Identifier | t.MemberExpression | t.StringLiteral | t.CallExpression;
 
 /**
  * Get JSX element type
@@ -17,32 +19,31 @@ const getType = (path: NodePath<t.JSXOpeningElement>) => {
       }
       return t.isJSXIdentifier(attribute.get('name'))
         && (attribute.get('name') as NodePath<t.JSXIdentifier>).get('name') === 'type'
-        && t.isStringLiteral(attribute.get('value'))
-      },
-    );
+        && t.isStringLiteral(attribute.get('value'));
+    });
 
   return typePath ? typePath.get('value.value') : '';
 };
 
 const parseModifiers = (value: t.Expression) => {
   let modifiers: string[] = [];
   if (t.isArrayExpression(value)) {
-    modifiers = (value as t.ArrayExpression).elements.map(el => t.isStringLiteral(el) ? el.value : '').filter(Boolean)
+    modifiers = (value as t.ArrayExpression).elements.map((el) => (t.isStringLiteral(el) ? el.value : '')).filter(Boolean);
   }
   return modifiers;
-}
+};
 
 const parseDirectives = (args: {
   name: string,
   path: NodePath<t.JSXAttribute>,
   value: t.StringLiteral | t.Expression | null,
   state: State,
-  tag: t.Identifier | t.MemberExpression | t.StringLiteral | t.CallExpression,
+  tag: Tag,
   isComponent: boolean
 }) => {
   const {
     name, path, value, state, tag, isComponent,
-  } = args
+  } = args;
   let modifiers: string[] = name.split('_');
   let arg;
   let val;
@@ -93,14 +94,19 @@ const parseDirectives = (args: {
   };
 };
 
-const resolveDirective = (path: NodePath<t.JSXAttribute>, state: State, tag: any, directiveName: string) => {
+const resolveDirective = (
+  path: NodePath<t.JSXAttribute>,
+  state: State,
+  tag: Tag,
+  directiveName: string,
+) => {
   if (directiveName === 'show') {
     return createIdentifier(state, 'vShow');
   }
   if (directiveName === 'model') {
     let modelToUse;
     const type = getType(path.parentPath as NodePath<t.JSXOpeningElement>);
-    switch (tag.value) {
+    switch ((tag as t.StringLiteral).value) {
       case 'select':
         modelToUse = createIdentifier(state, 'vModelSelect');
         break;

packages/babel-plugin-jsx/src/patchFlags.ts

@@ -1,4 +1,5 @@
 // https://github.com/vuejs/vue-next/blob/master/packages/shared/src/patchFlags.ts
+// tslint:disable: no-bitwise
 export const enum PatchFlags {
   TEXT = 1,
   CLASS = 1 << 1,
@@ -17,17 +18,17 @@ export const enum PatchFlags {
 
 // dev only flag -> name mapping
 export const PatchFlagNames = {
-  [PatchFlags.TEXT]: `TEXT`,
-  [PatchFlags.CLASS]: `CLASS`,
-  [PatchFlags.STYLE]: `STYLE`,
-  [PatchFlags.PROPS]: `PROPS`,
-  [PatchFlags.FULL_PROPS]: `FULL_PROPS`,
-  [PatchFlags.HYDRATE_EVENTS]: `HYDRATE_EVENTS`,
-  [PatchFlags.STABLE_FRAGMENT]: `STABLE_FRAGMENT`,
-  [PatchFlags.KEYED_FRAGMENT]: `KEYED_FRAGMENT`,
-  [PatchFlags.UNKEYED_FRAGMENT]: `UNKEYED_FRAGMENT`,
-  [PatchFlags.DYNAMIC_SLOTS]: `DYNAMIC_SLOTS`,
-  [PatchFlags.NEED_PATCH]: `NEED_PATCH`,
-  [PatchFlags.HOISTED]: `HOISTED`,
-  [PatchFlags.BAIL]: `BAIL`
-}
+  [PatchFlags.TEXT]: 'TEXT',
+  [PatchFlags.CLASS]: 'CLASS',
+  [PatchFlags.STYLE]: 'STYLE',
+  [PatchFlags.PROPS]: 'PROPS',
+  [PatchFlags.FULL_PROPS]: 'FULL_PROPS',
+  [PatchFlags.HYDRATE_EVENTS]: 'HYDRATE_EVENTS',
+  [PatchFlags.STABLE_FRAGMENT]: 'STABLE_FRAGMENT',
+  [PatchFlags.KEYED_FRAGMENT]: 'KEYED_FRAGMENT',
+  [PatchFlags.UNKEYED_FRAGMENT]: 'UNKEYED_FRAGMENT',
+  [PatchFlags.DYNAMIC_SLOTS]: 'DYNAMIC_SLOTS',
+  [PatchFlags.NEED_PATCH]: 'NEED_PATCH',
+  [PatchFlags.HOISTED]: 'HOISTED',
+  [PatchFlags.BAIL]: 'BAIL',
+};

packages/babel-plugin-jsx/src/sugar-fragment.ts

@@ -1,7 +1,7 @@
-import * as t from '@babel/types'
+import * as t from '@babel/types';
 import { addNamespace } from '@babel/helper-module-imports';
 import { NodePath } from '@babel/traverse';
-import { State } from './';
+import { State } from '.';
 
 const transformFragment = (path: NodePath<t.JSXElement>, Fragment: t.JSXMemberExpression) => {
   const children = path.get('children') || [];