Skip to content

Commit 172eef5

Browse files
authored
refactor: remove expressions that is always false (#618)
1 parent 2ddead0 commit 172eef5

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

src/reactivity/reactive.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -162,12 +162,6 @@ export function shallowReactive(obj: any): any {
162162
}
163163
getter = property.get
164164
setter = property.set
165-
if (
166-
(!getter || setter) /* not only have getter */ &&
167-
arguments.length === 2
168-
) {
169-
val = obj[key]
170-
}
171165
}
172166

173167
Object.defineProperty(observed, key, {

src/reactivity/readonly.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,20 +59,12 @@ export function shallowReadonly(obj: any): any {
5959
for (const key of Object.keys(obj)) {
6060
let val = obj[key]
6161
let getter: (() => any) | undefined
62-
let setter: ((x: any) => void) | undefined
6362
const property = Object.getOwnPropertyDescriptor(obj, key)
6463
if (property) {
6564
if (property.configurable === false) {
6665
continue
6766
}
6867
getter = property.get
69-
setter = property.set
70-
if (
71-
(!getter || setter) /* not only have getter */ &&
72-
arguments.length === 2
73-
) {
74-
val = obj[key]
75-
}
7668
}
7769

7870
Object.defineProperty(readonlyObj, key, {

0 commit comments

Comments
 (0)