refactor(runtime-core): pre-refactoring of scheduling rewrite

Author: johnsoncodehk

packages/reactivity/__tests__/effectScope.spec.ts

@@ -2,6 +2,7 @@ import { nextTick, watch, watchEffect } from '@vue/runtime-core'
 import {
   type ComputedRef,
   EffectScope,
+  ReactiveEffect,
   computed,
   effect,
   effectScope,
@@ -89,7 +90,7 @@ describe('reactivity/effect/scope', () => {
       })
     })
 
-    expect(getEffectsCount(scope)).toBe(2)
+    expect(getEffectsCount(scope)).toBe(1)
     expect(scope.deps?.nextDep?.dep).toBeInstanceOf(EffectScope)
 
     expect(dummy).toBe(0)
@@ -367,7 +368,7 @@ describe('reactivity/effect/scope', () => {
 function getEffectsCount(scope: EffectScope): number {
   let n = 0
   for (let dep = scope.deps; dep !== undefined; dep = dep.nextDep) {
-    if ('notify' in dep.dep) {
+    if (dep.dep instanceof ReactiveEffect) {
       n++
     }
   }

packages/reactivity/src/effect.ts

@@ -60,7 +60,7 @@ export class ReactiveEffect<T = any>
   // Subscriber
   deps: Link | undefined = undefined
   depsTail: Link | undefined = undefined
-  flags: number = 0
+  flags: number = SubscriberFlags.Dirty
   cleanups: number = 0
 
   // Dependency

packages/reactivity/src/system.ts

@@ -151,7 +151,7 @@ export function propagate(current: Link): void {
     const sub = current.sub
     const subFlags = sub.flags
 
-    let shouldNotify = 0
+    let shouldNotify = false
 
     if (
       !(
@@ -163,23 +163,23 @@ export function propagate(current: Link): void {
       )
     ) {
       sub.flags = subFlags | targetFlag
-      shouldNotify = 1
+      shouldNotify = true
     } else if (
       subFlags & SubscriberFlags.Recursed &&
       !(subFlags & SubscriberFlags.Tracking)
     ) {
       sub.flags = (subFlags & ~SubscriberFlags.Recursed) | targetFlag
-      shouldNotify = 1
+      shouldNotify = true
     } else if (
       !(subFlags & (SubscriberFlags.Dirty | SubscriberFlags.Pending)) &&
       isValidLink(current, sub)
     ) {
       sub.flags = subFlags | SubscriberFlags.Recursed | targetFlag
-      shouldNotify = 2
+      shouldNotify = !('notify' in sub)
     }
 
     if (shouldNotify) {
-      if (shouldNotify === 1 && 'notify' in sub) {
+      if ('notify' in sub) {
         notifyBuffer[notifyBufferLength++] = sub
       } else {
         const subSubs = (sub as Dependency).subs