Skip to content

Commit 4ca7e7a

Browse files
committed
refactor(reactivity): remove NOTIFIED flag
1 parent 4765af3 commit 4ca7e7a

File tree

3 files changed

+2
-13
lines changed

3 files changed

+2
-13
lines changed

packages/reactivity/src/effect.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ export enum EffectFlags {
5050
*/
5151
ALLOW_RECURSE = 1 << 7,
5252
PAUSED = 1 << 8,
53-
NOTIFIED = 1 << 9,
5453
}
5554

5655
export class ReactiveEffect<T = any>
@@ -99,12 +98,8 @@ export class ReactiveEffect<T = any>
9998
}
10099

101100
resume(): void {
102-
let flags = this.flags
103-
if (flags & EffectFlags.PAUSED) {
104-
this.flags = flags &= ~EffectFlags.PAUSED
105-
}
106-
if (flags & EffectFlags.NOTIFIED) {
107-
this.flags = flags &= ~EffectFlags.NOTIFIED
101+
const flags = (this.flags &= ~EffectFlags.PAUSED)
102+
if (flags & (ReactiveFlags.Dirty | ReactiveFlags.Pending)) {
108103
this.notify()
109104
}
110105
}
@@ -113,8 +108,6 @@ export class ReactiveEffect<T = any>
113108
const flags = this.flags
114109
if (!(flags & EffectFlags.PAUSED)) {
115110
this.scheduler()
116-
} else {
117-
this.flags = flags | EffectFlags.NOTIFIED
118111
}
119112
}
120113

packages/runtime-core/src/apiWatch.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,6 @@ class RenderWatcherEffect extends WatcherEffect {
187187
} else {
188188
this.scheduler()
189189
}
190-
} else {
191-
this.flags = flags | EffectFlags.NOTIFIED
192190
}
193191
}
194192
}

packages/runtime-vapor/src/renderEffect.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,6 @@ class RenderEffect extends ReactiveEffect {
7474
const flags = this.flags
7575
if (!(flags & EffectFlags.PAUSED)) {
7676
queueJob(this.job, this.i ? this.i.uid : undefined)
77-
} else {
78-
this.flags = flags | EffectFlags.NOTIFIED
7977
}
8078
}
8179
}

0 commit comments

Comments
 (0)