fix(compiler-core): pick last char when dynamic directive doesn't close (#4507)

HerringtonDarkholme · web-flow · commit 5d262e08d5d5 · 2021-09-07T11:36:37.000-04:00
diff --git a/packages/compiler-core/__tests__/__snapshots__/parse.spec.ts.snap b/packages/compiler-core/__tests__/__snapshots__/parse.spec.ts.snap
@@ -6260,7 +6260,7 @@ Object {
         Object {
           "arg": Object {
             "constType": 0,
-            "content": "se",
+            "content": "sef",
             "isStatic": false,
             "loc": Object {
               "end": Object {
diff --git a/packages/compiler-core/src/parse.ts b/packages/compiler-core/src/parse.ts
@@ -814,9 +814,10 @@ function parseAttribute(
             context,
             ErrorCodes.X_MISSING_DYNAMIC_DIRECTIVE_ARGUMENT_END
           )
+          content = content.substr(1)
+        } else {
+          content = content.substr(1, content.length - 2)
         }
-
-        content = content.substr(1, content.length - 2)
       } else if (isSlot) {
         // #1241 special case for v-slot: vuetify relies extensively on slot
         // names containing dots. v-slot doesn't have any modifiers and Vue 2.x

Original file line number	Diff line number	Diff line change
`@@ -814,9 +814,10 @@ function parseAttribute(`
`814`	`814`	`context,`
`815`	`815`	`ErrorCodes.X_MISSING_DYNAMIC_DIRECTIVE_ARGUMENT_END`
`816`	`816`	`)`
	`817`	`+ content = content.substr(1)`
	`818`	`+ } else {`
	`819`	`+ content = content.substr(1, content.length - 2)`
`817`	`820`	`}`
`818`		`-`
`819`		`- content = content.substr(1, content.length - 2)`
`820`	`821`	`} else if (isSlot) {`
`821`	`822`	`// #1241 special case for v-slot: vuetify relies extensively on slot`
`822`	`823`	`// names containing dots. v-slot doesn't have any modifiers and Vue 2.x`