refactor(reactivity): move warning for active effect restoration to endTracking function

Author: johnsoncodehk

packages/reactivity/src/effect.ts

@@ -119,12 +119,6 @@ export class ReactiveEffect<T = any>
     try {
       return this.fn()
     } finally {
-      if (__DEV__ && activeSub !== this) {
-        warn(
-          'Active effect was not restored correctly - ' +
-            'this is likely a Vue internal bug.',
-        )
-      }
       endTracking(this, prevSub)
       const flags = this.flags
       if (

packages/reactivity/src/system.ts

@@ -3,6 +3,7 @@
 import type { ComputedRefImpl as Computed } from './computed.js'
 import type { ReactiveEffect as Effect } from './effect.js'
 import type { EffectScope } from './effectScope.js'
+import { warn } from './warning.js'
 
 export interface ReactiveNode {
   deps?: Link
@@ -234,13 +235,20 @@ export function endTracking(
   sub: ReactiveNode,
   prevSub: ReactiveNode | undefined,
 ): void {
+  if (__DEV__ && activeSub !== sub) {
+    warn(
+      'Active effect was not restored correctly - ' +
+        'this is likely a Vue internal bug.',
+    )
+  }
+  activeSub = prevSub
+
   const depsTail = sub.depsTail
   let toRemove = depsTail !== undefined ? depsTail.nextDep : sub.deps
   while (toRemove !== undefined) {
     toRemove = unlink(toRemove, sub)
   }
   sub.flags &= ~ReactiveFlags.RecursedCheck
-  activeSub = prevSub
 }
 
 export function flush(): void {