Skip to content

Commit 94d692b

Browse files
committed
test: fix tests after missing end tag error location fix
1 parent 9560ab7 commit 94d692b

File tree

2 files changed

+53
-48
lines changed

2 files changed

+53
-48
lines changed

packages/compiler-core/__tests__/parse.spec.ts

Lines changed: 47 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -1514,7 +1514,7 @@ describe('compiler: parse', () => {
15141514
test('invalid html', () => {
15151515
expect(() => {
15161516
parse(`<div>\n<span>\n</div>\n</span>`)
1517-
}).toThrow('End tag was not found.')
1517+
}).toThrow('Element is missing end tag.')
15181518

15191519
const spy = jest.fn()
15201520
const ast = parse(`<div>\n<span>\n</div>\n</span>`, {
@@ -1527,8 +1527,8 @@ describe('compiler: parse', () => {
15271527
code: ErrorCodes.X_MISSING_END_TAG,
15281528
loc: {
15291529
start: {
1530-
offset: 13,
1531-
line: 3,
1530+
offset: 6,
1531+
line: 2,
15321532
column: 1
15331533
}
15341534
}
@@ -1833,7 +1833,7 @@ foo
18331833
},
18341834
{
18351835
type: ErrorCodes.X_MISSING_END_TAG,
1836-
loc: { offset: 11, line: 1, column: 12 }
1836+
loc: { offset: 0, line: 1, column: 1 }
18371837
}
18381838
]
18391839
},
@@ -1846,7 +1846,7 @@ foo
18461846
},
18471847
{
18481848
type: ErrorCodes.X_MISSING_END_TAG,
1849-
loc: { offset: 12, line: 1, column: 13 }
1849+
loc: { offset: 0, line: 1, column: 1 }
18501850
}
18511851
]
18521852
}
@@ -1861,11 +1861,11 @@ foo
18611861
},
18621862
{
18631863
type: ErrorCodes.X_MISSING_END_TAG,
1864-
loc: { offset: 29, line: 1, column: 30 }
1864+
loc: { offset: 10, line: 1, column: 11 }
18651865
},
18661866
{
18671867
type: ErrorCodes.X_MISSING_END_TAG,
1868-
loc: { offset: 29, line: 1, column: 30 }
1868+
loc: { offset: 0, line: 1, column: 1 }
18691869
}
18701870
]
18711871
},
@@ -1878,11 +1878,11 @@ foo
18781878
},
18791879
{
18801880
type: ErrorCodes.X_MISSING_END_TAG,
1881-
loc: { offset: 24, line: 1, column: 25 }
1881+
loc: { offset: 10, line: 1, column: 11 }
18821882
},
18831883
{
18841884
type: ErrorCodes.X_MISSING_END_TAG,
1885-
loc: { offset: 24, line: 1, column: 25 }
1885+
loc: { offset: 0, line: 1, column: 1 }
18861886
}
18871887
]
18881888
}
@@ -1897,7 +1897,7 @@ foo
18971897
},
18981898
{
18991899
type: ErrorCodes.X_MISSING_END_TAG,
1900-
loc: { offset: 21, line: 1, column: 22 }
1900+
loc: { offset: 0, line: 1, column: 1 }
19011901
}
19021902
]
19031903
},
@@ -1910,7 +1910,7 @@ foo
19101910
},
19111911
{
19121912
type: ErrorCodes.X_MISSING_END_TAG,
1913-
loc: { offset: 14, line: 1, column: 15 }
1913+
loc: { offset: 0, line: 1, column: 1 }
19141914
}
19151915
]
19161916
},
@@ -1925,7 +1925,7 @@ foo
19251925
},
19261926
{
19271927
type: ErrorCodes.X_MISSING_END_TAG,
1928-
loc: { offset: 12, line: 1, column: 13 }
1928+
loc: { offset: 0, line: 1, column: 1 }
19291929
}
19301930
]
19311931
},
@@ -1938,7 +1938,7 @@ foo
19381938
},
19391939
{
19401940
type: ErrorCodes.X_MISSING_END_TAG,
1941-
loc: { offset: 13, line: 1, column: 14 }
1941+
loc: { offset: 0, line: 1, column: 1 }
19421942
}
19431943
]
19441944
},
@@ -1951,7 +1951,7 @@ foo
19511951
},
19521952
{
19531953
type: ErrorCodes.X_MISSING_END_TAG,
1954-
loc: { offset: 15, line: 1, column: 16 }
1954+
loc: { offset: 0, line: 1, column: 1 }
19551955
}
19561956
]
19571957
}
@@ -1962,7 +1962,7 @@ foo
19621962
errors: [
19631963
{
19641964
type: ErrorCodes.X_MISSING_END_TAG,
1965-
loc: { offset: 32, line: 1, column: 33 }
1965+
loc: { offset: 0, line: 1, column: 1 }
19661966
},
19671967
{
19681968
type: ErrorCodes.EOF_IN_SCRIPT_HTML_COMMENT_LIKE_TEXT,
@@ -1975,7 +1975,7 @@ foo
19751975
errors: [
19761976
{
19771977
type: ErrorCodes.X_MISSING_END_TAG,
1978-
loc: { offset: 28, line: 1, column: 29 }
1978+
loc: { offset: 0, line: 1, column: 1 }
19791979
}
19801980
]
19811981
}
@@ -1990,11 +1990,11 @@ foo
19901990
},
19911991
{
19921992
type: ErrorCodes.X_MISSING_END_TAG,
1993-
loc: { offset: 14, line: 1, column: 15 }
1993+
loc: { offset: 10, line: 1, column: 11 }
19941994
},
19951995
{
19961996
type: ErrorCodes.X_MISSING_END_TAG,
1997-
loc: { offset: 14, line: 1, column: 15 }
1997+
loc: { offset: 0, line: 1, column: 1 }
19981998
}
19991999
]
20002000
},
@@ -2007,11 +2007,11 @@ foo
20072007
},
20082008
{
20092009
type: ErrorCodes.X_MISSING_END_TAG,
2010-
loc: { offset: 15, line: 1, column: 16 }
2010+
loc: { offset: 10, line: 1, column: 11 }
20112011
},
20122012
{
20132013
type: ErrorCodes.X_MISSING_END_TAG,
2014-
loc: { offset: 15, line: 1, column: 16 }
2014+
loc: { offset: 0, line: 1, column: 1 }
20152015
}
20162016
]
20172017
},
@@ -2024,11 +2024,11 @@ foo
20242024
},
20252025
{
20262026
type: ErrorCodes.X_MISSING_END_TAG,
2027-
loc: { offset: 17, line: 1, column: 18 }
2027+
loc: { offset: 10, line: 1, column: 11 }
20282028
},
20292029
{
20302030
type: ErrorCodes.X_MISSING_END_TAG,
2031-
loc: { offset: 17, line: 1, column: 18 }
2031+
loc: { offset: 0, line: 1, column: 1 }
20322032
}
20332033
]
20342034
},
@@ -2041,11 +2041,11 @@ foo
20412041
},
20422042
{
20432043
type: ErrorCodes.X_MISSING_END_TAG,
2044-
loc: { offset: 18, line: 1, column: 19 }
2044+
loc: { offset: 10, line: 1, column: 11 }
20452045
},
20462046
{
20472047
type: ErrorCodes.X_MISSING_END_TAG,
2048-
loc: { offset: 18, line: 1, column: 19 }
2048+
loc: { offset: 0, line: 1, column: 1 }
20492049
}
20502050
]
20512051
},
@@ -2062,11 +2062,11 @@ foo
20622062
},
20632063
{
20642064
type: ErrorCodes.X_MISSING_END_TAG,
2065-
loc: { offset: 19, line: 1, column: 20 }
2065+
loc: { offset: 10, line: 1, column: 11 }
20662066
},
20672067
{
20682068
type: ErrorCodes.X_MISSING_END_TAG,
2069-
loc: { offset: 19, line: 1, column: 20 }
2069+
loc: { offset: 0, line: 1, column: 1 }
20702070
}
20712071
]
20722072
},
@@ -2079,11 +2079,11 @@ foo
20792079
},
20802080
{
20812081
type: ErrorCodes.X_MISSING_END_TAG,
2082-
loc: { offset: 22, line: 1, column: 23 }
2082+
loc: { offset: 10, line: 1, column: 11 }
20832083
},
20842084
{
20852085
type: ErrorCodes.X_MISSING_END_TAG,
2086-
loc: { offset: 22, line: 1, column: 23 }
2086+
loc: { offset: 0, line: 1, column: 1 }
20872087
}
20882088
]
20892089
},
@@ -2096,11 +2096,11 @@ foo
20962096
},
20972097
{
20982098
type: ErrorCodes.X_MISSING_END_TAG,
2099-
loc: { offset: 22, line: 1, column: 23 }
2099+
loc: { offset: 10, line: 1, column: 11 }
21002100
},
21012101
{
21022102
type: ErrorCodes.X_MISSING_END_TAG,
2103-
loc: { offset: 22, line: 1, column: 23 }
2103+
loc: { offset: 0, line: 1, column: 1 }
21042104
}
21052105
]
21062106
},
@@ -2113,11 +2113,11 @@ foo
21132113
},
21142114
{
21152115
type: ErrorCodes.X_MISSING_END_TAG,
2116-
loc: { offset: 23, line: 1, column: 24 }
2116+
loc: { offset: 10, line: 1, column: 11 }
21172117
},
21182118
{
21192119
type: ErrorCodes.X_MISSING_END_TAG,
2120-
loc: { offset: 23, line: 1, column: 24 }
2120+
loc: { offset: 0, line: 1, column: 1 }
21212121
}
21222122
]
21232123
},
@@ -2130,11 +2130,11 @@ foo
21302130
},
21312131
{
21322132
type: ErrorCodes.X_MISSING_END_TAG,
2133-
loc: { offset: 23, line: 1, column: 24 }
2133+
loc: { offset: 10, line: 1, column: 11 }
21342134
},
21352135
{
21362136
type: ErrorCodes.X_MISSING_END_TAG,
2137-
loc: { offset: 23, line: 1, column: 24 }
2137+
loc: { offset: 0, line: 1, column: 1 }
21382138
}
21392139
]
21402140
},
@@ -2147,11 +2147,11 @@ foo
21472147
},
21482148
{
21492149
type: ErrorCodes.X_MISSING_END_TAG,
2150-
loc: { offset: 21, line: 1, column: 22 }
2150+
loc: { offset: 10, line: 1, column: 11 }
21512151
},
21522152
{
21532153
type: ErrorCodes.X_MISSING_END_TAG,
2154-
loc: { offset: 21, line: 1, column: 22 }
2154+
loc: { offset: 0, line: 1, column: 1 }
21552155
}
21562156
]
21572157
},
@@ -2168,11 +2168,11 @@ foo
21682168
},
21692169
{
21702170
type: ErrorCodes.X_MISSING_END_TAG,
2171-
loc: { offset: 24, line: 1, column: 25 }
2171+
loc: { offset: 10, line: 1, column: 11 }
21722172
},
21732173
{
21742174
type: ErrorCodes.X_MISSING_END_TAG,
2175-
loc: { offset: 24, line: 1, column: 25 }
2175+
loc: { offset: 0, line: 1, column: 1 }
21762176
}
21772177
]
21782178
},
@@ -2189,11 +2189,11 @@ foo
21892189
},
21902190
{
21912191
type: ErrorCodes.X_MISSING_END_TAG,
2192-
loc: { offset: 24, line: 1, column: 25 }
2192+
loc: { offset: 10, line: 1, column: 11 }
21932193
},
21942194
{
21952195
type: ErrorCodes.X_MISSING_END_TAG,
2196-
loc: { offset: 24, line: 1, column: 25 }
2196+
loc: { offset: 0, line: 1, column: 1 }
21972197
}
21982198
]
21992199
},
@@ -2210,11 +2210,11 @@ foo
22102210
},
22112211
{
22122212
type: ErrorCodes.X_MISSING_END_TAG,
2213-
loc: { offset: 23, line: 1, column: 24 }
2213+
loc: { offset: 10, line: 1, column: 11 }
22142214
},
22152215
{
22162216
type: ErrorCodes.X_MISSING_END_TAG,
2217-
loc: { offset: 23, line: 1, column: 24 }
2217+
loc: { offset: 0, line: 1, column: 1 }
22182218
}
22192219
]
22202220
}
@@ -2292,7 +2292,7 @@ foo
22922292
},
22932293
{
22942294
type: ErrorCodes.X_MISSING_END_TAG,
2295-
loc: { offset: 27, line: 1, column: 28 }
2295+
loc: { offset: 0, line: 1, column: 1 }
22962296
}
22972297
]
22982298
},
@@ -2429,7 +2429,7 @@ foo
24292429
},
24302430
{
24312431
type: ErrorCodes.X_MISSING_END_TAG,
2432-
loc: { offset: 19, line: 1, column: 20 }
2432+
loc: { offset: 0, line: 1, column: 1 }
24332433
}
24342434
]
24352435
}
@@ -2651,7 +2651,7 @@ foo
26512651
errors: [
26522652
{
26532653
type: ErrorCodes.X_MISSING_END_TAG,
2654-
loc: { offset: 15, line: 1, column: 16 }
2654+
loc: { offset: 10, line: 1, column: 11 }
26552655
}
26562656
]
26572657
},
@@ -2660,11 +2660,11 @@ foo
26602660
errors: [
26612661
{
26622662
type: ErrorCodes.X_MISSING_END_TAG,
2663-
loc: { offset: 15, line: 1, column: 16 }
2663+
loc: { offset: 10, line: 1, column: 11 }
26642664
},
26652665
{
26662666
type: ErrorCodes.X_MISSING_END_TAG,
2667-
loc: { offset: 15, line: 1, column: 16 }
2667+
loc: { offset: 0, line: 1, column: 1 }
26682668
}
26692669
]
26702670
}

packages/vue/__tests__/index.spec.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,12 @@ describe('compiler + runtime integration', () => {
6262
}
6363
createApp().mount(App, container)
6464
expect(
65-
`Template compilation error: End tag was not found`
65+
`Template compilation error: Element is missing end tag`
66+
).toHaveBeenWarned()
67+
expect(
68+
`
69+
1 | <div v-if>
70+
| ^`.trim()
6671
).toHaveBeenWarned()
6772
expect(`v-if/v-else-if is missing expression`).toHaveBeenWarned()
6873
expect(

0 commit comments

Comments
 (0)