Skip to content

Commit d34c1ac

Browse files
committed
refactor: simplify __DEV__ HMR registration and remove isSingleRoot from async component creation.
1 parent bce68d5 commit d34c1ac

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

packages/runtime-vapor/src/apiDefineAsyncComponent.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,12 +181,14 @@ function createInnerComp(
181181
parent: VaporComponentInstance & TransitionOptions,
182182
frag?: DynamicFragment,
183183
): VaporComponentInstance {
184-
const { rawProps, rawSlots, isSingleRoot, appContext, $transition } = parent
184+
const { rawProps, rawSlots, appContext, $transition } = parent
185185
const instance = createComponent(
186186
comp,
187187
rawProps,
188188
rawSlots,
189-
isSingleRoot,
189+
// rawProps is shared and already contains fallthrough attrs.
190+
// so isSingleRoot should be undefined
191+
undefined,
190192
undefined,
191193
appContext,
192194
)

packages/runtime-vapor/src/component.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -272,14 +272,12 @@ export function createComponent(
272272
const prevSlotConsumer = setCurrentSlotConsumer(null)
273273

274274
// HMR
275-
if (__DEV__ && component.__hmrId) {
275+
if (__DEV__) {
276276
registerHMR(instance)
277277
instance.isSingleRoot = isSingleRoot
278278
instance.hmrRerender = hmrRerender.bind(null, instance)
279279
instance.hmrReload = hmrReload.bind(null, instance)
280-
}
281280

282-
if (__DEV__) {
283281
pushWarningContext(instance)
284282
startMeasure(instance, `init`)
285283

0 commit comments

Comments
 (0)