Skip to content

Commit e0ac500

Browse files
authored
refactor(transition-group): directly returns slotted block instead of wrapping it in DynamicFragment. (#14122)
1 parent b9dca57 commit e0ac500

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

packages/runtime-vapor/src/apiCreateFor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export const createFor = (
133133

134134
// trigger TransitionGroup update hooks
135135
const transitionHooks = frag.$transition
136-
if (transitionHooks && transitionHooks.group) {
136+
if (transitionHooks && transitionHooks.group && isMounted) {
137137
triggerTransitionGroupUpdate(transitionHooks)
138138
}
139139

packages/runtime-vapor/src/components/TransitionGroup.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ import {
3636
import { isForBlock } from '../apiCreateFor'
3737
import { renderEffect } from '../renderEffect'
3838
import { createElement } from '../dom/node'
39-
import { DynamicFragment, isFragment } from '../fragment'
39+
import { isFragment } from '../fragment'
4040

4141
const positionMap = new WeakMap<TransitionBlock, DOMRect>()
4242
const newPositionMap = new WeakMap<TransitionBlock, DOMRect>()
@@ -160,11 +160,7 @@ export const VaporTransitionGroup: ObjectVaporComponent = decorate({
160160
}
161161
return container
162162
} else {
163-
const frag = __DEV__
164-
? new DynamicFragment('transition-group')
165-
: new DynamicFragment()
166-
renderEffect(() => frag.update(() => slottedBlock))
167-
return frag
163+
return slottedBlock
168164
}
169165
},
170166
})

0 commit comments

Comments
 (0)