Skip to content

Conversation

@FatRadish
Copy link
Contributor

close #12807

@FatRadish FatRadish closed this Feb 12, 2025
@edison1105 edison1105 reopened this Feb 12, 2025
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: reactivity 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Feb 12, 2025
@github-actions
Copy link

github-actions bot commented Feb 12, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38.1 kB (+4 B) 34.3 kB (-3 B)
vue.global.prod.js 158 kB 58 kB (+3 B) 51.6 kB (+18 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB 18.2 kB (-1 B) 16.7 kB (+5 B)
createApp 54.6 kB 21.3 kB (+5 B) 19.4 kB (-1 B)
createSSRApp 58.8 kB 23 kB (-1 B) 21 kB
defineCustomElement 59.4 kB 22.9 kB 20.8 kB (+4 B)
overall 68.6 kB 26.4 kB (+3 B) 24.1 kB (+47 B)

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 12, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12824

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12824

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12824

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12824

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12824

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12824

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12824

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12824

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12824

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12824

vue

npm i https://pkg.pr.new/vue@12824

commit: 3cb45eb

@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Feb 12, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@FatRadish FatRadish closed this Feb 19, 2025
@FatRadish FatRadish deleted the fix-markRaw-with-reactive branch February 19, 2025 03:26
@FatRadish FatRadish restored the fix-markRaw-with-reactive branch February 19, 2025 03:26
@FatRadish FatRadish reopened this Feb 19, 2025
@FatRadish
Copy link
Contributor Author

Sorry, I'm not sure why Merging is blocked

@edison1105
Copy link
Member

@FatRadish
Because other higher-priority PRs need to be dealt with first.
But this PR will be merged soon.

@edison1105 edison1105 merged commit 295b5ec into vuejs:main Feb 19, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: reactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

why not Reorder getTargetType check after proxyMap lookup in createReactiveObject

3 participants