Skip to content

Conversation

@johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented May 4, 2025

Reactivity Changes

  • Core Updates:
    • Ported alien-signals 2.0
    • Deferred RefImpl evaluation to prevent unnecessary computations
    • Simplified EffectFlags handling
    • Improved cleanup performance in ReactiveEffect/EffectScope by avoiding cleanups length changes
    • Added internal setCurrentScope() method

Effect System Refactoring

  • Effect:

    • Removed onStop property
    • Removed scheduler method (logic merged into notify)
  • EffectScope:

    • Introduced link() for hierarchical relationships
    • Added: subs, subsTail, cleanupsLength properties
    • Removed: effects, parent, scopes, index, _on, detached, prevScope
    • Removed on/off methods with using setCurrentScope
  • Watcher:

    • Converted to class for better extensibility
    • Simplified implementation (removed scheduler and augmentJob options)

Runtime-Core Changes

  • Instance Management:
    • setCurrentInstance now returns previous instance instead of cleanup function
    • Consolidated simpleSetCurrentInstance and internalSetCurrentInstance
    • Removed unsetCurrentInstance method
    • Use setActiveSub(undefined) instead of pauseTracking() internally

API Refactoring

  • Reactivity APIs:

    • Streamlined initialization for watch(), watchEffect(), renderEffect()
    • Converted to classes to reduce memory usage
  • Scheduler:

    • Simplified algorithm and reduced variables
    • API Changes:
      • queueJob now requires uid and isPre parameters
      • queuePostFlushCb requires uid parameter
      • Optimized flushPostFlushCbs performance

@coderabbitai
Copy link

coderabbitai bot commented May 4, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link

netlify bot commented May 4, 2025

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 0666601
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/681db24a68a4400008f55a8f
😎 Deploy Preview https://deploy-preview-13274--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 4, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13274

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13274

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13274

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13274

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13274

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13274

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13274

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13274

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13274

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13274

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13274

vue

npm i https://pkg.pr.new/vue@13274

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13274

commit: c581dd9

@edison1105 edison1105 added the scope: vapor related to vapor mode label May 5, 2025
@johnsoncodehk johnsoncodehk marked this pull request as ready for review May 5, 2025 05:20
@johnsoncodehk johnsoncodehk force-pushed the vapor-refactor branch 2 times, most recently from af9650e to 03566c6 Compare May 8, 2025 10:06
@edison1105 edison1105 deleted the branch vuejs:minor July 7, 2025 00:06
@edison1105 edison1105 closed this Jul 7, 2025
@edison1105 edison1105 reopened this Jul 7, 2025
@edison1105 edison1105 changed the base branch from vapor to minor July 7, 2025 00:44
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.1 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB (+628 B) 39.1 kB (+40 B) 35.2 kB (-3 B)
vue.global.prod.js 162 kB (+630 B) 59.3 kB (-7 B) 52.8 kB (-22 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB (-332 B) 18.5 kB (-128 B) 16.9 kB (-108 B)
createApp 56 kB (+99 B) 21.6 kB (-79 B) 19.7 kB (-121 B)
createApp + vaporInteropPlugin 68.5 kB (+538 B) 25.8 kB (-46 B) 23.6 kB (-26 B)
createVaporApp 21 kB (+117 B) 8.29 kB 7.59 kB (+7 B)
createSSRApp 60.3 kB (+106 B) 23.3 kB (-123 B) 21.3 kB (-109 B)
defineCustomElement 61 kB (+110 B) 23.1 kB (-104 B) 21.1 kB (-102 B)
overall 70.5 kB (+323 B) 26.8 kB (-62 B) 24.5 kB (+16 B)

@yyx990803
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Jul 10, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
pinia failure success
radix-vue success success
language-tools success success
nuxt success success
quasar success success
router success success
primevue success success
vue-i18n failure success
vant success success
test-utils failure success
vite-plugin-vue failure success
vue-macros failure failure
vitepress success success
vuetify failure success
vueuse failure success
vue-simple-compiler success success

@vuejs vuejs deleted a comment from edison1105 Jul 10, 2025
@yyx990803
Copy link
Member

Looks like many of the failed ecosystem-ci cases are type/build related. Runtime behavior is good enough for pass for quasar and nuxt, so merging for now. @johnsoncodehk will further resolve ecosystem-ci issues before official 3.6 release.

@yyx990803 yyx990803 merged commit 5a528aa into vuejs:minor Jul 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants