Skip to content

Commit 2d77ded

Browse files
committed
ci: add comments for the reason of excluding bare templates from unit and e2e tests
1 parent 976ac5e commit 2d77ded

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ jobs:
5151
verification-script:
5252
- pnpm --filter '!*typescript*' build
5353
- pnpm --filter '*typescript*' build
54+
# bare templates only contain vitest configurations, but do not include unit test files
5455
- pnpm --filter '*vitest*' --filter '!*bare*' test:unit
5556
- pnpm --filter '*eslint*' lint --no-fix --max-warnings=0
5657
- pnpm --filter '*prettier*' format --write --check
@@ -167,10 +168,12 @@ jobs:
167168

168169
- name: Run e2e test script
169170
working-directory: ./playground
171+
# bare templates can't pass e2e tests because their page structures don't match the example tests
170172
run: pnpm --filter '*${{ matrix.e2e-framework }}*' --filter '!*bare*' --workspace-concurrency 1 test:e2e
171173

172174
- name: Cypress component testing for projects without Vitest
173175
if: ${{ contains(matrix.e2e-framework, 'cypress') }}
176+
# bare templates only contain test configurations, but do not include component test files
174177
run: pnpm --filter '*cypress*' --filter '!*vitest*' --filter '!*bare*' --workspace-concurrency 1 test:unit
175178

176179
# FIXME: `--with-tests` folders. It's failing now.

0 commit comments

Comments
 (0)