Skip to content

Commit db07bd2

Browse files
committed
ci: update e2e job to latest implementations
1 parent 217386c commit db07bd2

File tree

1 file changed

+16
-17
lines changed

1 file changed

+16
-17
lines changed

.github/workflows/ci.yml

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -99,24 +99,23 @@ jobs:
9999
CYPRESS_VERIFY_TIMEOUT: 60000
100100
steps:
101101
- uses: actions/checkout@v4
102-
- uses: pnpm/action-setup@v3
102+
with:
103+
submodules: true
104+
- uses: pnpm/action-setup@v4
103105
- uses: actions/setup-node@v4
104106
with:
105107
node-version: ${{ matrix.node-version }}
106108
cache: 'pnpm'
107109

108-
- uses: actions/cache/restore@v4
109-
id: cache-restore
110+
# use artifacts to share the playground across different jobs
111+
- uses: actions/download-artifact@v4
110112
with:
111-
path: outfile.cjs
112-
key: ${{ github.sha }}-${{ hashFiles('pnpm-lock.yaml') }}
113-
- name: Build the package on cache miss
114-
if: steps.cache-restore.outputs.cache-hit != 'true'
115-
run: pnpm install && pnpm build
116-
- name: Snapshot
117-
run: pnpm snapshot && echo "{}" > playground/package.json && mv playground ../playground
113+
name: build-output
114+
115+
- name: Install dependencies to avoid tsconfig warnings
116+
run: pnpm install
118117
- name: Install dependencies in playground
119-
working-directory: ../playground
118+
working-directory: ./playground
120119
run: pnpm install --no-frozen-lockfile
121120

122121
# https://github.com/vitejs/vite/blob/main/.github/workflows/ci.yml#L62
@@ -151,19 +150,19 @@ jobs:
151150

152151
- name: Download Cypress
153152
if: ${{ contains(matrix.e2e-framework, 'cypress') }}
154-
working-directory: ../playground
153+
working-directory: ./playground/cypress
155154
run: |
156-
pnpm --filter "{cypress}" exec cypress cache list
157-
pnpm --filter "{cypress}" exec cypress install
155+
pnpm exec cypress cache list
156+
pnpm exec cypress install
158157
159158
- if: ${{ contains(matrix.e2e-framework, 'playwright') }}
160159
name: Install Playwright dependencies
161-
working-directory: ../playground
162-
run: pnpm --filter "{playwright}" exec playwright install --with-deps
160+
working-directory: ./playground/playwright
161+
run: pnpm exec playwright install --with-deps
163162

164163
# Run `test:e2e` in project folders contain `matrix.e2e-framework`
165164
- name: Run e2e test script
166-
working-directory: ../playground
165+
working-directory: ./playground
167166
run: pnpm --filter "{*${{ matrix.e2e-framework }}*}" test:e2e
168167

169168
# FIXME: `--with-tests` folders

0 commit comments

Comments
 (0)