Skip to content

Commit 2b4fbd2

Browse files
fix(vite+overlay): using mjs overlay bundle for vite plugin (#408)
Co-authored-by: arlo <[email protected]>
1 parent f138c20 commit 2b4fbd2

File tree

5 files changed

+45
-8
lines changed

5 files changed

+45
-8
lines changed

packages/overlay/vite.config.ts

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,32 @@ export default defineConfig({
3838
async closeBundle() {
3939
// copy
4040
const overlayFile = resolve(__dirname, './dist')
41+
42+
const overlayJsFile = resolve(__dirname, './dist/devtools-overlay.js')
43+
const overlayMjsFile = resolve(__dirname, './dist/devtools-overlay.mjs')
44+
45+
fse.copyFileSync(overlayJsFile, overlayMjsFile)
46+
47+
// Browser extension keep using js file
4148
fse.copySync(
4249
overlayFile,
4350
resolve(__dirname, '../browser-extension/overlay'),
51+
{
52+
filter: (file) => {
53+
return !file.endsWith('.mjs')
54+
},
55+
},
4456
)
57+
58+
// Vite using mjs file to skip some commonjs -> es6 plugins
4559
fse.copySync(
4660
overlayFile,
4761
resolve(__dirname, '../vite/src/overlay'),
62+
{
63+
filter: (file) => {
64+
return !file.endsWith('.js')
65+
},
66+
},
4867
)
4968
},
5069
},

packages/playground/basic/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"vuex": "^4.1.0"
1818
},
1919
"devDependencies": {
20+
"@rollup/plugin-commonjs": "^25.0.8",
2021
"@tanstack/vue-query-devtools": "^5.38.0",
2122
"@vitejs/plugin-vue": "^5.0.4",
2223
"@vue/devtools": "workspace:^",

packages/playground/basic/vite.config.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
import { defineConfig } from 'vite'
22
import vue from '@vitejs/plugin-vue'
33
import VueDevTools from 'vite-plugin-vue-devtools'
4-
4+
import commonjs from '@rollup/plugin-commonjs'
55
import Unocss from 'unocss/vite'
66
import AutoImport from 'unplugin-auto-import/vite'
7+
import inspect from 'vite-plugin-inspect'
78

89
// https://vitejs.dev/config/
910
export default defineConfig({
1011
plugins: [
1112
vue(),
13+
commonjs(),
1214
VueDevTools({
1315
launchEditor: 'code',
1416
}),
@@ -20,6 +22,7 @@ export default defineConfig({
2022
'@vueuse/core',
2123
],
2224
}),
25+
inspect(),
2326
],
2427
server: {
2528
port: 3000,

packages/vite/src/overlay.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ link.href = `${overlayDir}/devtools-overlay.css`
4141

4242
// create script
4343
const script = document.createElement('script')
44-
script.src = `${overlayDir}/devtools-overlay.js`
44+
script.src = `${overlayDir}/devtools-overlay.mjs`
4545
script.type = 'module'
4646

4747
// append to head

pnpm-lock.yaml

Lines changed: 20 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)