Merge branch 'master' of github.com:vuejs/eslint-plugin-vue into feature/np-negated-condition

Author: waynzh

.changeset/beige-teams-camp.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-vue': minor
+---
+
+Added `ignoreParents` option to [`vue/no-deprecated-slot-attribute`](https://eslint.vuejs.org/rules/no-deprecated-slot-attribute.html)

.changeset/eight-camels-refuse.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-vue": patch
+---
+
+Resolved TypeScript compatibility issues introduced by eslint-typegen

.changeset/true-pumas-open.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-vue': minor
+---
+
+Added new [`vue/no-negated-condition`](https://eslint.vuejs.org/rules/no-negated-condition.html) rule

docs/rules/index.md

@@ -328,6 +328,7 @@ The following rules extend the rules provided by ESLint itself and apply them to
 | [vue/no-implicit-coercion] | Disallow shorthand type conversions in `<template>` | :wrench::bulb: | :hammer: |
 | [vue/no-irregular-whitespace] | disallow irregular whitespace in `.vue` files |  | :warning: |
 | [vue/no-loss-of-precision] | Disallow literal numbers that lose precision in `<template>` |  | :warning: |
+| [vue/no-negated-condition] | Disallow negated conditions in `<template>` |  | :hammer: |
 | [vue/no-restricted-syntax] | Disallow specified syntax in `<template>` |  | :hammer: |
 | [vue/no-sparse-arrays] | Disallow sparse arrays in `<template>` |  | :warning: |
 | [vue/no-useless-concat] | Disallow unnecessary concatenation of literals or template literals in `<template>` |  | :hammer: |
@@ -484,6 +485,7 @@ The following rules extend the rules provided by ESLint itself and apply them to
 [vue/no-multiple-template-root]: ./no-multiple-template-root.md
 [vue/no-mutating-props]: ./no-mutating-props.md
 [vue/no-negated-v-if-condition]: ./no-negated-v-if-condition.md
+[vue/no-negated-condition]: ./no-negated-condition.md
 [vue/no-parsing-error]: ./no-parsing-error.md
 [vue/no-potential-component-option-typo]: ./no-potential-component-option-typo.md
 [vue/no-ref-as-operand]: ./no-ref-as-operand.md

docs/rules/no-deprecated-slot-attribute.md

@@ -43,16 +43,18 @@ This rule reports deprecated `slot` attribute in Vue.js v2.6.0+.
 ```json
 {
   "vue/no-deprecated-slot-attribute": ["error", {
-    "ignore": ["my-component"]
+    "ignore": ["my-component"],
+    "ignoreParents": ["my-web-component"],
   }]
 }
 ```
 
 - `"ignore"` (`string[]`) An array of tags or regular expression patterns (e.g. `/^custom-/`) that ignore these rules. This option will check both kebab-case and PascalCase versions of the given tag names. Default is empty.
+- `"ignoreParents"` (`string[]`) An array of tags or regular expression patterns (e.g. `/^custom-/`) for parents that ignore these rules. This option is especially useful for [Web-Components](https://developer.mozilla.org/en-US/docs/Web/API/Web_components). Default is empty.
 
 ### `"ignore": ["my-component"]`
 
-<eslint-code-block fix :rules="{'vue/no-dupe-keys': ['error', {ignore: ['my-component']}]}">
+<eslint-code-block fix :rules="{'vue/no-deprecated-slot-attribute': ['error', {ignore: ['my-component']}]}">
 
 ```vue
 <template>
@@ -81,9 +83,41 @@ This rule reports deprecated `slot` attribute in Vue.js v2.6.0+.
 
 </eslint-code-block>
 
+### `"ignoreParents": ["my-web-component"]`
+
+<eslint-code-block fix :rules="{'vue/no-deprecated-slot-attribute': ['error', {ignoreParents: ['my-web-component']}]}">
+
+```vue
+<template>
+  <my-web-component>
+    <!-- ✓ GOOD -->
+    <template v-slot:name>
+      {{ props.title }}
+    </template>
+  </my-web-component>
+
+  <my-web-component>
+    <!-- ✓ GOOD -->
+    <my-component slot="name">
+      {{ props.title }}
+    </my-component>
+  </my-web-component>
+
+  <other-component>
+    <!-- ✗ BAD -->
+    <my-component slot="name">
+      {{ props.title }}
+    </my-component>
+  </other-component>
+</template>
+```
+
+</eslint-code-block>
+
 ## :books: Further Reading
 
 - [API - slot](https://v2.vuejs.org/v2/api/#slot-deprecated)
+- [Web - slot](https://developer.mozilla.org/en-US/docs/Web/API/Element/slot)
 
 ## :rocket: Version
 

docs/rules/no-negated-condition.md

@@ -0,0 +1,33 @@
+---
+pageClass: rule-details
+sidebarDepth: 0
+title: vue/no-negated-condition
+description: Disallow negated conditions in `<template>`
+---
+
+# vue/no-negated-condition
+
+> Disallow negated conditions in `<template>`
+
+- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> _**This rule has not been released yet.**_ </badge>
+
+## :book: Rule Details
+
+This rule is the same rule as core [no-negated-condition] rule but it applies to the expressions in `<template>`.
+
+## :couple: Related Rules
+
+- [unicorn/no-negated-condition](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-negated-condition.md)
+
+## :books: Further Reading
+
+- [no-negated-condition]
+
+[no-negated-condition]: https://eslint.org/docs/rules/no-negated-condition
+
+## :mag: Implementation
+
+- [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/no-negated-condition.js)
+- [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/no-negated-condition.js)
+
+<sup>Taken with ❤️ [from ESLint core](https://eslint.org/docs/latest/rules/no-negated-condition)</sup>

lib/index.js

@@ -142,6 +142,7 @@ const plugin = {
     'no-multiple-template-root': require('./rules/no-multiple-template-root'),
     'no-mutating-props': require('./rules/no-mutating-props'),
     'no-negated-v-if-condition': require('./rules/no-negated-v-if-condition'),
+    'no-negated-condition': require('./rules/no-negated-condition'),
     'no-parsing-error': require('./rules/no-parsing-error'),
     'no-potential-component-option-typo': require('./rules/no-potential-component-option-typo'),
     'no-ref-as-operand': require('./rules/no-ref-as-operand'),

lib/rules/no-deprecated-slot-attribute.js

@@ -25,6 +25,11 @@ module.exports = {
             type: 'array',
             items: { type: 'string' },
             uniqueItems: true
+          },
+          ignoreParents: {
+            type: 'array',
+            items: { type: 'string' },
+            uniqueItems: true
           }
         },
         additionalProperties: false

lib/rules/no-negated-condition.js

@@ -0,0 +1,12 @@
+/**
+ * @author Wayne Zhang
+ * See LICENSE file in root directory for full license.
+ */
+'use strict'
+
+const { wrapCoreRule } = require('../utils')
+
+// eslint-disable-next-line internal/no-invalid-meta
+module.exports = wrapCoreRule('no-negated-condition', {
+  applyDocument: true
+})

lib/rules/syntaxes/slot-attribute.js

@@ -7,16 +7,18 @@
 const canConvertToVSlot = require('./utils/can-convert-to-v-slot')
 const regexp = require('../../utils/regexp')
 const casing = require('../../utils/casing')
+const { isVElement } = require('../../utils')
 
 module.exports = {
   deprecated: '2.6.0',
   supported: '<3.0.0',
   /** @param {RuleContext} context @returns {TemplateListener} */
   createTemplateBodyVisitor(context) {
-    /** @type {{ ignore: string[] }} */
+    /** @type {{ ignore: string[], ignoreParents: string[] }} */
     const options = context.options[0] || {}
-    const { ignore = [] } = options
+    const { ignore = [], ignoreParents = [] } = options
     const isAnyIgnored = regexp.toRegExpGroupMatcher(ignore)
+    const isParentIgnored = regexp.toRegExpGroupMatcher(ignoreParents)
 
     const sourceCode = context.getSourceCode()
     const tokenStore =
@@ -123,7 +125,8 @@ module.exports = {
      * @returns {void}
      */
     function reportSlot(slotAttr) {
-      const componentName = slotAttr.parent.parent.rawName
+      const component = slotAttr.parent.parent
+      const componentName = component.rawName
 
       if (
         isAnyIgnored(
@@ -135,6 +138,12 @@ module.exports = {
         return
       }
 
+      const parent = component.parent
+      const parentName = isVElement(parent) ? parent.rawName : null
+      if (parentName && isParentIgnored(parentName)) {
+        return
+      }
+
       context.report({
         node: slotAttr.key,
         messageId: 'forbiddenSlotAttribute',