Skip to content

Commit 2929ceb

Browse files
G-RathG-Rath
committed
revert: don't use an env variable
Revert "feat: support using `error` instead of `warn` for rules in config" This reverts commit efb2832. Revert "feat: regenerate configs" This reverts commit a379d77. Revert "feat: only define variable if it is needed" This reverts commit be3db8d. Revert "feat: regenerate rules" This reverts commit 98888a6. Revert "docs: add note to user guide" This reverts commit 3dd94e3. Revert "fix: avoid unneeded blank line" This reverts commit d7990e9.
1 parent 1b8f18f commit 2929ceb

11 files changed

+137
-179
lines changed

‎docs/user-guide/index.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,6 @@ You can use the following configs by adding them to `eslint.config.js`.
7373

7474
:::warning Reporting rules
7575
By default, all rules from **base** and **essential** categories report ESLint errors. Other rules - because they're not covering potential bugs in the application - report warnings. What does it mean? By default - nothing, but if you want - you can set up a threshold and break the build after a certain amount of warnings, instead of any. More information [here](https://eslint.org/docs/user-guide/command-line-interface#handling-warnings).
76-
77-
Alternatively, you can set `process.env.VUE_ESLINT_ALWAYS_ERROR` to `true` in your configuration file to have `error` be used by all rules.
7876
:::
7977

8078
#### Specifying Globals (`eslint.config.js`)

‎lib/configs/flat/vue2-recommended.js

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,19 @@
66
'use strict'
77
const config = require('./vue2-strongly-recommended.js')
88

9-
const ruleLevel =
10-
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'
11-
129
module.exports = [
1310
...config,
1411
{
1512
name: 'vue/vue2-recommended/rules',
1613
rules: {
17-
'vue/attributes-order': ruleLevel,
18-
'vue/block-order': ruleLevel,
19-
'vue/no-lone-template': ruleLevel,
20-
'vue/no-multiple-slot-args': ruleLevel,
21-
'vue/no-required-prop-with-default': ruleLevel,
22-
'vue/no-v-html': ruleLevel,
23-
'vue/order-in-components': ruleLevel,
24-
'vue/this-in-template': ruleLevel
14+
'vue/attributes-order': 'warn',
15+
'vue/block-order': 'warn',
16+
'vue/no-lone-template': 'warn',
17+
'vue/no-multiple-slot-args': 'warn',
18+
'vue/no-required-prop-with-default': 'warn',
19+
'vue/no-v-html': 'warn',
20+
'vue/order-in-components': 'warn',
21+
'vue/this-in-template': 'warn'
2522
}
2623
}
2724
]

‎lib/configs/flat/vue2-strongly-recommended.js

Lines changed: 23 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -6,37 +6,34 @@
66
'use strict'
77
const config = require('./vue2-essential.js')
88

9-
const ruleLevel =
10-
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'
11-
129
module.exports = [
1310
...config,
1411
{
1512
name: 'vue/vue2-strongly-recommended/rules',
1613
rules: {
17-
'vue/attribute-hyphenation': ruleLevel,
18-
'vue/component-definition-name-casing': ruleLevel,
19-
'vue/first-attribute-linebreak': ruleLevel,
20-
'vue/html-closing-bracket-newline': ruleLevel,
21-
'vue/html-closing-bracket-spacing': ruleLevel,
22-
'vue/html-end-tags': ruleLevel,
23-
'vue/html-indent': ruleLevel,
24-
'vue/html-quotes': ruleLevel,
25-
'vue/html-self-closing': ruleLevel,
26-
'vue/max-attributes-per-line': ruleLevel,
27-
'vue/multiline-html-element-content-newline': ruleLevel,
28-
'vue/mustache-interpolation-spacing': ruleLevel,
29-
'vue/no-multi-spaces': ruleLevel,
30-
'vue/no-spaces-around-equal-signs-in-attribute': ruleLevel,
31-
'vue/no-template-shadow': ruleLevel,
32-
'vue/one-component-per-file': ruleLevel,
33-
'vue/prop-name-casing': ruleLevel,
34-
'vue/require-default-prop': ruleLevel,
35-
'vue/require-prop-types': ruleLevel,
36-
'vue/singleline-html-element-content-newline': ruleLevel,
37-
'vue/v-bind-style': ruleLevel,
38-
'vue/v-on-style': ruleLevel,
39-
'vue/v-slot-style': ruleLevel
14+
'vue/attribute-hyphenation': 'warn',
15+
'vue/component-definition-name-casing': 'warn',
16+
'vue/first-attribute-linebreak': 'warn',
17+
'vue/html-closing-bracket-newline': 'warn',
18+
'vue/html-closing-bracket-spacing': 'warn',
19+
'vue/html-end-tags': 'warn',
20+
'vue/html-indent': 'warn',
21+
'vue/html-quotes': 'warn',
22+
'vue/html-self-closing': 'warn',
23+
'vue/max-attributes-per-line': 'warn',
24+
'vue/multiline-html-element-content-newline': 'warn',
25+
'vue/mustache-interpolation-spacing': 'warn',
26+
'vue/no-multi-spaces': 'warn',
27+
'vue/no-spaces-around-equal-signs-in-attribute': 'warn',
28+
'vue/no-template-shadow': 'warn',
29+
'vue/one-component-per-file': 'warn',
30+
'vue/prop-name-casing': 'warn',
31+
'vue/require-default-prop': 'warn',
32+
'vue/require-prop-types': 'warn',
33+
'vue/singleline-html-element-content-newline': 'warn',
34+
'vue/v-bind-style': 'warn',
35+
'vue/v-on-style': 'warn',
36+
'vue/v-slot-style': 'warn'
4037
}
4138
}
4239
]

‎lib/configs/flat/vue3-recommended.js

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,19 @@
66
'use strict'
77
const config = require('./vue3-strongly-recommended.js')
88

9-
const ruleLevel =
10-
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'
11-
129
module.exports = [
1310
...config,
1411
{
1512
name: 'vue/recommended/rules',
1613
rules: {
17-
'vue/attributes-order': ruleLevel,
18-
'vue/block-order': ruleLevel,
19-
'vue/no-lone-template': ruleLevel,
20-
'vue/no-multiple-slot-args': ruleLevel,
21-
'vue/no-required-prop-with-default': ruleLevel,
22-
'vue/no-v-html': ruleLevel,
23-
'vue/order-in-components': ruleLevel,
24-
'vue/this-in-template': ruleLevel
14+
'vue/attributes-order': 'warn',
15+
'vue/block-order': 'warn',
16+
'vue/no-lone-template': 'warn',
17+
'vue/no-multiple-slot-args': 'warn',
18+
'vue/no-required-prop-with-default': 'warn',
19+
'vue/no-v-html': 'warn',
20+
'vue/order-in-components': 'warn',
21+
'vue/this-in-template': 'warn'
2522
}
2623
}
2724
]

‎lib/configs/flat/vue3-strongly-recommended.js

Lines changed: 25 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -6,45 +6,42 @@
66
'use strict'
77
const config = require('./vue3-essential.js')
88

9-
const ruleLevel =
10-
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'
11-
129
module.exports = [
1310
...config,
1411
{
1512
name: 'vue/strongly-recommended/rules',
1613
rules: {
17-
'vue/attribute-hyphenation': ruleLevel,
18-
'vue/component-definition-name-casing': ruleLevel,
19-
'vue/first-attribute-linebreak': ruleLevel,
20-
'vue/html-closing-bracket-newline': ruleLevel,
21-
'vue/html-closing-bracket-spacing': ruleLevel,
22-
'vue/html-end-tags': ruleLevel,
23-
'vue/html-indent': ruleLevel,
24-
'vue/html-quotes': ruleLevel,
25-
'vue/html-self-closing': ruleLevel,
26-
'vue/max-attributes-per-line': ruleLevel,
27-
'vue/multiline-html-element-content-newline': ruleLevel,
28-
'vue/mustache-interpolation-spacing': ruleLevel,
29-
'vue/no-multi-spaces': ruleLevel,
30-
'vue/no-spaces-around-equal-signs-in-attribute': ruleLevel,
31-
'vue/no-template-shadow': ruleLevel,
32-
'vue/one-component-per-file': ruleLevel,
33-
'vue/prop-name-casing': ruleLevel,
34-
'vue/require-default-prop': ruleLevel,
35-
'vue/require-explicit-emits': ruleLevel,
36-
'vue/require-prop-types': ruleLevel,
37-
'vue/singleline-html-element-content-newline': ruleLevel,
38-
'vue/v-bind-style': ruleLevel,
14+
'vue/attribute-hyphenation': 'warn',
15+
'vue/component-definition-name-casing': 'warn',
16+
'vue/first-attribute-linebreak': 'warn',
17+
'vue/html-closing-bracket-newline': 'warn',
18+
'vue/html-closing-bracket-spacing': 'warn',
19+
'vue/html-end-tags': 'warn',
20+
'vue/html-indent': 'warn',
21+
'vue/html-quotes': 'warn',
22+
'vue/html-self-closing': 'warn',
23+
'vue/max-attributes-per-line': 'warn',
24+
'vue/multiline-html-element-content-newline': 'warn',
25+
'vue/mustache-interpolation-spacing': 'warn',
26+
'vue/no-multi-spaces': 'warn',
27+
'vue/no-spaces-around-equal-signs-in-attribute': 'warn',
28+
'vue/no-template-shadow': 'warn',
29+
'vue/one-component-per-file': 'warn',
30+
'vue/prop-name-casing': 'warn',
31+
'vue/require-default-prop': 'warn',
32+
'vue/require-explicit-emits': 'warn',
33+
'vue/require-prop-types': 'warn',
34+
'vue/singleline-html-element-content-newline': 'warn',
35+
'vue/v-bind-style': 'warn',
3936
'vue/v-on-event-hyphenation': [
40-
ruleLevel,
37+
'warn',
4138
'always',
4239
{
4340
autofix: true
4441
}
4542
],
46-
'vue/v-on-style': ruleLevel,
47-
'vue/v-slot-style': ruleLevel
43+
'vue/v-on-style': 'warn',
44+
'vue/v-slot-style': 'warn'
4845
}
4946
}
5047
]

‎lib/configs/vue2-recommended.js

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,16 @@
33
* This file has been automatically generated,
44
* in order to update its content execute "npm run update"
55
*/
6-
const ruleLevel =
7-
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'
8-
96
module.exports = {
107
extends: require.resolve('./vue2-strongly-recommended'),
118
rules: {
12-
'vue/attributes-order': ruleLevel,
13-
'vue/block-order': ruleLevel,
14-
'vue/no-lone-template': ruleLevel,
15-
'vue/no-multiple-slot-args': ruleLevel,
16-
'vue/no-required-prop-with-default': ruleLevel,
17-
'vue/no-v-html': ruleLevel,
18-
'vue/order-in-components': ruleLevel,
19-
'vue/this-in-template': ruleLevel
9+
'vue/attributes-order': 'warn',
10+
'vue/block-order': 'warn',
11+
'vue/no-lone-template': 'warn',
12+
'vue/no-multiple-slot-args': 'warn',
13+
'vue/no-required-prop-with-default': 'warn',
14+
'vue/no-v-html': 'warn',
15+
'vue/order-in-components': 'warn',
16+
'vue/this-in-template': 'warn'
2017
}
2118
}

‎lib/configs/vue2-strongly-recommended.js

Lines changed: 23 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -3,34 +3,31 @@
33
* This file has been automatically generated,
44
* in order to update its content execute "npm run update"
55
*/
6-
const ruleLevel =
7-
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'
8-
96
module.exports = {
107
extends: require.resolve('./vue2-essential'),
118
rules: {
12-
'vue/attribute-hyphenation': ruleLevel,
13-
'vue/component-definition-name-casing': ruleLevel,
14-
'vue/first-attribute-linebreak': ruleLevel,
15-
'vue/html-closing-bracket-newline': ruleLevel,
16-
'vue/html-closing-bracket-spacing': ruleLevel,
17-
'vue/html-end-tags': ruleLevel,
18-
'vue/html-indent': ruleLevel,
19-
'vue/html-quotes': ruleLevel,
20-
'vue/html-self-closing': ruleLevel,
21-
'vue/max-attributes-per-line': ruleLevel,
22-
'vue/multiline-html-element-content-newline': ruleLevel,
23-
'vue/mustache-interpolation-spacing': ruleLevel,
24-
'vue/no-multi-spaces': ruleLevel,
25-
'vue/no-spaces-around-equal-signs-in-attribute': ruleLevel,
26-
'vue/no-template-shadow': ruleLevel,
27-
'vue/one-component-per-file': ruleLevel,
28-
'vue/prop-name-casing': ruleLevel,
29-
'vue/require-default-prop': ruleLevel,
30-
'vue/require-prop-types': ruleLevel,
31-
'vue/singleline-html-element-content-newline': ruleLevel,
32-
'vue/v-bind-style': ruleLevel,
33-
'vue/v-on-style': ruleLevel,
34-
'vue/v-slot-style': ruleLevel
9+
'vue/attribute-hyphenation': 'warn',
10+
'vue/component-definition-name-casing': 'warn',
11+
'vue/first-attribute-linebreak': 'warn',
12+
'vue/html-closing-bracket-newline': 'warn',
13+
'vue/html-closing-bracket-spacing': 'warn',
14+
'vue/html-end-tags': 'warn',
15+
'vue/html-indent': 'warn',
16+
'vue/html-quotes': 'warn',
17+
'vue/html-self-closing': 'warn',
18+
'vue/max-attributes-per-line': 'warn',
19+
'vue/multiline-html-element-content-newline': 'warn',
20+
'vue/mustache-interpolation-spacing': 'warn',
21+
'vue/no-multi-spaces': 'warn',
22+
'vue/no-spaces-around-equal-signs-in-attribute': 'warn',
23+
'vue/no-template-shadow': 'warn',
24+
'vue/one-component-per-file': 'warn',
25+
'vue/prop-name-casing': 'warn',
26+
'vue/require-default-prop': 'warn',
27+
'vue/require-prop-types': 'warn',
28+
'vue/singleline-html-element-content-newline': 'warn',
29+
'vue/v-bind-style': 'warn',
30+
'vue/v-on-style': 'warn',
31+
'vue/v-slot-style': 'warn'
3532
}
3633
}

‎lib/configs/vue3-recommended.js

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,16 @@
33
* This file has been automatically generated,
44
* in order to update its content execute "npm run update"
55
*/
6-
const ruleLevel =
7-
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'
8-
96
module.exports = {
107
extends: require.resolve('./vue3-strongly-recommended'),
118
rules: {
12-
'vue/attributes-order': ruleLevel,
13-
'vue/block-order': ruleLevel,
14-
'vue/no-lone-template': ruleLevel,
15-
'vue/no-multiple-slot-args': ruleLevel,
16-
'vue/no-required-prop-with-default': ruleLevel,
17-
'vue/no-v-html': ruleLevel,
18-
'vue/order-in-components': ruleLevel,
19-
'vue/this-in-template': ruleLevel
9+
'vue/attributes-order': 'warn',
10+
'vue/block-order': 'warn',
11+
'vue/no-lone-template': 'warn',
12+
'vue/no-multiple-slot-args': 'warn',
13+
'vue/no-required-prop-with-default': 'warn',
14+
'vue/no-v-html': 'warn',
15+
'vue/order-in-components': 'warn',
16+
'vue/this-in-template': 'warn'
2017
}
2118
}

‎lib/configs/vue3-strongly-recommended.js

Lines changed: 25 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -3,42 +3,39 @@
33
* This file has been automatically generated,
44
* in order to update its content execute "npm run update"
55
*/
6-
const ruleLevel =
7-
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'
8-
96
module.exports = {
107
extends: require.resolve('./vue3-essential'),
118
rules: {
12-
'vue/attribute-hyphenation': ruleLevel,
13-
'vue/component-definition-name-casing': ruleLevel,
14-
'vue/first-attribute-linebreak': ruleLevel,
15-
'vue/html-closing-bracket-newline': ruleLevel,
16-
'vue/html-closing-bracket-spacing': ruleLevel,
17-
'vue/html-end-tags': ruleLevel,
18-
'vue/html-indent': ruleLevel,
19-
'vue/html-quotes': ruleLevel,
20-
'vue/html-self-closing': ruleLevel,
21-
'vue/max-attributes-per-line': ruleLevel,
22-
'vue/multiline-html-element-content-newline': ruleLevel,
23-
'vue/mustache-interpolation-spacing': ruleLevel,
24-
'vue/no-multi-spaces': ruleLevel,
25-
'vue/no-spaces-around-equal-signs-in-attribute': ruleLevel,
26-
'vue/no-template-shadow': ruleLevel,
27-
'vue/one-component-per-file': ruleLevel,
28-
'vue/prop-name-casing': ruleLevel,
29-
'vue/require-default-prop': ruleLevel,
30-
'vue/require-explicit-emits': ruleLevel,
31-
'vue/require-prop-types': ruleLevel,
32-
'vue/singleline-html-element-content-newline': ruleLevel,
33-
'vue/v-bind-style': ruleLevel,
9+
'vue/attribute-hyphenation': 'warn',
10+
'vue/component-definition-name-casing': 'warn',
11+
'vue/first-attribute-linebreak': 'warn',
12+
'vue/html-closing-bracket-newline': 'warn',
13+
'vue/html-closing-bracket-spacing': 'warn',
14+
'vue/html-end-tags': 'warn',
15+
'vue/html-indent': 'warn',
16+
'vue/html-quotes': 'warn',
17+
'vue/html-self-closing': 'warn',
18+
'vue/max-attributes-per-line': 'warn',
19+
'vue/multiline-html-element-content-newline': 'warn',
20+
'vue/mustache-interpolation-spacing': 'warn',
21+
'vue/no-multi-spaces': 'warn',
22+
'vue/no-spaces-around-equal-signs-in-attribute': 'warn',
23+
'vue/no-template-shadow': 'warn',
24+
'vue/one-component-per-file': 'warn',
25+
'vue/prop-name-casing': 'warn',
26+
'vue/require-default-prop': 'warn',
27+
'vue/require-explicit-emits': 'warn',
28+
'vue/require-prop-types': 'warn',
29+
'vue/singleline-html-element-content-newline': 'warn',
30+
'vue/v-bind-style': 'warn',
3431
'vue/v-on-event-hyphenation': [
35-
ruleLevel,
32+
'warn',
3633
'always',
3734
{
3835
autofix: true
3936
}
4037
],
41-
'vue/v-on-style': ruleLevel,
42-
'vue/v-slot-style': ruleLevel
38+
'vue/v-on-style': 'warn',
39+
'vue/v-slot-style': 'warn'
4340
}
4441
}

0 commit comments

Comments
 (0)