feat: improve messages and accurate loc

Author: ItMaga

lib/rules/require-default-export.js

@@ -17,7 +17,8 @@ module.exports = {
     fixable: null,
     schema: [],
     messages: {
-      mustDefaultExport: 'The component must be the default export.'
+      missing: 'Missing default export.',
+      mustBeDefaultExport: 'Component must be the default export.'
     }
   },
   /** @param {RuleContext} context */
@@ -36,23 +37,32 @@ module.exports = {
     }
 
     let hasDefaultExport = false
+    let hasDefinedComponent = false
 
-    return {
-      'Program > ExportDefaultDeclaration'() {
-        hasDefaultExport = true
-      },
-
-      /**
-       * @param {Program} node
-       */
-      'Program:exit'(node) {
-        if (!hasDefaultExport && node.body.length > 0) {
-          context.report({
-            loc: { line: 1, column: 0 },
-            messageId: 'mustDefaultExport'
-          })
+    return utils.compositingVisitors(
+      utils.defineVueVisitor(context, {
+        onVueObjectExit() {
+          hasDefinedComponent = true
+        }
+      }),
+
+      {
+        'Program > ExportDefaultDeclaration'() {
+          hasDefaultExport = true
+        },
+
+        /**
+         * @param {Program} node
+         */
+        'Program:exit'(node) {
+          if (!hasDefaultExport && node.body.length > 0) {
+            context.report({
+              loc: node.tokens[node.tokens.length - 1].loc,
+              messageId: hasDefinedComponent ? 'mustBeDefaultExport' : 'missing'
+            })
+          }
         }
       }
-    }
+    )
   }
 }

tests/lib/rules/require-default-export.js

@@ -86,8 +86,11 @@ tester.run('require-default-export', rule, {
       `,
       errors: [
         {
-          messageId: 'mustDefaultExport',
-          line: 1
+          messageId: 'missing',
+          line: 4,
+          endLine: 4,
+          column: 7,
+          endColumn: 16
         }
       ]
     },
@@ -100,8 +103,11 @@ tester.run('require-default-export', rule, {
       `,
       errors: [
         {
-          messageId: 'mustDefaultExport',
-          line: 1
+          messageId: 'missing',
+          line: 4,
+          endLine: 4,
+          column: 7,
+          endColumn: 16
         }
       ]
     },
@@ -116,8 +122,11 @@ tester.run('require-default-export', rule, {
       `,
       errors: [
         {
-          messageId: 'mustDefaultExport',
-          line: 1
+          messageId: 'missing',
+          line: 6,
+          endLine: 6,
+          column: 7,
+          endColumn: 16
         }
       ]
     },
@@ -131,8 +140,11 @@ tester.run('require-default-export', rule, {
       `,
       errors: [
         {
-          messageId: 'mustDefaultExport',
-          line: 1
+          messageId: 'missing',
+          line: 5,
+          endLine: 5,
+          column: 7,
+          endColumn: 16
         }
       ]
     },
@@ -147,8 +159,30 @@ tester.run('require-default-export', rule, {
       `,
       errors: [
         {
-          messageId: 'mustDefaultExport',
-          line: 1
+          messageId: 'mustBeDefaultExport',
+          line: 6,
+          endLine: 6,
+          column: 7,
+          endColumn: 16
+        }
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      import Vue from 'vue';
+
+      const component = Vue.component('foo', {});
+      </script>
+      `,
+      errors: [
+        {
+          messageId: 'mustBeDefaultExport',
+          line: 6,
+          endLine: 6,
+          column: 7,
+          endColumn: 16
         }
       ]
     }