Simplify no-invalid-meta internal rule

Author: FloEdelmann

eslint-internal-rules/no-invalid-meta.js

@@ -23,38 +23,6 @@ function getPropertyFromObject(propertyName, node) {
   return null
 }
 
-/**
- * Extracts the `meta` property from the ObjectExpression that all rules export.
- *
- * @param {ASTNode} exportsNode ObjectExpression node that the rule exports.
- * @returns {ASTNode} The `meta` Property node or null if not found.
- */
-function getMetaPropertyFromExportsNode(exportsNode) {
-  return getPropertyFromObject('meta', exportsNode)
-}
-
-/**
- * Whether this `meta` ObjectExpression has a `docs` property defined or not.
- *
- * @param {ASTNode} metaPropertyNode The `meta` ObjectExpression for this rule.
- * @returns {boolean} `true` if a `docs` property exists.
- */
-function hasMetaDocs(metaPropertyNode) {
-  return Boolean(getPropertyFromObject('docs', metaPropertyNode.value))
-}
-
-/**
- * Whether this `meta` ObjectExpression has a `docs.category` property defined or not.
- *
- * @param {ASTNode} metaPropertyNode The `meta` ObjectExpression for this rule.
- * @returns {boolean} `true` if a `docs.category` property exists.
- */
-function hasMetaDocsCategories(metaPropertyNode) {
-  const metaDocs = getPropertyFromObject('docs', metaPropertyNode.value)
-
-  return metaDocs && getPropertyFromObject('categories', metaDocs.value)
-}
-
 /**
  * Checks the validity of the meta definition of this rule and reports any errors found.
  *
@@ -64,8 +32,7 @@ function hasMetaDocsCategories(metaPropertyNode) {
  * @returns {void}
  */
 function checkMetaValidity(context, exportsNode) {
-  const metaProperty = getMetaPropertyFromExportsNode(exportsNode)
-
+  const metaProperty = getPropertyFromObject('meta', exportsNode)
   if (!metaProperty) {
     context.report({
       node: exportsNode,
@@ -74,15 +41,17 @@ function checkMetaValidity(context, exportsNode) {
     return
   }
 
-  if (!hasMetaDocs(metaProperty)) {
+  const metaDocs = getPropertyFromObject('docs', metaProperty.value)
+  if (!metaDocs) {
     context.report({
-      node: 'metaDocs',
+      node: metaProperty,
       messageId: 'missingMetaDocs'
     })
     return
   }
 
-  if (!hasMetaDocsCategories(metaProperty)) {
+  const metaDocsCategories = getPropertyFromObject('categories', metaDocs.value)
+  if (!metaDocsCategories) {
     context.report({
       node: metaProperty,
       messageId: 'missingMetaDocsCategories'