refactor to return early

Author: felipemelendez

lib/rules/v-if-else-key.js

@@ -67,35 +67,39 @@ const checkForKey = (
   conditionalFamilies
 ) => {
   if (
-    node.parent &&
-    node.parent.type === 'VElement' &&
-    hasConditionalRenderedSiblings(node, componentName)
+    !node.parent ||
+    node.parent.type !== 'VElement' ||
+    !hasConditionalRenderedSiblings(node, componentName)
   ) {
-    const conditionalFamily = conditionalFamilies.get(node.parent)
+    return
+  }
 
-    if (conditionalFamily && !utils.hasAttribute(node, 'key')) {
-      const needsKey =
-        conditionalFamily.if === node ||
-        conditionalFamily.else === node ||
-        conditionalFamily.elseIf.includes(node)
+  const conditionalFamily = conditionalFamilies.get(node.parent)
 
-      if (needsKey) {
-        context.report({
-          node: node.startTag,
-          loc: node.startTag.loc,
-          messageId: 'requireKey',
-          data: { componentName },
-          fix(fixer) {
-            const afterComponentNamePosition =
-              node.startTag.range[0] + componentName.length + 1
-            return fixer.insertTextBeforeRange(
-              [afterComponentNamePosition, afterComponentNamePosition],
-              ` key="${uniqueKey}"`
-            )
-          }
-        })
+  if (!conditionalFamily || utils.hasAttribute(node, 'key')) {
+    return
+  }
+
+  const needsKey =
+    conditionalFamily.if === node ||
+    conditionalFamily.else === node ||
+    conditionalFamily.elseIf.includes(node)
+
+  if (needsKey) {
+    context.report({
+      node: node.startTag,
+      loc: node.startTag.loc,
+      messageId: 'requireKey',
+      data: { componentName },
+      fix(fixer) {
+        const afterComponentNamePosition =
+          node.startTag.range[0] + componentName.length + 1
+        return fixer.insertTextBeforeRange(
+          [afterComponentNamePosition, afterComponentNamePosition],
+          ` key="${uniqueKey}"`
+        )
       }
-    }
+    })
   }
 }