Bad practice in cart example?

[hokkaido]

I think this example propagates some questionable practices, since getters are used to derive computed values and here they mutate the state as well, as far as I can see.

https://en.wikipedia.org/wiki/Command%E2%80%93query_separation

pinia/packages/playground/src/stores/cart.ts

Lines 9 to 22 in 08bd464

	getters: {
	items: (state) =>
	state.rawItems.reduce((items, item) => {
	const existingItem = items.find((it) => it.name === item)
	if (!existingItem) {
	items.push({ name: item, amount: 1 })
	} else {
	existingItem.amount++
	}
	return items
	}, [] as Array<{ name: string; amount: number }>),
	},

[posva]

that example doesn't mutate the state, items is a local variable

[hokkaido]

My bad, I need a new pair of eyes it seems.