Skip to content

Commit 2d79fe7

Browse files
committed
refactor: move old dynamic new matcher
kept because it will be fixed and shiped at some point
1 parent aff2165 commit 2d79fe7

File tree

6 files changed

+25
-26
lines changed

6 files changed

+25
-26
lines changed

packages/router/src/experimental/route-resolver/matcher-resolve.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ import { mockWarn } from '../../../__tests__/vitest-mock-warn'
66
import {
77
type MatcherLocationRaw,
88
type ResolverLocationResolved,
9-
type NEW_MatcherRecord,
109
NO_MATCH_LOCATION,
1110
} from './resolver-abstract'
12-
import { type NEW_MatcherRecordRaw } from './resolver-dynamic'
13-
import { createCompiledMatcher } from './resolver-dynamic'
11+
import { type NEW_MatcherRecord } from './old/resolver-dynamic'
12+
import { type NEW_MatcherRecordRaw } from './old/resolver-dynamic'
13+
import { createCompiledMatcher } from './old/resolver-dynamic'
1414
import { miss } from './matchers/errors'
1515
import {
1616
MatcherPatternPath,

packages/router/src/experimental/route-resolver/matchers/test-utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {
44
MatcherPatternQuery,
55
MatcherPatternHash,
66
} from './matcher-pattern'
7-
import { NEW_MatcherRecord } from '../resolver-abstract'
7+
import { NEW_MatcherRecord } from '../old/resolver-dynamic'
88
import { invalid, miss } from './errors'
99

1010
export const ANY_PATH_PATTERN_MATCHER: MatcherPatternPath<{

packages/router/src/experimental/route-resolver/resolver.spec.ts renamed to packages/router/src/experimental/route-resolver/old/resolver-dynamic.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { describe, expect, it } from 'vitest'
2-
import { NO_MATCH_LOCATION, pathEncoded } from './resolver-abstract'
2+
import { NO_MATCH_LOCATION, pathEncoded } from '../resolver-abstract'
33
import { createCompiledMatcher } from './resolver-dynamic'
44
import {
55
MatcherPatternQuery,
66
MatcherPatternPathStatic,
77
MatcherPatternPathDynamic,
8-
} from './matchers/matcher-pattern'
8+
} from '../matchers/matcher-pattern'
99
import {
1010
EMPTY_PATH_ROUTE,
1111
USER_ID_ROUTE,
@@ -14,7 +14,7 @@ import {
1414
EMPTY_PATH_PATTERN_MATCHER,
1515
USER_ID_PATH_PATTERN_MATCHER,
1616
ANY_HASH_PATTERN_MATCHER,
17-
} from './matchers/test-utils'
17+
} from '../matchers/test-utils'
1818

1919
const PAGE_QUERY_PATTERN_MATCHER: MatcherPatternQuery<{ page: number }> = {
2020
match: query => {

packages/router/src/experimental/route-resolver/resolver.test-d.ts renamed to packages/router/src/experimental/route-resolver/old/resolver-dynamic.test-d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { describe, expectTypeOf, it } from 'vitest'
2-
import { ResolverLocationResolved } from './resolver-abstract'
2+
import { ResolverLocationResolved } from '../resolver-abstract'
33
import { NEW_MatcherRecordRaw } from './resolver-dynamic'
44
import { NEW_RouterResolver } from './resolver-dynamic'
5-
import { EXPERIMENTAL_RouteRecordNormalized } from '../router'
5+
import { EXPERIMENTAL_RouteRecordNormalized } from '../../router'
66

77
describe('Matcher', () => {
88
type TMatcherRecordRaw = NEW_MatcherRecordRaw

packages/router/src/experimental/route-resolver/resolver-dynamic.ts renamed to packages/router/src/experimental/route-resolver/old/resolver-dynamic.ts

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,27 +3,27 @@ import {
33
LocationNormalized,
44
parseURL,
55
resolveRelativePath,
6-
} from '../../location'
7-
import { normalizeQuery, stringifyQuery, parseQuery } from '../../query'
8-
import type { MatcherParamsFormatted } from './matchers/matcher-pattern'
9-
import type { ResolverLocationAsRelative } from './resolver-abstract'
10-
import type { ResolverLocationAsPathAbsolute } from './resolver-abstract'
11-
import type { ResolverLocationAsPathRelative } from './resolver-abstract'
12-
import type { ResolverLocationAsNamed } from './resolver-abstract'
6+
} from '../../../location'
7+
import { normalizeQuery, stringifyQuery, parseQuery } from '../../../query'
8+
import type { MatcherParamsFormatted } from '../matchers/matcher-pattern'
9+
import type { ResolverLocationAsRelative } from '../resolver-abstract'
10+
import type { ResolverLocationAsPathAbsolute } from '../resolver-abstract'
11+
import type { ResolverLocationAsPathRelative } from '../resolver-abstract'
12+
import type { ResolverLocationAsNamed } from '../resolver-abstract'
1313
import {
1414
MatcherQueryParams,
1515
EXPERIMENTAL_Resolver_Base,
1616
NO_MATCH_LOCATION,
1717
RecordName,
1818
ResolverLocationResolved,
19-
} from './resolver-abstract'
20-
import { comparePathParserScore } from '../../matcher/pathParserRanker'
21-
import { warn } from '../../warning'
19+
} from '../resolver-abstract'
20+
import { comparePathParserScore } from '../../../matcher/pathParserRanker'
21+
import { warn } from '../../../warning'
2222
import type {
2323
MatcherPatternPath,
2424
MatcherPatternQuery,
2525
MatcherPatternHash,
26-
} from './matchers/matcher-pattern'
26+
} from '../matchers/matcher-pattern'
2727

2828
/**
2929
* Manage and resolve routes. Also handles the encoding, decoding, parsing and
@@ -468,3 +468,8 @@ export interface NEW_MatcherRecordRaw {
468468

469469
score: Array<number[]>
470470
}
471+
472+
/**
473+
* Normalized version of a {@link NEW_MatcherRecordRaw} record.
474+
*/
475+
export interface NEW_MatcherRecord extends NEW_MatcherDynamicRecord {}

packages/router/src/experimental/route-resolver/resolver-abstract.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import {
66
} from '../../encoding'
77
import type { MatcherParamsFormatted } from './matchers/matcher-pattern'
88
import type { _RouteRecordProps } from '../../typed-routes'
9-
import type { NEW_MatcherDynamicRecord } from './resolver-dynamic'
109
import type { LocationNormalized } from '../../location'
1110

1211
/**
@@ -207,11 +206,6 @@ export const NO_MATCH_LOCATION = {
207206
matched: [],
208207
} satisfies Omit<ResolverLocationResolved<never>, keyof LocationNormalized>
209208

210-
/**
211-
* Normalized version of a {@link NEW_MatcherRecordRaw} record.
212-
*/
213-
export interface NEW_MatcherRecord extends NEW_MatcherDynamicRecord {}
214-
215209
// FIXME: move somewhere else
216210
/**
217211
* Tagged template helper to encode params into a path. Doesn't work with null

0 commit comments

Comments
 (0)