Skip to content

Commit dbd0bc6

Browse files
committed
chore: note about beforeunload
1 parent 72f84f1 commit dbd0bc6

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

packages/router/src/history/html5.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,11 @@ function useHistoryListeners(
144144

145145
// set up the listeners and prepare teardown callbacks
146146
window.addEventListener('popstate', popStateHandler)
147-
window.addEventListener('beforeunload', beforeUnloadListener)
147+
// TODO: could we use 'pagehide' or 'visibilitychange' instead?
148+
// https://developer.chrome.com/blog/page-lifecycle-api/
149+
window.addEventListener('beforeunload', beforeUnloadListener, {
150+
passive: true,
151+
})
148152

149153
return {
150154
pauseListeners,

0 commit comments

Comments
 (0)