Skip to content

Commit 00d8f1c

Browse files
lmiller1990lmiller1990
authored
Merge pull request #198 from vuejs/warning-and-bump-to-rc10
fix: swallow warning for emitted events and bump to rc10
2 parents 02276e2 + 29e6baa commit 00d8f1c

File tree

3 files changed

+71
-79
lines changed

3 files changed

+71
-79
lines changed

‎package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"@types/estree": "^0.0.42",
2424
"@types/jest": "^24.9.1",
2525
"@types/node": "12.12.35",
26-
"@vue/compiler-sfc": "^3.0.0-rc.5",
26+
"@vue/compiler-sfc": "^3.0.0-rc.10",
2727
"babel-jest": "^25.2.3",
2828
"babel-preset-jest": "^25.2.1",
2929
"dom-event-types": "^1.0.0",
@@ -38,7 +38,7 @@
3838
"ts-jest": "^25.0.0",
3939
"tsd": "0.11.0",
4040
"typescript": "^3.7.5",
41-
"vue": "^3.0.0-rc.7",
41+
"vue": "^3.0.0-rc.10",
4242
"vue-jest": "vuejs/vue-jest#next",
4343
"vue-router": "^4.0.0-alpha.14",
4444
"vuex": "^4.0.0-beta.1"

‎src/emitMixin.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,23 @@ export const attachEmitListener = () => {
1010
events[event]
1111
? (events[event] = [...events[event], [...args]])
1212
: (events[event] = [[...args]])
13+
14+
// Vue will warn you if you emit an event that is not declared in `emits` and
15+
// if the parent is not listening for that event.
16+
// since we intercept the event, we are never listening for it explicitly on the
17+
// Parent component. Swallow those events then restore the console.warn.
18+
// TODO: find out if this is doable using `app.config.warnHandler` (does not appear
19+
// work right now). https://github.com/vuejs/vue-test-utils-next/issues/197
20+
const consoleWarnSave = console.warn
21+
console.warn = (msg: string, ...rest: unknown[]) => {
22+
if (msg.includes('[Vue warn]: Component emitted event')) {
23+
return
24+
} else {
25+
consoleWarnSave(msg, ...rest)
26+
}
27+
}
1328
originalEmit(event, ...args)
29+
console.warn = consoleWarnSave
1430
return [event, ...args]
1531
}
1632
}

‎yarn.lock‎

Lines changed: 53 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -1207,55 +1207,36 @@
12071207
dependencies:
12081208
"@types/yargs-parser" "*"
12091209

1210-
"@vue/[email protected].5":
1211-
version "3.0.0-rc.5"
1212-
resolved "https://registry.yarnpkg.com/@vue/compiler-core/-/compiler-core-3.0.0-rc.5.tgz#dd4f1816fcae34a81bc60e584f97993cad284d54"
1213-
integrity sha512-dNz5AObEYg0Oglw3emIsBhTAOVfObrfxDaAzR0UTRDDq+Ohfr6KTSaVQAH88Ym+oa08ZlLZBFc6ARe9doAOIxg==
1210+
"@vue/[email protected].10":
1211+
version "3.0.0-rc.10"
1212+
resolved "https://registry.yarnpkg.com/@vue/compiler-core/-/compiler-core-3.0.0-rc.10.tgz#a76f713fb0462429ec0ec10a472fff1f539c5772"
1213+
integrity sha512-kQzHzRsM0NPAWHeqSTb2J4VsHhjRkGeLTsGzeMnW+sojgTnS3T94KacwvYgVS4qeZAKiDq0bMNZoJWrHVQ3T8g==
12141214
dependencies:
12151215
"@babel/parser" "^7.10.4"
12161216
"@babel/types" "^7.10.4"
1217-
"@vue/shared" "3.0.0-rc.5"
1217+
"@vue/shared" "3.0.0-rc.10"
12181218
estree-walker "^2.0.1"
12191219
source-map "^0.6.1"
12201220

1221-
"@vue/compiler-core@3.0.0-rc.7":
1222-
version "3.0.0-rc.7"
1223-
resolved "https://registry.yarnpkg.com/@vue/compiler-core/-/compiler-core-3.0.0-rc.7.tgz#119f669ee59c96124c280a6e94187f3bad09ea8a"
1224-
integrity sha512-bzk7uGKPEAKC4XHnHvmMUui9MASOVK7e4xgDz6oOBWqo1mnvqk1YnNZzY+0XMaCr4PFOFqHw739JmzJb6SBqUg==
1221+
"@vue/compiler-dom@3.0.0-rc.10":
1222+
version "3.0.0-rc.10"
1223+
resolved "https://registry.yarnpkg.com/@vue/compiler-dom/-/compiler-dom-3.0.0-rc.10.tgz#dd1380d1ee61170de76f9eb91e0d8ac7985f0ae0"
1224+
integrity sha512-pqIUf5leZm0P9379utrRSVBMxhV8XaqJTEFFp5etCtbEa/H5ALs29EjFMtMcm9sQaVkZlKLu86mgIacbYB9Q3w==
12251225
dependencies:
1226-
"@babel/parser" "^7.10.4"
1227-
"@babel/types" "^7.10.4"
1228-
"@vue/shared" "3.0.0-rc.7"
1229-
estree-walker "^2.0.1"
1230-
source-map "^0.6.1"
1226+
"@vue/compiler-core" "3.0.0-rc.10"
1227+
"@vue/shared" "3.0.0-rc.10"
12311228

1232-
"@vue/[email protected]":
1233-
version "3.0.0-rc.5"
1234-
resolved "https://registry.yarnpkg.com/@vue/compiler-dom/-/compiler-dom-3.0.0-rc.5.tgz#83905e8601123a3654b90fbd80708a16530ce21a"
1235-
integrity sha512-z8n+R1GhFnWuKURLYxfVSEfP7nSNM91qteobxwys55fhlZZuReouMnUwgrn+ois/IL6RdFlT9H+n4+N6yLrdJA==
1236-
dependencies:
1237-
"@vue/compiler-core" "3.0.0-rc.5"
1238-
"@vue/shared" "3.0.0-rc.5"
1239-
1240-
"@vue/[email protected]":
1241-
version "3.0.0-rc.7"
1242-
resolved "https://registry.yarnpkg.com/@vue/compiler-dom/-/compiler-dom-3.0.0-rc.7.tgz#0e193767243485db314495e17d8fd56370b628e1"
1243-
integrity sha512-wE8YmkN3ISodjijzG44YiRgbcb7skqdRbhoYgABGz8uHvNSMGPLrM80cRosgLoGlcgxDPxj0xaEAczBunJYV2g==
1244-
dependencies:
1245-
"@vue/compiler-core" "3.0.0-rc.7"
1246-
"@vue/shared" "3.0.0-rc.7"
1247-
1248-
"@vue/compiler-sfc@^3.0.0-rc.5":
1249-
version "3.0.0-rc.5"
1250-
resolved "https://registry.yarnpkg.com/@vue/compiler-sfc/-/compiler-sfc-3.0.0-rc.5.tgz#374e52a6fbf8fb9aee1213026050a0f1c496fecf"
1251-
integrity sha512-huoIFEfFCJxHcpoByAUQti7CIwJdHPLJXKuy2HG7J1B+IEKugtBdF50CLH35ZD8dWM0nyOMFFqTbO7i6CCjL3Q==
1229+
"@vue/compiler-sfc@^3.0.0-rc.10":
1230+
version "3.0.0-rc.10"
1231+
resolved "https://registry.yarnpkg.com/@vue/compiler-sfc/-/compiler-sfc-3.0.0-rc.10.tgz#4351ece66cdf4d758877482f69421c43d994dbaf"
1232+
integrity sha512-VIJ+VXqeM7WoRNgD9uYSARVb6CYq+JS2NNHfeerfNc7Uk3pjYHRv1MwEicAvN6zWFm5GLC1ZYTVD+WFg3xGAkQ==
12521233
dependencies:
12531234
"@babel/parser" "^7.10.4"
12541235
"@babel/types" "^7.10.4"
1255-
"@vue/compiler-core" "3.0.0-rc.5"
1256-
"@vue/compiler-dom" "3.0.0-rc.5"
1257-
"@vue/compiler-ssr" "3.0.0-rc.5"
1258-
"@vue/shared" "3.0.0-rc.5"
1236+
"@vue/compiler-core" "3.0.0-rc.10"
1237+
"@vue/compiler-dom" "3.0.0-rc.10"
1238+
"@vue/compiler-ssr" "3.0.0-rc.10"
1239+
"@vue/shared" "3.0.0-rc.10"
12591240
consolidate "^0.15.1"
12601241
estree-walker "^2.0.1"
12611242
hash-sum "^2.0.0"
@@ -1267,47 +1248,42 @@
12671248
postcss-selector-parser "^6.0.2"
12681249
source-map "^0.6.1"
12691250

1270-
"@vue/[email protected].5":
1271-
version "3.0.0-rc.5"
1272-
resolved "https://registry.yarnpkg.com/@vue/compiler-ssr/-/compiler-ssr-3.0.0-rc.5.tgz#878406c59daff362ecdcb199fb9467a769ca8de5"
1273-
integrity sha512-OU5Vl2+bCDMImS9OeCVnl4lfxZ3/sopdwX2SrUWVKQvCxmmmlyWvoVkC6nNGCs/MrOmIMhKmL6etgzLTWyCkUg==
1251+
"@vue/[email protected].10":
1252+
version "3.0.0-rc.10"
1253+
resolved "https://registry.yarnpkg.com/@vue/compiler-ssr/-/compiler-ssr-3.0.0-rc.10.tgz#95a5f6b65b19a514c94f056994ec144b3b1b03ae"
1254+
integrity sha512-JBPil8sO5j7puB8acX2CQMRXEYB/EP8PoEur7RcF/+aqATI7C4yqWcSLC5TRJpigj6xE6ku6sx8om+j7ZHvgBw==
12741255
dependencies:
1275-
"@vue/compiler-dom" "3.0.0-rc.5"
1276-
"@vue/shared" "3.0.0-rc.5"
1256+
"@vue/compiler-dom" "3.0.0-rc.10"
1257+
"@vue/shared" "3.0.0-rc.10"
12771258

1278-
"@vue/[email protected].7":
1279-
version "3.0.0-rc.7"
1280-
resolved "https://registry.yarnpkg.com/@vue/reactivity/-/reactivity-3.0.0-rc.7.tgz#fd5fda961c57a8065c6408170e06808a39f801a2"
1281-
integrity sha512-j8wUuc131JrHvQzEWjlRMYHadRLhGaubIZHR+4QO/xwvNIdJWK8zQd9iqxizjBW0E1MhrZkDbsiClNN8lq/ILQ==
1259+
"@vue/[email protected].10":
1260+
version "3.0.0-rc.10"
1261+
resolved "https://registry.yarnpkg.com/@vue/reactivity/-/reactivity-3.0.0-rc.10.tgz#34d5f51bcc5a7c36e27d7a9c1bd7a3d25ffa7c56"
1262+
integrity sha512-mkUZfOJlbqGZx2cARmhCs5r2+xLJPL7VFNagmlA3Fd66ZXBc3ZvTQdYsY4VUbYJFe5ByIzqu9TZiAkzXY+JVaA==
12821263
dependencies:
1283-
"@vue/shared" "3.0.0-rc.7"
1264+
"@vue/shared" "3.0.0-rc.10"
12841265

1285-
"@vue/[email protected].7":
1286-
version "3.0.0-rc.7"
1287-
resolved "https://registry.yarnpkg.com/@vue/runtime-core/-/runtime-core-3.0.0-rc.7.tgz#739f2c21dfdc509b0b05fefe2d84eafd7b990075"
1288-
integrity sha512-xY+3Mw+3Nb8BxfYftQug3UAUHPJPvbhNkyVuCMVgBRBsZIFbiL6F+gy22Wd7Q6zgWagUQCtH1FDrPZARj6tySg==
1266+
"@vue/[email protected].10":
1267+
version "3.0.0-rc.10"
1268+
resolved "https://registry.yarnpkg.com/@vue/runtime-core/-/runtime-core-3.0.0-rc.10.tgz#9055aef5113cbc328aaec29760c2151e0ed3cf40"
1269+
integrity sha512-VK/kq4gDDoqZ45CVwdbLLpikXLYLCt6YLhdgXX3fhf20gvPqrbEZv1ZNLruNnhhTpf9cLyU4tZ18DHeaUYPziw==
12891270
dependencies:
1290-
"@vue/reactivity" "3.0.0-rc.7"
1291-
"@vue/shared" "3.0.0-rc.7"
1271+
"@vue/reactivity" "3.0.0-rc.10"
1272+
"@vue/shared" "3.0.0-rc.10"
12921273

1293-
"@vue/[email protected].7":
1294-
version "3.0.0-rc.7"
1295-
resolved "https://registry.yarnpkg.com/@vue/runtime-dom/-/runtime-dom-3.0.0-rc.7.tgz#9a89560b30a7f27422e2934281a9e5947f7938f9"
1296-
integrity sha512-tgLl/tSIdovP/6uEzKrhwG5MwFu0yJ3l0bPUCyyFJM4tnnHiRtr9Zsn6GVDZYwImtBgBwByqBMML8ZYlVEqH9w==
1274+
"@vue/[email protected].10":
1275+
version "3.0.0-rc.10"
1276+
resolved "https://registry.yarnpkg.com/@vue/runtime-dom/-/runtime-dom-3.0.0-rc.10.tgz#50f95cb991483a4262163723320967ad17bb321f"
1277+
integrity sha512-bH4GuneHt3FQ+/21jba5orM/CO9N1cnT7J3wtrxopFJ4/4H5cvHXyG6v+ZVTu1d733Ij/6yMRA7xbtfi9a4zJw==
12971278
dependencies:
1298-
"@vue/runtime-core" "3.0.0-rc.7"
1299-
"@vue/shared" "3.0.0-rc.7"
1279+
"@vue/runtime-core" "3.0.0-rc.10"
1280+
"@vue/shared" "3.0.0-rc.10"
13001281
csstype "^2.6.8"
13011282

1302-
"@vue/[email protected]":
1303-
version "3.0.0-rc.5"
1304-
resolved "https://registry.yarnpkg.com/@vue/shared/-/shared-3.0.0-rc.5.tgz#cea2378e3e37363ddc1f5dd158edc9c9b5b3fff0"
1305-
integrity sha512-ZhcgGzBpp+pUzisZgQpM4ctIGgLpYjBj7/rZfbhEPxFHF/BuTV2jmhXvAl8aF9xDAejIcw85xCy92gDSwKtPag==
1306-
1307-
"@vue/[email protected]":
1308-
version "3.0.0-rc.7"
1309-
resolved "https://registry.yarnpkg.com/@vue/shared/-/shared-3.0.0-rc.7.tgz#62054a314105019efab590f767db528c8c603954"
1310-
integrity sha512-wRqe6DvR9UIH4Il4bxMIbuGupWFtJW+PZKqgclYjuO+zWNQEC7hC5OxONgXeGcv1h4KtfJsc8wSU31hxok9XAQ==
1283+
"@vue/[email protected]":
1284+
version "3.0.0-rc.10"
1285+
resolved "https://registry.yarnpkg.com/@vue/shared/-/shared-3.0.0-rc.10.tgz#e7ab62abcabbfc738545902b96a3aa78f59f3286"
1286+
integrity sha512-fI6gVhhgb3cAmEkY4oeVVA2hWZ2xvkgogHdBI5PL7gSvZnOB6XZ2eQGsYjC4W+7BegvEkoMBuZsFXVa4ZQ07XQ==
13111287

13121288
abab@^2.0.0, abab@^2.0.3:
13131289
version "2.0.3"
@@ -5992,14 +5968,14 @@ vue-router@^4.0.0-alpha.14:
59925968
resolved "https://registry.yarnpkg.com/vue-router/-/vue-router-4.0.0-alpha.14.tgz#4bc5fed1db61b8d04fd95ad9c499c7428f039a0e"
59935969
integrity sha512-ydWSXxXAsTCiJ31V4x4ZAKI1CdpPMhf7b2LPi4AmG5SCgduu1zf+LhzWWHXmgbmheEiJpfecigVIZp4ABpZJmw==
59945970

5995-
vue@^3.0.0-rc.7:
5996-
version "3.0.0-rc.7"
5997-
resolved "https://registry.yarnpkg.com/vue/-/vue-3.0.0-rc.7.tgz#4b98438cc908708d87d4a0a11bd4497e5385ff66"
5998-
integrity sha512-WX7i6yI0VGzI2mwlGqfISDbi/fNAuc0QEOcF4NH4IEdWFUWCbMMUJ6frYCgRd3FzqzPJwuV8niXKhFL28FnQ7g==
5971+
vue@^3.0.0-rc.10:
5972+
version "3.0.0-rc.10"
5973+
resolved "https://registry.yarnpkg.com/vue/-/vue-3.0.0-rc.10.tgz#31298a757b4fad6ee8973d0fa27c4fde8574bd01"
5974+
integrity sha512-nRsyIQtOWLDMBb5dsPwg/WdIqznCMVWN6O6wJSzhseKC768wHlZKcJ7SPHhWPid9wi3Ykhtl9vtgvxTK/qICkw==
59995975
dependencies:
6000-
"@vue/compiler-dom" "3.0.0-rc.7"
6001-
"@vue/runtime-dom" "3.0.0-rc.7"
6002-
"@vue/shared" "3.0.0-rc.7"
5976+
"@vue/compiler-dom" "3.0.0-rc.10"
5977+
"@vue/runtime-dom" "3.0.0-rc.10"
5978+
"@vue/shared" "3.0.0-rc.10"
60035979

60045980
vuex@^4.0.0-beta.1:
60055981
version "4.0.0-beta.1"

0 commit comments

Comments
 (0)