refactor: remove lodash mergeWith and replace with custom implementation

Author: lmiller1990

src/utils.ts

@@ -1,29 +1,30 @@
 import isString from 'lodash/isString'
-import mergeWith from 'lodash/mergeWith'
 
 import { GlobalMountOptions } from './types'
 
+// Deep merge function, adapted from from https://gist.github.com/ahtcx/0cd94e62691f539160b32ecda18af3d6
+// Merge a `source` object to a `target` recursively
+const merge = (target: object, source: object) => {
+  // Iterate through `source` properties and if an `Object` set property to merge of `target` and `source` properties
+  for (const key of Object.keys(source)) {
+    if (!target[key]) {
+      target[key] = source[key]
+    } else {
+      if (source[key] instanceof Object) {
+        Object.assign(source[key], merge(target[key], source[key]))
+      }
+    }
+  }
+
+  Object.assign(target || {}, source)
+}
+
 function mergeGlobalProperties(
   configGlobal: GlobalMountOptions = {},
   mountGlobal: GlobalMountOptions = {}
 ): GlobalMountOptions {
-  return mergeWith(
-    {},
-    configGlobal,
-    mountGlobal,
-    (objValue, srcValue, key: keyof GlobalMountOptions) => {
-      switch (key) {
-        case 'mocks':
-        case 'provide':
-        case 'components':
-        case 'directives':
-          return { ...objValue, ...srcValue }
-        case 'plugins':
-        case 'mixins':
-          return [...(objValue || []), ...(srcValue || [])].filter(Boolean)
-      }
-    }
-  )
+  merge(configGlobal, mountGlobal)
+  return configGlobal
 }
 
 export { isString, mergeGlobalProperties }

tests/config.spec.ts

@@ -20,11 +20,19 @@ describe('config', () => {
     }
 
     it('allows setting components globally', () => {
-      config.global.components = { Hello }
-      const wrapper1 = mount(Component, { props: { msg: 'Wrapper1' } })
-      const wrapper2 = mount(Component, { props: { msg: 'Wrapper2' } })
-      expect(wrapper1.text()).toEqual('Wrapper1 Hello world')
-      expect(wrapper2.text()).toEqual('Wrapper2 Hello world')
+      const HelloLocal = {
+        props: ['msg'],
+        template: '<div>{{ msg }}</div>'
+      }
+      config.global.components = { Hello: HelloLocal }
+      const wrapper1 = mount(Component, {
+        props: { msg: 'Wrapper1 Overwritten' }
+      })
+      const wrapper2 = mount(Component, {
+        props: { msg: 'Wrapper2 Overwritten' }
+      })
+      expect(wrapper1.text()).toEqual('Wrapper1 Overwritten')
+      expect(wrapper2.text()).toEqual('Wrapper2 Overwritten')
     })
 
     it('allows overwriting globally set component config on a per mount instance', () => {

tests/mountingOptions/stubs.global.spec.ts

@@ -6,6 +6,14 @@ import ComponentWithoutName from '../components/ComponentWithoutName.vue'
 import ComponentWithSlots from '../components/ComponentWithSlots.vue'
 
 describe('mounting options: stubs', () => {
+  beforeEach(() => {
+    config.global.stubs = {}
+  })
+
+  afterEach(() => {
+    config.global.stubs = {}
+  })
+
   it('handles Array syntax', () => {
     const Foo = {
       name: 'Foo',