Skip to content

Commit b08b1f0

Browse files
committed
fix: properly declare optional peer deps
We used `optionalDependencies` in #1958 but I think the proper way is to use `peerDependenciesMeta`. This fixes the current issue where pnpm installs compiler-dom and server-renderer in v3.2.47, despite v3.3.1 being available.
1 parent 41b772e commit b08b1f0

File tree

2 files changed

+39
-75
lines changed

2 files changed

+39
-75
lines changed

package.json

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,13 @@
7070
"@vue/server-renderer": "^3.0.1",
7171
"vue": "^3.0.1"
7272
},
73-
"optionalDependencies": {
74-
"@vue/compiler-dom": "^3.0.1",
75-
"@vue/server-renderer": "^3.0.1"
73+
"peerDependenciesMeta": {
74+
"@vue/compiler-dom": {
75+
"optional": true
76+
},
77+
"@vue/server-renderer": {
78+
"optional": true
79+
}
7680
},
7781
"author": {
7882
"name": "Lachlan Miller",
@@ -121,4 +125,4 @@
121125
]
122126
}
123127
}
124-
}
128+
}

pnpm-lock.yaml

Lines changed: 31 additions & 71 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)